Re: [Intel-gfx] [PATCH 4/4] drm/i915: Reduce frequency of unspecific HSW reg debugging

2015-09-04 Thread Mika Kuoppala
Paulo Zanoni writes: > From: Chris Wilson > > Delay the expensive read on the FPGA_DBG register from once per mmio to > once per forcewake section when we are doing the general wellbeing > check rather than the targetted error detection. This almost reduces > the overhead of the debug facility (

Re: [Intel-gfx] [PATCH 2/2] drm/i915/skl+: Add YUV pixel format in Capability list

2015-09-04 Thread Daniel Vetter
On Thu, Sep 03, 2015 at 11:30:07AM +, Jindal, Sonika wrote: > Reviewed-by: Sonika Jindal > > -Original Message- > From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of > Kumar, Mahesh > Sent: Thursday, September 3, 2015 4:17 PM > To: intel-gfx@lists.freedeskto

Re: [Intel-gfx] [PATCH 14/15] drm/i915: skl nv12 workarounds

2015-09-04 Thread Daniel Vetter
On Thu, Sep 03, 2015 at 06:33:25PM +, Konduru, Chandra wrote: > > > -Original Message- > > From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel > > Vetter > > Sent: Wednesday, September 02, 2015 1:02 AM > > To: Konduru, Chandra > > Cc: Daniel Vetter; intel-gfx@lists

Re: [Intel-gfx] [PATCH 1/4] drm/i915: read dpcd 0 - 12 & link_status always

2015-09-04 Thread Daniel Vetter
On Thu, Sep 03, 2015 at 03:25:04PM +0300, Jani Nikula wrote: > On Wed, 02 Sep 2015, Daniel Vetter wrote: > > On Tue, Sep 01, 2015 at 01:16:49PM +0300, Jani Nikula wrote: > >> On Thu, 27 Aug 2015, Sivakumar Thulasimani > >> wrote: > >> > From: "Thulasimani,Sivakumar" > >> > > >> > Compliance req

Re: [Intel-gfx] [PATCH] drm/i915: Fix broken mst get_hw_state.

2015-09-04 Thread Daniel Vetter
On Thu, Aug 27, 2015 at 01:13:31PM +0200, Maarten Lankhorst wrote: > connector->encoder is initialized as NULL. Fix this by setting it in > during pre enable. MST connectors are not read out during initial hw > readout, and have no fixed encoder mappings. So it's harmless to > return false when the

Re: [Intel-gfx] [PATCH v5] drm/i915/gtt: Avoid calling kcalloc in a loop when allocating temp bitmaps

2015-09-04 Thread Daniel Vetter
On Thu, Sep 03, 2015 at 09:48:03PM +0100, Chris Wilson wrote: > On Thu, Sep 03, 2015 at 07:22:18PM +0200, Michał Winiarski wrote: > > + pts = kcalloc(pdpes * BITS_TO_LONGS(I915_PDES), > > + sizeof(unsigned long), GFP_TEMPORARY); > > Something to remember is that kcalloc is writte

Re: [Intel-gfx] [PATCH] drm/i915: add kerneldoc for i915_audio_component

2015-09-04 Thread Daniel Vetter
On Fri, Sep 04, 2015 at 09:40:17AM +0300, Jani Nikula wrote: > On Fri, 04 Sep 2015, "Yang, Libin" wrote: > >> -Original Message- > >> From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of > >> Daniel Vetter > >> Sent: Wednesday, September 02, 2015 8:18 PM > >> To: Yang, Libin >

Re: [Intel-gfx] [PATCH] drm/i915: Improve kernel-doc for i915_audio_component struct

2015-09-04 Thread Daniel Vetter
On Thu, Sep 03, 2015 at 01:24:45PM +0200, David Henningsson wrote: > To make kernel-doc happy, the i915_audio_component_audio_ops struct > cannot be nested. > > Signed-off-by: David Henningsson > --- > > Note that I didn't do the same un-nesting for i915_audio_component_ops. > This is to make it

Re: [Intel-gfx] [PATCH] drm/i915: Future proof uncore_init.

2015-09-04 Thread Daniel Vetter
On Thu, Sep 03, 2015 at 02:38:00PM -0700, Rodrigo Vivi wrote: > Unless future specs tells otherwise we can assume future gens > inherit some stuff from the previous so let's handle > missed cases when we know tehy should't be there and assume > default equals newest one. > > No functional changes.

Re: [Intel-gfx] [PATCH] drm/i915: Add GuC css header parser

2015-09-04 Thread Daniel Vetter
On Wed, Sep 02, 2015 at 03:52:35PM -0700, yu@intel.com wrote: > From: Alex Dai > > By using information from GuC css header, we can eliminate some > hard code w.r.t size of some components of firmware. > > Signed-off-by: Alex Dai > --- > drivers/gpu/drm/i915/intel_guc.h| 2 +- > d

Re: [Intel-gfx] [PATCH i-g-t 1/2] tests/gem_storedw_loop: skip on gen6 bsd

2015-09-04 Thread Daniel Vetter
On Thu, Sep 03, 2015 at 10:05:27AM +0100, Thomas Wood wrote: > Signed-off-by: Thomas Wood Bit more commit message would be good, just copypaste the debug output ;-) lgtm otherwise on the patch series. -Daniel > --- > tests/gem_storedw_loop.c | 13 +++-- > 1 file changed, 11 insertions(+

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Refactor common ringbuffer allocation code

2015-09-04 Thread Daniel Vetter
On Thu, Sep 03, 2015 at 05:56:20PM +0300, Mika Kuoppala wrote: > "Zanoni, Paulo R" writes: > > > Em Qui, 2015-09-03 às 13:01 +0100, Chris Wilson escreveu: > >> A small, very small, step to sharing the duplicate code between > >> execlists and legacy submission engines, starting with the ringbuffe

Re: [Intel-gfx] [REBASED PATCH 0/3] drm/i915: tps3 updates, use yesno helper

2015-09-04 Thread Daniel Vetter
On Thu, Sep 03, 2015 at 11:16:06AM +0300, Jani Nikula wrote: > The remaining patches from [1] rebased on top of current nightly for > convenience. Just s/intel_dp_tps3_supported/drm_dp_tps3_supported/g. Thanks for rebasing, all applied to dinq. -Daniel > > BR, > Jani. > > [1] > http://mid.gman

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915: access the PP_ON_DELAYS/PP_OFF_DELAYS regs only pre GEN5

2015-09-04 Thread Daniel Vetter
On Thu, Sep 03, 2015 at 04:41:59PM +0300, Ville Syrjälä wrote: > On Thu, Sep 03, 2015 at 04:24:36PM +0300, Imre Deak wrote: > > These registers exist only before GEN5, so currently we may access > > undefined registers on VLV/CHV and BXT. Apply the workaround only pre > > GEN5. > > > > Since the w

Re: [Intel-gfx] [PATCH 01/15] drm/i915: Allocate min dbuf blocks per bspec

2015-09-04 Thread Ville Syrjälä
On Wed, Aug 19, 2015 at 06:02:22PM -0700, Chandra Konduru wrote: > Properly allocate min blocks per hw requirements. > > Signed-off-by: Chandra Konduru > --- > drivers/gpu/drm/i915/intel_pm.c | 39 > +-- > 1 file changed, 37 insertions(+), 2 deletions(-) >

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Reduce frequency of unspecific HSW reg debugging

2015-09-04 Thread Daniel Vetter
On Thu, Sep 03, 2015 at 04:51:45PM -0300, Paulo Zanoni wrote: > From: Chris Wilson > > Delay the expensive read on the FPGA_DBG register from once per mmio to > once per forcewake section when we are doing the general wellbeing > check rather than the targetted error detection. This almost reduce

Re: [Intel-gfx] [PATCH 02/15] drm/i915: In DBUF/WM calcs for 90/270, swap w & h

2015-09-04 Thread Ville Syrjälä
On Wed, Aug 19, 2015 at 06:02:23PM -0700, Chandra Konduru wrote: > This patch swaps src width and height for dbuf/wm calculations > when rotation is 90/270 as per hw requirements. The spec is rather unclear about this. It only says: "If plane 90 or 270 rotation is enabled, use the rotated width an

Re: [Intel-gfx] [PATCH 14/14] drm/i915: Dump pfit state as hex

2015-09-04 Thread Daniel Vetter
On Thu, Sep 03, 2015 at 09:50:16PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > The pfit state is stored as register values, so dump them as hex instead > of decimal to make some sense of the error messages. > > Signed-off-by: Ville Syrjälä Picked just this one because

Re: [Intel-gfx] [PATCH 03/15] drm/i915: Add register definitions for NV12 support

2015-09-04 Thread Ville Syrjälä
On Wed, Aug 19, 2015 at 06:02:24PM -0700, Chandra Konduru wrote: > This patch adds register definitions for skylake > display NV12 support. > > Signed-off-by: Chandra Konduru > --- > drivers/gpu/drm/i915/i915_reg.h | 27 +++ > 1 file changed, 27 insertions(+) > > diff

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Reduce frequency of unspecific HSW reg debugging

2015-09-04 Thread Mika Kuoppala
Daniel Vetter writes: > On Thu, Sep 03, 2015 at 04:51:45PM -0300, Paulo Zanoni wrote: >> From: Chris Wilson >> >> Delay the expensive read on the FPGA_DBG register from once per mmio to >> once per forcewake section when we are doing the general wellbeing >> check rather than the targetted erro

Re: [Intel-gfx] [PATCH] drm/i915: Fix cmdparser STORE/LOAD command descriptors

2015-09-04 Thread Daniel Vetter
On Thu, Sep 03, 2015 at 11:06:38AM +0100, Arun Siluvery wrote: > On 02/09/2015 12:29, Chris Wilson wrote: > >Fixes regression from > >commit f1afe24f0e736b9d7f2275e2b1504af3fe612f2a > >Author: Arun Siluvery > >Date: Tue Aug 4 16:22:20 2015 +0100 > > > > drm/i915: Change SRM, LRM instructions

Re: [Intel-gfx] [PATCH 04/15] drm/i915: Set scaler mode for NV12

2015-09-04 Thread Ville Syrjälä
On Wed, Aug 19, 2015 at 06:02:25PM -0700, Chandra Konduru wrote: > This patch sets appropriate scaler mode for NV12 format. > In this mode, skylake scaler does either chroma-upsampling or > chroma-upsampling and resolution scaling. > > Signed-off-by: Chandra Konduru > --- > drivers/gpu/drm/i915/

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915: access the PP_ON_DELAYS/PP_OFF_DELAYS regs only pre GEN5

2015-09-04 Thread Jani Nikula
On Thu, 03 Sep 2015, Imre Deak wrote: > These registers exist only before GEN5, so currently we may access > undefined registers on VLV/CHV and BXT. Apply the workaround only pre > GEN5. > > Since the workaround is relevant only when LVDS is present, for clarity > apply it only if this is the case

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Reduce frequency of unspecific HSW reg debugging

2015-09-04 Thread Daniel Vetter
On Fri, Sep 04, 2015 at 11:40:26AM +0300, Mika Kuoppala wrote: > Daniel Vetter writes: > > > On Thu, Sep 03, 2015 at 04:51:45PM -0300, Paulo Zanoni wrote: > >> From: Chris Wilson > >> > >> Delay the expensive read on the FPGA_DBG register from once per mmio to > >> once per forcewake section wh

Re: [Intel-gfx] [PATCH 05/15] drm/i915: Stage scaler request for NV12 as src format

2015-09-04 Thread Ville Syrjälä
On Wed, Aug 19, 2015 at 06:02:26PM -0700, Chandra Konduru wrote: > This patch stages a scaler request when input format > is NV12. The same scaler does both chroma-upsampling > and resolution scaling as needed. > > v2: > -Added helper function for need_scaling (Ville) > > v3: > -Rebased to curren

Re: [Intel-gfx] [PATCH 06/15] drm/i915: Update format_is_yuv() to include NV12

2015-09-04 Thread Ville Syrjälä
On Wed, Aug 19, 2015 at 06:02:27PM -0700, Chandra Konduru wrote: > This patch adds NV12 to format_is_yuv() function > and made it available for both primary and sprite > planes. > > v2: > -Use intel_ prefix for format_is_yuv (Ville) > > Signed-off-by: Chandra Konduru Reviewed-by: Ville Syrjälä

Re: [Intel-gfx] [PATCH 07/15] drm/i915: Upscale scaler max scale for NV12.

2015-09-04 Thread Ville Syrjälä
On Wed, Aug 19, 2015 at 06:02:28PM -0700, Chandra Konduru wrote: > This patch updates max supported scaler limits for NV12. > > v2: > -Rebased to current kernel version 4.2.0.rc4 (me) > > Signed-off-by: Chandra Konduru > --- > drivers/gpu/drm/i915/intel_display.c | 13 + > drivers

Re: [Intel-gfx] [PATCH 09/15] drm/i915: Add NV12 as supported format for sprite plane

2015-09-04 Thread Ville Syrjälä
On Wed, Aug 19, 2015 at 06:02:30PM -0700, Chandra Konduru wrote: > This patch adds NV12 to list of supported formats for > sprite plane. > > Signed-off-by: Chandra Konduru > Testcase: igt/kms_nv12 > --- > drivers/gpu/drm/i915/intel_sprite.c | 23 +-- > 1 file changed, 21 in

[Intel-gfx] [PATCH i-g-t] tools: remove quick_dump

2015-09-04 Thread Thomas Wood
Remove quick_dump as it has been replaced by the intel_reg tool and move the register definition files to tools/registers. Signed-off-by: Thomas Wood --- README | 13 --- configure.ac | 27 + man/intel_reg.rs

Re: [Intel-gfx] [PATCH] drm/i915: Improve kernel-doc for i915_audio_component struct

2015-09-04 Thread David Henningsson
On 2015-09-04 10:03, Daniel Vetter wrote: Also please use the new inline style for struct members. I tried that, but I couldn't get it to work. This was with Takashi's for-next tree, do I need to apply some docbook special patches on top of that to get the new functionality? -- David Henn

Re: [Intel-gfx] [PATCH 10/15] drm/i915: Add NV12 support to intel_framebuffer_init

2015-09-04 Thread Ville Syrjälä
On Wed, Aug 19, 2015 at 06:02:31PM -0700, Chandra Konduru wrote: > This patch adds NV12 as supported format to > intel_framebuffer_init and performs various checks. > > v2: > -Fix an issue in checks added (me) > > Signed-off-by: Chandra Konduru > Testcase: igt/kms_nv12 > --- > drivers/gpu/drm/i

Re: [Intel-gfx] [PATCH] drm/i915: Improve kernel-doc for i915_audio_component struct

2015-09-04 Thread Takashi Iwai
On Fri, 04 Sep 2015 12:33:45 +0200, David Henningsson wrote: > > > > On 2015-09-04 10:03, Daniel Vetter wrote: > > Also please use the new inline style for struct members. > > I tried that, but I couldn't get it to work. This was with Takashi's > for-next tree, do I need to apply some docbook

Re: [Intel-gfx] [PATCH 11/15] drm/i915: Add NV12 to primary plane programming.

2015-09-04 Thread Ville Syrjälä
On Wed, Aug 19, 2015 at 06:02:32PM -0700, Chandra Konduru wrote: > This patch is adding NV12 support to skylake primary plane > programming. It is covering linear/X/Y/Yf tiling formats > for 0 and 180 rotations. > > For 90/270 rotation, Y and UV subplanes should be treated > as separate surfaces a

Re: [Intel-gfx] [PATCH 13/15] drm/i915: Set initial phase & trip for NV12 scaler

2015-09-04 Thread Ville Syrjälä
On Wed, Aug 19, 2015 at 06:02:34PM -0700, Chandra Konduru wrote: > This patch sets default initial phase and trip to scale NV12 > content. In future, if needed these can be set via properties > or other means depending on incoming stream request. Until then > defaults are fine. We should set it ac

Re: [Intel-gfx] [PATCH 14/15] drm/i915: skl nv12 workarounds

2015-09-04 Thread Ville Syrjälä
On Wed, Aug 19, 2015 at 06:02:35PM -0700, Chandra Konduru wrote: > Adding driver workarounds for nv12. > > Signed-off-by: Chandra Konduru > --- > drivers/gpu/drm/i915/i915_reg.h | 20 > drivers/gpu/drm/i915/intel_csr.c |2 +- > drivers/gpu/drm/i915/intel_displ

Re: [Intel-gfx] [PATCH 15/15] drm/i915: Add 90/270 rotation for NV12 format.

2015-09-04 Thread Ville Syrjälä
On Wed, Aug 19, 2015 at 06:02:36PM -0700, Chandra Konduru wrote: > Adding NV12 90/270 rotation support for primary and sprite planes. > > v2: > -For 90/270 adjust pixel boundary only in Y-direction (bspec) > > v3: > -Rebased (me) > > Signed-off-by: Chandra Konduru > Testcase: igt/kms_nv12 > ---

Re: [Intel-gfx] [PATCH i-g-t] tools: remove quick_dump

2015-09-04 Thread Ville Syrjälä
On Fri, Sep 04, 2015 at 11:22:28AM +0100, Thomas Wood wrote: > Remove quick_dump as it has been replaced by the intel_reg tool and move > the register definition files to tools/registers. > > Signed-off-by: Thomas Wood NAK It's the only tool that works on VLV/CHV reasonably. > --- > README

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Reduce frequency of unspecific HSW reg debugging

2015-09-04 Thread Mika Kuoppala
Daniel Vetter writes: > On Fri, Sep 04, 2015 at 11:40:26AM +0300, Mika Kuoppala wrote: >> Daniel Vetter writes: >> >> > On Thu, Sep 03, 2015 at 04:51:45PM -0300, Paulo Zanoni wrote: >> >> From: Chris Wilson >> >> >> >> Delay the expensive read on the FPGA_DBG register from once per mmio to >>

Re: [Intel-gfx] [PATCH 3/4] drm/i915: remove intel_uncore_check_errors()

2015-09-04 Thread Mika Kuoppala
Paulo Zanoni writes: > I added this code on 8664281b64c457705db72fc60143d03827e75ca9, on > April 12 2013. Back then, we only had support for detecting unclaimed > registers on I915_WRITE operations, and we didn't have the > i915.mmio_debug infrastructure. > > I tried to remember exactly why I add

Re: [Intel-gfx] [PATCH i-g-t] tools: remove quick_dump

2015-09-04 Thread Ville Syrjälä
On Fri, Sep 04, 2015 at 02:38:41PM +0300, Ville Syrjälä wrote: > On Fri, Sep 04, 2015 at 11:22:28AM +0100, Thomas Wood wrote: > > Remove quick_dump as it has been replaced by the intel_reg tool and move > > the register definition files to tools/registers. > > > > Signed-off-by: Thomas Wood > >

Re: [Intel-gfx] [PATCH i-g-t] tools: remove quick_dump

2015-09-04 Thread Jani Nikula
On Fri, 04 Sep 2015, Thomas Wood wrote: > Remove quick_dump as it has been replaced by the intel_reg tool and move > the register definition files to tools/registers. > > Signed-off-by: Thomas Wood Acked-by: Jani Nikula As a follow-up, I'd like it if Someone(tm) would add rules to install the

Re: [Intel-gfx] [PATCH i-g-t] tools: remove quick_dump

2015-09-04 Thread Jani Nikula
On Fri, 04 Sep 2015, Ville Syrjälä wrote: > On Fri, Sep 04, 2015 at 11:22:28AM +0100, Thomas Wood wrote: >> Remove quick_dump as it has been replaced by the intel_reg tool and move >> the register definition files to tools/registers. >> >> Signed-off-by: Thomas Wood > > NAK > > It's the only too

[Intel-gfx] [PATCH 1/2] drm/i915: WaEnableForceRestoreInCtxtDescForVCS is for video engines only

2015-09-04 Thread Michel Thierry
Also check for correct revision id in each Gen9 platform (SKL until B0 and BXT until A0). Cc: Nick Hoath Signed-off-by: Michel Thierry --- drivers/gpu/drm/i915/intel_lrc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/

[Intel-gfx] [PATCH 2/2] drm/i915/lrc: Prevent preemption when lite-restore is disabled

2015-09-04 Thread Michel Thierry
When WaEnableForceRestoreInCtxtDescForVCS is required, it is only safe to send new contexts if the last reported event is "active to idle". Otherwise the same context can fully preempt itself because lite-restore is disabled. Testcase: igt/gem_concurrent_blit Reported-by: Daniele Ceraolo Spurio S

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Reduce frequency of unspecific HSW reg debugging

2015-09-04 Thread Mika Kuoppala
Mika Kuoppala writes: > Daniel Vetter writes: > >> On Fri, Sep 04, 2015 at 11:40:26AM +0300, Mika Kuoppala wrote: >>> Daniel Vetter writes: >>> >>> > On Thu, Sep 03, 2015 at 04:51:45PM -0300, Paulo Zanoni wrote: >>> >> From: Chris Wilson >>> >> >>> >> Delay the expensive read on the FPGA_DBG

Re: [Intel-gfx] [PATCH 2/2] drm/i915: initialize backlight max from VBT

2015-09-04 Thread Jani Nikula
On Thu, 27 Aug 2015, Clint Taylor wrote: > On 08/26/2015 12:58 AM, Jani Nikula wrote: >> Normally we determine the backlight PWM modulation frequency (which we >> also use as backlight max value) from the backlight registers at module >> load time, expecting the registers have been initialized by

Re: [Intel-gfx] [PATCH 2/2] drm/i915: initialize backlight max from VBT

2015-09-04 Thread Jani Nikula
On Fri, 04 Sep 2015, Jani Nikula wrote: > On Thu, 27 Aug 2015, Clint Taylor wrote: >> On 08/26/2015 12:58 AM, Jani Nikula wrote: >>> Normally we determine the backlight PWM modulation frequency (which we >>> also use as backlight max value) from the backlight registers at module >>> load time, ex

[Intel-gfx] [PATCH 3/6] drm/i915: Make intel_digital_port_connected global

2015-09-04 Thread Sonika Jindal
This is to allow live status check for HDMI as well. Also, using intel_encoder->hpd_pin to check the live status for bxt because of BXT A0/A1 WA for HPD pins. Signed-off-by: Sonika Jindal --- drivers/gpu/drm/i915/intel_dp.c | 11 +++ drivers/gpu/drm/i915/intel_drv.h |2 ++ 2 files

[Intel-gfx] [PATCH 0/6] HDMI optimization series

2015-09-04 Thread Sonika Jindal
This series adds changes in HDMI detection methods and also afew optimization. The overview of changes are: 1. HDMI EDID is read only at the hot-plug time. 2. EDID is cached in connectoer on hotplug,and released from cache only on the hot-unplug. 3. In between, for all detetct calls, only cached

[Intel-gfx] [PATCH 6/6] drm/i915/bxt: Fix irq_port for eDP

2015-09-04 Thread Sonika Jindal
From: Durgadoss R Currently, HDMI hotplug with eDP as local panel is failing because the HDMI hpd is detected as a long hpd for eDP; and is thus rightfully ignored. But, it should really be handled as an interrupt on port B for HDMI (due to BXT A1 platform having HPD pins A and B swapped). This p

Re: [Intel-gfx] [PATCH 2/4] drm/i915: restrict unclaimed register checking

2015-09-04 Thread Zanoni, Paulo R
Em Sex, 2015-09-04 às 09:53 +0300, Mika Kuoppala escreveu: > Paulo Zanoni writes: > > > The unclaimed register bit is only triggered when someone touches > > the > > specified register range. > > > > I got the impression that we get the unclaimed access also > for other ranges, if they are pow

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Reduce frequency of unspecific HSW reg debugging

2015-09-04 Thread Zanoni, Paulo R
Em Sex, 2015-09-04 às 10:02 +0300, Mika Kuoppala escreveu: > Paulo Zanoni writes: > > > From: Chris Wilson > > > > Delay the expensive read on the FPGA_DBG register from once per > > mmio to > > once per forcewake section when we are doing the general wellbeing > > check rather than the target

[Intel-gfx] [PATCH 2/6] drm/i915: Add HDMI probe function

2015-09-04 Thread Sonika Jindal
From: Shashank Sharma This patch adds a separate probe function for HDMI EDID read over DDC channel. This function has been registered as a .hot_plug handler for HDMI encoder. The current implementation of hdmi_detect() function re-sets the cached HDMI edid (in connector->detect_edid) in every d

[Intel-gfx] [PATCH 4/6] drm/i915: drm/i915: Check live status before reading edid

2015-09-04 Thread Sonika Jindal
The Bspec is very clear that Live status must be checked about before trying to read EDID over DDC channel. This patch makes sure that HDMI EDID is read only when live status us up. The live status doesn't seem to perform very consistent across various platforms when tested with different monitors

[Intel-gfx] [PATCH 5/6] drm/i915: drm/i915: Process hpd only for hdmi inside hotplug_work_func

2015-09-04 Thread Sonika Jindal
If the same port is enumerated as hdmi as well as DP, this will get called for DP connector as well which is not required because i915_hotplug_work_func is solely to handle hdmi HPD. Signed-off-by: Sonika Jindal --- drivers/gpu/drm/i915/intel_hotplug.c |3 ++- 1 file changed, 2 insertions(+)

[Intel-gfx] [PATCH 1/6] drm/i915: add attached connector to hdmi container

2015-09-04 Thread Sonika Jindal
From: Shashank Sharma This patch adds the intel_connector initialized to intel_hdmi display, during the init phase, just like the other encoders do. This attachment is very useful when we need to extract the connector pointer during the hotplug handler function Signed-off-by: Shashank Sharma --

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Reduce frequency of unspecific HSW reg debugging

2015-09-04 Thread Zanoni, Paulo R
Em Sex, 2015-09-04 às 11:40 +0300, Mika Kuoppala escreveu: > Daniel Vetter writes: > > > On Thu, Sep 03, 2015 at 04:51:45PM -0300, Paulo Zanoni wrote: > > > From: Chris Wilson > > > > > > Delay the expensive read on the FPGA_DBG register from once per > > > mmio to > > > once per forcewake sec

[Intel-gfx] [PATCH] drm/i915: Split alloc from init for lrc

2015-09-04 Thread Nick Hoath
Extend init/init_hw split to context init. - Move context initialisation in to i915_gem_init_hw - Move one off initialisation for render ring to i915_gem_validate_context - Move default context initialisation to logical_ring_init Rename intel_lr_context_deferred_create to intel_lr

[Intel-gfx] [PATCH v2 2/3] drm/i915: initialize backlight max from VBT

2015-09-04 Thread Jani Nikula
Normally we determine the backlight PWM modulation frequency (which we also use as backlight max value) from the backlight registers at module load time, expecting the registers have been initialized by the BIOS. If this is not the case, we fail. The VBT contains the backlight modulation frequency

[Intel-gfx] [PATCH v2 3/3] drm/i915: don't hard code vlv backlight frequency if unset

2015-09-04 Thread Jani Nikula
Fall back to VBT based backlight modulation frequency if it's not set. Do not hard code. This could be a problem if there is no VBT. Cc: Clint Taylor Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_panel.c | 13 - 1 file changed, 13 deletions(-) diff --git a/drivers/gpu/

[Intel-gfx] [PATCH v2 1/3] drm/i915: use pch backlight override on hsw too

2015-09-04 Thread Jani Nikula
Currently the difference between backlight control on HSW vs. BDW/SKL is that on HSW we modify the duty cycle on the CPU register, and have the hardware pass the changes on to the PCH registers. We still drive the PCH PWM on both. While HSW and BDW use the same LPT PCH, BDW does not pass these mess

Re: [Intel-gfx] [PATCH 2/4] drm/i915: restrict unclaimed register checking

2015-09-04 Thread Ville Syrjälä
On Fri, Sep 04, 2015 at 01:38:07PM +, Zanoni, Paulo R wrote: > Em Sex, 2015-09-04 às 09:53 +0300, Mika Kuoppala escreveu: > > Paulo Zanoni writes: > > > > > The unclaimed register bit is only triggered when someone touches > > > the > > > specified register range. > > > > > > > I got the i

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Reduce frequency of unspecific HSW reg debugging

2015-09-04 Thread Mika Kuoppala
"Zanoni, Paulo R" writes: > Em Sex, 2015-09-04 às 11:40 +0300, Mika Kuoppala escreveu: >> Daniel Vetter writes: >> >> > On Thu, Sep 03, 2015 at 04:51:45PM -0300, Paulo Zanoni wrote: >> > > From: Chris Wilson >> > > >> > > Delay the expensive read on the FPGA_DBG register from once per >> > >

[Intel-gfx] [PATCH v5 1/2] drm/i915: Fix failure paths around initial fbdev allocation

2015-09-04 Thread Lukas Wunner
From: Tvrtko Ursulin We had two failure modes here: 1. Deadlock in intelfb_alloc failure path where it calls drm_framebuffer_remove, which grabs the struct mutex and intelfb_create (caller of intelfb_alloc) was already holding it. 2. Deadlock in intelfb_create failure path where it calls drm_fr

Re: [Intel-gfx] [PATCH v2 00/22] Enable gpu switching on the MacBook Pro

2015-09-04 Thread Lukas Wunner
Hi Jani, On Mon, Aug 31, 2015 at 10:15:07PM +0300, Jani Nikula wrote: > On Sat, 29 Aug 2015, Lukas Wunner wrote: > > the patch set I've posted August 12 included 3 commits which fix bugs > > in i915. These bugs should be fixed independently of MacBook Pro GPU > > switching, please consider mergin

[Intel-gfx] [PATCH v5 2/2] drm/i915: On fb alloc failure, unref gem object where it gets refed

2015-09-04 Thread Lukas Wunner
Currently when allocating a framebuffer fails, the gem object gets unrefed at the bottom of the call chain in __intel_framebuffer_create, not where it gets refed, which is in intel_framebuffer_create_for_mode (via i915_gem_alloc_object) and in intel_user_framebuffer_create (via drm_gem_object_looku

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Reduce frequency of unspecific HSW reg debugging

2015-09-04 Thread Paulo Zanoni
2015-09-04 10:57 GMT-03:00 Mika Kuoppala : > "Zanoni, Paulo R" writes: > >> Em Sex, 2015-09-04 às 11:40 +0300, Mika Kuoppala escreveu: >>> Daniel Vetter writes: >>> >>> > On Thu, Sep 03, 2015 at 04:51:45PM -0300, Paulo Zanoni wrote: >>> > > From: Chris Wilson >>> > > >>> > > Delay the expensive

[Intel-gfx] [PATCH i-g-t] tools: install the register definition files

2015-09-04 Thread Thomas Wood
Install the register definition files and use them by default in intel_reg. Suggested-by: Jani Nikula Signed-off-by: Thomas Wood --- configure.ac| 5 +++-- tools/Makefile.am | 2 +- tools/intel_reg.c | 4 +++- tools/registers/Makefile.am | 3 ++- 4 files chan

Re: [Intel-gfx] Request Linux Graphic Driver for Intel GMA 3150

2015-09-04 Thread David Ho
Hello Rodrigo/Matt, Running: lspci -ns :00:02.0 | awk -F: '{ print $4 }' returns: a001 (rev 02) I’m not very familiar with “build”. and build your self following: https://01.org/linuxgraphics/documentation/build-guide-0 If I follow all steps in above link, will I get a de

Re: [Intel-gfx] [PATCH 5/6] drm/i915: drm/i915: Process hpd only for hdmi inside hotplug_work_func

2015-09-04 Thread Daniel Vetter
On Fri, Sep 04, 2015 at 06:56:15PM +0530, Sonika Jindal wrote: > If the same port is enumerated as hdmi as well as DP, this will get > called for DP connector as well which is not required because > i915_hotplug_work_func is solely to handle hdmi HPD. > > Signed-off-by: Sonika Jindal > --- > dri

Re: [Intel-gfx] [PATCH 2/6] drm/i915: Add HDMI probe function

2015-09-04 Thread Daniel Vetter
On Fri, Sep 04, 2015 at 06:56:12PM +0530, Sonika Jindal wrote: > From: Shashank Sharma > > This patch adds a separate probe function for HDMI > EDID read over DDC channel. This function has been > registered as a .hot_plug handler for HDMI encoder. > > The current implementation of hdmi_detect()

Re: [Intel-gfx] [PATCH 4/6] drm/i915: drm/i915: Check live status before reading edid

2015-09-04 Thread Daniel Vetter
On Fri, Sep 04, 2015 at 06:56:14PM +0530, Sonika Jindal wrote: > The Bspec is very clear that Live status must be checked about before > trying to read EDID over DDC channel. This patch makes sure that HDMI > EDID is read only when live status us up. > > The live status doesn't seem to perform ver

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Reduce frequency of unspecific HSW reg debugging

2015-09-04 Thread Daniel Vetter
On Fri, Sep 04, 2015 at 03:18:14PM +0300, Mika Kuoppala wrote: > Mika Kuoppala writes: > > > Daniel Vetter writes: > > > >> On Fri, Sep 04, 2015 at 11:40:26AM +0300, Mika Kuoppala wrote: > >>> Daniel Vetter writes: > >>> > >>> > On Thu, Sep 03, 2015 at 04:51:45PM -0300, Paulo Zanoni wrote: > >

Re: [Intel-gfx] [PATCH 04/15] drm/i915: Set scaler mode for NV12

2015-09-04 Thread Daniel Vetter
On Fri, Sep 04, 2015 at 11:53:36AM +0300, Ville Syrjälä wrote: > On a further note, this function could use some cleaning to move > various variables into narrower scope. Now it's rather hard to see what > is valid per iteration and what is valid across the entire loop. It's also rather big, so mi

Re: [Intel-gfx] [PATCH 11/15] drm/i915: Add NV12 to primary plane programming.

2015-09-04 Thread Daniel Vetter
On Fri, Sep 04, 2015 at 02:09:41PM +0300, Ville Syrjälä wrote: > Really, someone should just finally fix the mess we have made with handling > different types of planes in totally different ways and unify things as > much as possible. Yeah I want universal planes for skl finally, and I'd like to h

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Reduce frequency of unspecific HSW reg debugging

2015-09-04 Thread Ville Syrjälä
On Fri, Sep 04, 2015 at 04:53:28PM +0200, Daniel Vetter wrote: > On Fri, Sep 04, 2015 at 03:18:14PM +0300, Mika Kuoppala wrote: > > Mika Kuoppala writes: > > > > > Daniel Vetter writes: > > > > > >> On Fri, Sep 04, 2015 at 11:40:26AM +0300, Mika Kuoppala wrote: > > >>> Daniel Vetter writes: > >

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Reduce frequency of unspecific HSW reg debugging

2015-09-04 Thread Daniel Vetter
On Fri, Sep 04, 2015 at 06:16:19PM +0300, Ville Syrjälä wrote: > On Fri, Sep 04, 2015 at 04:53:28PM +0200, Daniel Vetter wrote: > > On Fri, Sep 04, 2015 at 03:18:14PM +0300, Mika Kuoppala wrote: > > > Mika Kuoppala writes: > > > > > > > Daniel Vetter writes: > > > > > > > >> On Fri, Sep 04, 2015

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Reduce frequency of unspecific HSW reg debugging

2015-09-04 Thread Ville Syrjälä
On Fri, Sep 04, 2015 at 06:16:19PM +0300, Ville Syrjälä wrote: > On Fri, Sep 04, 2015 at 04:53:28PM +0200, Daniel Vetter wrote: > > On Fri, Sep 04, 2015 at 03:18:14PM +0300, Mika Kuoppala wrote: > > > Mika Kuoppala writes: > > > > > > > Daniel Vetter writes: > > > > > > > >> On Fri, Sep 04, 2015

[Intel-gfx] [PATCH i-g-t v2] tools: install the register definition files

2015-09-04 Thread Thomas Wood
Install the register definition files and use them by default in intel_reg. v2: remove redundant path check Suggested-by: Jani Nikula Signed-off-by: Thomas Wood --- configure.ac| 5 +++-- tools/Makefile.am | 2 +- tools/intel_reg.c | 4 ++-- tools/registers/

Re: [Intel-gfx] Request Linux Graphic Driver for Intel GMA 3150

2015-09-04 Thread Vivi, Rodrigo
On Fri, 2015-09-04 at 21:41 +0700, David Ho wrote: > Hello Rodrigo/Matt, > > Running: > lspci -ns :00:02.0 | awk -F: '{ print $4 }' > > returns: > a001 (rev 02) Yes, it is supported. Definitely a Pineview. > > I’m not very familiar with “build”. SO it is probably not recommended option

Re: [Intel-gfx] [PATCH 2/2] drm/i915/lrc: Prevent preemption when lite-restore is disabled

2015-09-04 Thread Daniele Ceraolo Spurio
On 04/09/15 12:59, Michel Thierry wrote: When WaEnableForceRestoreInCtxtDescForVCS is required, it is only safe to send new contexts if the last reported event is "active to idle". Otherwise the same context can fully preempt itself because lite-restore is disabled. Testcase: igt/gem_concurrent_

[Intel-gfx] [RFC] Page table sharing and bufferless execbuf

2015-09-04 Thread Jesse Barnes
I've been carrying something looking rougly like this patchset around internally for a long time now, and with SKL out there now, I figured it's time to get it posted and start the process of integration. David is working on pulling over most of the "driver based PASID handling" and other code int

[Intel-gfx] [PATCH 7/9] drm/i915: add fences to the request struct

2015-09-04 Thread Jesse Barnes
This simplifies the sync code quite a bit. I don't think we'll be able to get away with using the core fence code's seqno support, since we'll be moving away from simple seqno comparisions with the scheduler and preemption, but the additional code is pretty minimal anyway, and lets us add addition

[Intel-gfx] [PATCH 9/9] drm/i915: add bufferless execbuf ioctl

2015-09-04 Thread Jesse Barnes
We just need to pass in an address to execute and some flags, since we don't have to worry about buffer relocation or any of the other usual stuff. Returns a fence to be used for synchronization. --- drivers/gpu/drm/i915/i915_dma.c| 140 - drivers/gpu/drm/i

[Intel-gfx] [PATCH 5/9] drm/i915: add create_context2 ioctl

2015-09-04 Thread Jesse Barnes
For passing flags (e.g. SVM) when creating a context. Signed-off-by: Jesse Barnes --- drivers/gpu/drm/i915/i915_dma.c | 1 + drivers/gpu/drm/i915/i915_drv.h | 2 ++ drivers/gpu/drm/i915/i915_gem_context.c | 63 +++-- include/uapi/drm/i915_drm.h

[Intel-gfx] [PATCH 1/9] mm: move mmu_find_ops to mmu_notifier.c

2015-09-04 Thread Jesse Barnes
For use by other modules. Signed-off-by: Jesse Barnes --- drivers/misc/sgi-gru/grutlbpurge.c | 19 --- include/linux/mmu_notifier.h | 8 mm/mmu_notifier.c | 19 +++ 3 files changed, 27 insertions(+), 19 deletions(-) diff --git a/d

[Intel-gfx] [PATCH 3/9] android/sync: add sync_fence_create_dma

2015-09-04 Thread Jesse Barnes
From: Maarten Lankhorst This allows users of dma fences to create a android fence. Cc: Daniel Vetter Cc: Jesse Barnes Signed-off-by: Maarten Lankhorst --- drivers/staging/android/sync.c | 13 + drivers/staging/android/sync.h | 3 ++- 2 files changed, 11 insertions(+), 5 deletion

[Intel-gfx] [PATCH 6/9] drm/i915: driver based PASID handling

2015-09-04 Thread Jesse Barnes
New file with VT-d SVM and PASID handling functions and page table management. This belongs in the IOMMU code (along with some extra bits for waiting for invalidations and page faults to complete, flushing the device IOTLB, etc.) FIXME: need work queue for re-submitting contexts TE bit handli

[Intel-gfx] [PATCH 8/9] drm/i915: Android sync points for i915 v4 (obsolete)

2015-09-04 Thread Jesse Barnes
Allow for sync point exposure in the i915 driver. This There are a couple of goals here: 1) allow applications and libraries to create fences without an associated buffer 2) re-use a common API so userspace doesn't have to impedance mismatch between different driver implementations

[Intel-gfx] [PATCH 2/9] signal: export force_sig_info

2015-09-04 Thread Jesse Barnes
For signaling tasks from drivers. --- kernel/signal.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/signal.c b/kernel/signal.c index 0f6bbbe..9122aa2 100644 --- a/kernel/signal.c +++ b/kernel/signal.c @@ -1227,6 +1227,7 @@ force_sig_info(int sig, struct siginfo *info, struct task_str

[Intel-gfx] [PATCH 4/9] android/sync: hack: enable fence signaling in Android Native Sync implementation

2015-09-04 Thread Jesse Barnes
--- drivers/staging/android/sync.c | 29 + 1 file changed, 17 insertions(+), 12 deletions(-) diff --git a/drivers/staging/android/sync.c b/drivers/staging/android/sync.c index 7f0e919..858278d 100644 --- a/drivers/staging/android/sync.c +++ b/drivers/staging/android/sy

Re: [Intel-gfx] [RFC] Page table sharing and bufferless execbuf

2015-09-04 Thread Chris Wilson
On Fri, Sep 04, 2015 at 09:58:54AM -0700, Jesse Barnes wrote: > A few things to think about: > - how to signal GPU hangs with the new execbuf (a signal might be more > natural as the execution appears more CPU-like? what state do we > have to worry about restoring for bufferless contexts

Re: [Intel-gfx] [PATCH 9/9] drm/i915: add bufferless execbuf ioctl

2015-09-04 Thread Chris Wilson
On Fri, Sep 04, 2015 at 09:59:03AM -0700, Jesse Barnes wrote: > We just need to pass in an address to execute and some flags, since we > don't have to worry about buffer relocation or any of the other usual > stuff. Returns a fence to be used for synchronization. There is no need for a flush+fenc

Re: [Intel-gfx] [PATCH] scripts/kernel-doc: Improve Markdown results

2015-09-04 Thread Danilo Cesar Lemes de Paula
On 09/02/2015 11:15 AM, Jonathan Corbet wrote: > On Tue, 1 Sep 2015 14:57:33 -0300 > Danilo Cesar Lemes de Paula wrote: > >> Did you find time to check this patch? As you mentioned that you applied >> the Markdown support for the linux-next tree, this patch might be needed >> (maybe "wanted" is a

[Intel-gfx] [PATCH 2/3] tests/drm_read: remove manual crtc<->pipe mapping from drm_read test

2015-09-04 Thread Micah Fedke
the crtc id is now always equivalent to its index in the array of crtcs returned by the kernel --- tests/drm_read.c | 43 +-- 1 file changed, 13 insertions(+), 30 deletions(-) diff --git a/tests/drm_read.c b/tests/drm_read.c index b808bed..ab7e4ef 100644 -

[Intel-gfx] [PATCH 3/3] overlay: remove crtc<->pipe mapping code from kms-overlay

2015-09-04 Thread Micah Fedke
the crtc id is now always equivalent to its index in the array of crtcs returned by the kernel --- overlay/Makefile.am | 4 ++-- overlay/kms/kms-overlay.c | 7 ++- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/overlay/Makefile.am b/overlay/Makefile.am index c648875..c82

[Intel-gfx] [PATCH 1/3] lib: update kmstest_get_pipe_from_crtc_id

2015-09-04 Thread Micah Fedke
This function uses an intel-specific ioctl to fetch a mapping between pipes and crtc ids, but this technique is outdated as the crtc id is now always equivalent to its index in the array of crtcs returned by the kernel. --- lib/igt_kms.c | 33 - 1 file changed, 24

[Intel-gfx] [PATCH 0/3] remove crtc<->pipe mapping code

2015-09-04 Thread Micah Fedke
This patchset removes the code that looks up a pipe number from a crtc ID. The pipe number is equivalent to the index of the crtc in the array of crtcs returned by the kernel for a drmModeGetResources() call. This may not have been the case when these lookups were written, but it is the de facto

Re: [Intel-gfx] [RFC] Page table sharing and bufferless execbuf

2015-09-04 Thread Jesse Barnes
On 09/04/2015 10:23 AM, Chris Wilson wrote: > On Fri, Sep 04, 2015 at 09:58:54AM -0700, Jesse Barnes wrote: >> A few things to think about: >> - how to signal GPU hangs with the new execbuf (a signal might be more >> natural as the execution appears more CPU-like? what state do we >> hav

Re: [Intel-gfx] [PATCH 9/9] drm/i915: add bufferless execbuf ioctl

2015-09-04 Thread Jesse Barnes
On 09/04/2015 10:37 AM, Chris Wilson wrote: > On Fri, Sep 04, 2015 at 09:59:03AM -0700, Jesse Barnes wrote: >> We just need to pass in an address to execute and some flags, since we >> don't have to worry about buffer relocation or any of the other usual >> stuff. Returns a fence to be used for sy

  1   2   >