On Sat, Aug 22, 2015 at 11:30:44AM +0530, Sharma, Shashank wrote:
> Thanks for the review Matt.
>
> Regards
> Shashank
> On 8/22/2015 4:10 AM, Matt Roper wrote:
> >On Thu, Aug 06, 2015 at 10:08:12PM +0530, Shashank Sharma wrote:
> >>From: Kausal Malladi
> >>
> >>This patch adds atomic get propert
On Sat, Aug 22, 2015 at 11:41:45AM +0530, Sharma, Shashank wrote:
> Regards
> Shashank
>
> On 8/22/2015 4:10 AM, Matt Roper wrote:
> >On Thu, Aug 06, 2015 at 10:08:17PM +0530, Shashank Sharma wrote:
> >>From: Kausal Malladi
> >>
> >>I915 driver registers gamma correction as palette correction
> >
On Fri, Aug 14, 2015 at 07:17:05PM -0300, Tiago Vignatti wrote:
> Hi Daniel,
>
> On 08/13/2015 04:04 AM, Daniel Vetter wrote:
> >On Wed, Aug 12, 2015 at 08:29:14PM -0300, Tiago Vignatti wrote:
> >>+ /* Map too big */
> >>+ handle = gem_create(fd, BO_SIZE);
> >>+ fill_bo(handle, BO_SIZE);
> >
On Sun, Aug 23, 2015 at 01:10:42PM +0100, Chris Wilson wrote:
> On Wed, Aug 12, 2015 at 08:29:17PM -0300, Tiago Vignatti wrote:
> > This patch moves userptr definitions and helpers implementation that were
> > locally in gem_userptr_benchmark and gem_userptr_blits to the library, so
> > other
> >
Hello, I see that I consistently get the warning below on v4.2-rc8. I
believe you already fixed this a long time ago by commit c0165304e10f
("drm/i915: Only enable cursor if it can be enabled."), which I assume is
a stable candidate for v4.2.y.
But wouldn't it look better if you managed to squeez
On Sun, Aug 16, 2015 at 08:52:54AM +0100, Chris Wilson wrote:
> On Sun, Aug 16, 2015 at 04:02:28AM +0100, Michel Thierry wrote:
> > The adj_start calculation for DRM_MM_CREATE_TOP should happen after
> > mm->color_adjust. There was an inconsistency between
> > drm_mm_insert_helper_range
> > and drm
It's not allowed to have legacy suspend/resume hooked up when
DRIVER_MODESET is set. Doing so results in a warning introduced by the
commit below.
commit e8b4855b5dd3e285d0ec18ed15468025abc1be9a
Author: Gustavo Padovan
Date: Thu Aug 13 17:06:39 2015 -0300
drm: WARN_ON if a modeset driver u
On Fri, Aug 21, 2015 at 04:46:14PM -0300, Danilo Cesar Lemes de Paula wrote:
> "/**" should be used for kernel-doc documentation only.
> It causes a warning with the new "in struct body" format.
>
> Signed-off-by: Danilo Cesar Lemes de Paula
> Cc: Randy Dunlap
> Cc: Daniel Vetter
> Cc: Laurent
On Mon, Aug 24, 2015 at 02:41:21PM +0100, Graham Whaley wrote:
> In commit
> d1675198e: drm/i915: Integrate GuC-based command submission
>
> the drm.tmpl include lines reference the intel_guc_submission.c but the
> patch adds the file i915_guc_submission.c. drm.tmpl fails to build with:
> docpro
Building pdfdocs shows errors with !includes and s such as:
jade:/Documentation/DocBook/drm.xml:666:11:E: document type does not
allow element "para" here; missing one of "glossary", "bibliography",
"index" start-tag
Fix by adding items and add/shuffle , and !include
items.
Signed-off-by: Gra
Fix pdfdocs errors such as:
jade:/Documentation/DocBook/drm.xml:10084:13:E: element "code" undefined
by changing tags to tags.
It looks like tags were introduced in DocBook v4.3, and kernel
DocBook is v4.1.2. I would have used , but that introduces
undesirable breaks into the paragraph flow.
A series of patches to make drm.tmpl build under 'make pdfdocs'.
The biggest change is patch4 which converts a large HTML table into a CALS
one. It should be noted, that table renders less than ideal in the PDF -
something I have not figured out how to fix.
Patch1 required some changes that then
There is a mixture of ", " and extended character quotes through
the document - unify on ".
Note, the extended character quotes caused pdfdoc build errors such as:
jade:/Documentation/DocBook/drm.xml:34432:20:E: non SGML character
number 128
jade:/Documentation/DocBook/drm.xml:34432:21:E: non S
The KMS Properties table is in HTML format, which is not supported
for building pdfdocs, resulting in the following types of errors:
jade:/Documentation/DocBook/drm.xml:34413:15:E: there is no attribute
"border"
jade:/Documentation/DocBook/drm.xml:34413:31:E: there is no attribute
"cellpadding
Fix pdfdocs errors such as:
jade:/Documentation/DocBook/drm.xml:1348:20:E: character data is not
allowed here
by adding tags to listitems and abstracts
Signed-off-by: Graham Whaley
---
Documentation/DocBook/drm.tmpl | 87 +++---
1 file changed, 48 insertion
Hey,
Op 25-08-15 om 09:45 schreef Bjørn Mork:
> Hello, I see that I consistently get the warning below on v4.2-rc8. I
> believe you already fixed this a long time ago by commit c0165304e10f
> ("drm/i915: Only enable cursor if it can be enabled."), which I assume is
> a stable candidate for v4.2.y
Maarten Lankhorst writes:
> Hey,
>
> Op 25-08-15 om 09:45 schreef Bjørn Mork:
>> Hello, I see that I consistently get the warning below on v4.2-rc8. I
>> believe you already fixed this a long time ago by commit c0165304e10f
>> ("drm/i915: Only enable cursor if it can be enabled."), which I assum
On 24/08/2015 12:58, ankitprasad.r.sha...@intel.com wrote:
From: Ankitprasad Sharma
This patch provides support for the User to populate the object
with system pages at its creation time. Since this can be safely
performed without holding the 'struct_mutex', it would help to reduce
the time 'st
On Tue, Aug 25, 2015 at 10:26:41AM +0100, Graham Whaley wrote:
> Building pdfdocs shows errors with !includes and s such as:
> jade:/Documentation/DocBook/drm.xml:666:11:E: document type does not
> allow element "para" here; missing one of "glossary", "bibliography",
> "index" start-tag
> Fix by
From: "Thulasimani,Sivakumar"
These patches together help detect DP displays on short pulse HPD
and pass the respective compliance test case (4.2.2.8)
v2: modifed first patch so we will read sink_count independent of
downstream ports availablility.
Thulasimani,Sivakumar (3):
drm/i915: read s
From: "Thulasimani,Sivakumar"
This patch reads sink_count dpcd always and removes its
read operation based on values in downstream port dpcd. Also
we should read it irrespective of current status of sink.
SINK_COUNT dpcd is not dependent on DOWNSTREAM_PORT_PRESENT dpcd.
SINK_COUNT denotes if a d
From: "Thulasimani,Sivakumar"
Sink count can change between short pulse hpd hence this patch
adds a member variable to intel_dp so we can track any changes
between short pulse interrupts.
Signed-off-by: Sivakumar Thulasimani
---
drivers/gpu/drm/i915/intel_dp.c |5 ++---
drivers/gpu/drm/i9
From: "Thulasimani,Sivakumar"
This patch checks for changes in sink count between short pulse
hpds and forces full detect when there is a change. This will
result in compliance test case 4.2.2.8 passing since it tests
for this behavior.
This will allow both detection of hotplug and unplug of pan
From: Shashank Sharma
This patch adds the intel_connector initialized to intel_hdmi
display, during the init phase, just like the other encoders do.
This attachment is very useful when we need to extract the connector
pointer during the hotplug handler function
Signed-off-by: Shashank Sharma
--
Adding this for SKL onwards.
v2: Adding checks for VLV/CHV as well. Reusing old ibx and g4x functions
to check digital port status. Adding a separate function to get bxt live
status (Daniel)
v3: Using intel_encoder->hpd_pin to check the live status (Siva)
Moving the live status read to intel_hdmi_
From: Shashank Sharma
This patch adds a separate probe function for HDMI
EDID read over DDC channel. This function has been
registered as a .hot_plug handler for HDMI encoder.
The current implementation of hdmi_detect()
function re-sets the cached HDMI edid (in connector->detect_edid) in
every d
This series adds some optimization related to reading of edid only when
required and when live status says so.
The comments in the patches explain more.
v2:
Some refactoring is with this series.
Also, right now this is done for platforms gen7 and above because we
couldn't test with older
Some monitors take time in setting the live status.
So retry for few times if this is a connect HPD
Signed-off-by: Sonika Jindal
---
drivers/gpu/drm/i915/intel_hdmi.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_hdmi.c
b/drivers/gpu/drm/i915/
On Fri, Aug 21, 2015 at 11:41:45AM +0300, Jani Nikula wrote:
> On Tue, 30 Jun 2015, Ander Conselvan De Oliveira wrote:
> > On Mon, 2015-06-29 at 14:31 +0300, Ander Conselvan De Oliveira wrote:
> >> On Fri, 2015-06-26 at 18:28 +0300, Ander Conselvan De Oliveira wrote:
> >> > Hi all,
> >> >
> >> >
On Mon, Aug 17, 2015 at 03:03:10PM +0300, Ville Syrjälä wrote:
> On Mon, Aug 17, 2015 at 10:42:23AM +0200, Maarten Lankhorst wrote:
> > Hey,
> >
> > Op 06-07-15 om 14:09 schreef ville.syrj...@linux.intel.com:
> > > From: Ville Syrjälä
> > >
> > > While working on CHV DPIO powergating I relized DP
On Fri, Aug 21, 2015 at 04:46:14PM -0300, Danilo Cesar Lemes de Paula wrote:
> "/**" should be used for kernel-doc documentation only.
> It causes a warning with the new "in struct body" format.
>
> Signed-off-by: Danilo Cesar Lemes de Paula
> Cc: Randy Dunlap
> Cc: Daniel Vetter
> Cc: Laurent
Using bool and returning true upon error is very uncommon. Also an int
return value is actually what all the callers which did check it seem
to have expected.
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/drm_fb_helper.c | 19 +++
include/drm/drm_fb_helper.h | 6 +++---
2
Faster than recompiling.
Note that restore_fbdev_mode_unlocked is a bit special and the only
one which returns an error code when fbdev isn't there - i915 needs
that one to not fall over with some additional fbcon related restore
code. Everyone else just ignores the return value or only prints a
D
These functions are used by drivers to release fbdev emulation
buffers. We need to make them resilient to NULL pointers to
make the fbdev compile/runtime knobs not cause Oopses on module
unload.
Cc: Archit Taneja
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/drm_crtc.c | 14 --
1
When the usual fbcon legacy options are enabled we have
->register_framebuffer
->fb notifier chain calls into fbcon
->fbcon sets up console on new fbi
->fbi->set_par
->drm_fb_helper_set_par exercises full kms api
And because of locking inversion hilarity all of register_framebu
On Tue, Aug 25, 2015 at 02:57:45PM +0200, Daniel Vetter wrote:
> On Mon, Aug 17, 2015 at 03:03:10PM +0300, Ville Syrjälä wrote:
> > On Mon, Aug 17, 2015 at 10:42:23AM +0200, Maarten Lankhorst wrote:
> > > Hey,
> > >
> > > Op 06-07-15 om 14:09 schreef ville.syrj...@linux.intel.com:
> > > > From: Vi
Without the () the markup and more important hyperlinking wont happen.
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/drm_atomic_helper.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/drm_atomic_helper.c
b/drivers/gpu/drm/drm_atomic_helper.c
On Tue, Aug 25, 2015 at 10:26:44AM +0100, Graham Whaley wrote:
> The KMS Properties table is in HTML format, which is not supported
> for building pdfdocs, resulting in the following types of errors:
>
> jade:/Documentation/DocBook/drm.xml:34413:15:E: there is no attribute
> "border"
> jade:/Do
On Fri, Aug 21, 2015 at 01:41:26PM +0100, Chris Wilson wrote:
> On Sat, Aug 22, 2015 at 02:19:48AM +0530, Namrta Salonie wrote:
> > Since RC6 enabling does not involve PCU communication overhead,
> > it can be enabled immediately during the resume time.
> > This will help save additional power & me
On Tue, Aug 25, 2015 at 10:51:10AM +0200, Patrik Jakobsson wrote:
> It's not allowed to have legacy suspend/resume hooked up when
> DRIVER_MODESET is set. Doing so results in a warning introduced by the
> commit below.
>
> commit e8b4855b5dd3e285d0ec18ed15468025abc1be9a
> Author: Gustavo Padovan
On Tue, 2015-08-25 at 13:34 +0200, Daniel Vetter wrote:
> On Tue, Aug 25, 2015 at 10:26:41AM +0100, Graham Whaley wrote:
> > Building pdfdocs shows errors with !includes and s such as:
> > jade:/Documentation/DocBook/drm.xml:666:11:E: document type does
> > not
> > allow element "para" here; miss
Hi Daniel,
Thank you for the patch.
On Tuesday 25 August 2015 16:26:03 Daniel Vetter wrote:
> Without the () the markup and more important hyperlinking wont happen.
>
> Signed-off-by: Daniel Vetter
> ---
> drivers/gpu/drm/drm_atomic_helper.c | 12 ++--
> 1 file changed, 6 insertions(+)
On Tue, Aug 25, 2015 at 06:00:26PM +0300, Laurent Pinchart wrote:
> Hi Daniel,
>
> Thank you for the patch.
>
> On Tuesday 25 August 2015 16:26:03 Daniel Vetter wrote:
> > Without the () the markup and more important hyperlinking wont happen.
> >
> > Signed-off-by: Daniel Vetter
> > ---
> > dr
Using bool and returning true upon error is very uncommon. Also an int
return value is actually what all the callers which did check it seem
to have expected.
v2: Restore hunk misplaced in a rebase, spotted by Rob.
Cc: Rob Clark
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/drm_fb_helper.c
On Tue, 25 Aug 2015, Daniel Vetter wrote:
> On Fri, Aug 21, 2015 at 11:41:45AM +0300, Jani Nikula wrote:
>> On Tue, 30 Jun 2015, Ander Conselvan De Oliveira
>> wrote:
>> > On Mon, 2015-06-29 at 14:31 +0300, Ander Conselvan De Oliveira wrote:
>> >> On Fri, 2015-06-26 at 18:28 +0300, Ander Conselv
On Tue, 2015-08-25 at 16:29 +0200, Daniel Vetter wrote:
> On Tue, Aug 25, 2015 at 10:26:44AM +0100, Graham Whaley wrote:
> > The KMS Properties table is in HTML format, which is not supported
> > for building pdfdocs, resulting in the following types of errors:
> >
> > jade:/Documentation/DocBook
On Tue, 25 Aug 2015, Daniel Vetter wrote:
> On Tue, Aug 25, 2015 at 10:51:10AM +0200, Patrik Jakobsson wrote:
>> It's not allowed to have legacy suspend/resume hooked up when
>> DRIVER_MODESET is set. Doing so results in a warning introduced by the
>> commit below.
>>
>> commit e8b4855b5dd3e285d0
A long time ago (before 3.14) we relied on a permanent pinning of the
ifbdev to lock the fb in place inside the GGTT. However, the
introduction of stealing the BIOS framebuffer and reusing its address in
the GGTT for the fbdev has muddied waters and we use an inherited fb.
However, the inherited fb
On Tue, 25 Aug 2015, Sonika Jindal wrote:
> Adding this for SKL onwards.
>
> v2: Adding checks for VLV/CHV as well. Reusing old ibx and g4x functions
> to check digital port status. Adding a separate function to get bxt live
> status (Daniel)
> v3: Using intel_encoder->hpd_pin to check the live st
On Tue, Aug 25, 2015 at 6:41 PM, Jani Nikula
wrote:
> On Tue, 25 Aug 2015, Daniel Vetter wrote:
>> On Tue, Aug 25, 2015 at 10:51:10AM +0200, Patrik Jakobsson wrote:
>>> It's not allowed to have legacy suspend/resume hooked up when
>>> DRIVER_MODESET is set. Doing so results in a warning introduce
On Tue, Aug 25, 2015 at 9:45 AM, Daniel Vetter wrote:
> These functions are used by drivers to release fbdev emulation
> buffers. We need to make them resilient to NULL pointers to
> make the fbdev compile/runtime knobs not cause Oopses on module
> unload.
>
> Cc: Archit Taneja
> Signed-off-by: D
On Tue, Aug 25, 2015 at 11:20 AM, Daniel Vetter wrote:
> Using bool and returning true upon error is very uncommon. Also an int
> return value is actually what all the callers which did check it seem
> to have expected.
>
> v2: Restore hunk misplaced in a rebase, spotted by Rob.
>
> Cc: Rob Clark
On Tue, Aug 25, 2015 at 9:45 AM, Daniel Vetter wrote:
> When the usual fbcon legacy options are enabled we have
> ->register_framebuffer
> ->fb notifier chain calls into fbcon
> ->fbcon sets up console on new fbi
> ->fbi->set_par
> ->drm_fb_helper_set_par exercises full kms api
The following patches helps to solve PC10 entry issue for SKL.
Detailed description about the changes done to solve the issue
is mentioned in commit message of each patch.
v1: http://lists.freedesktop.org/archives/intel-gfx/2015-August/072870.html
v2: Based on review comments from Daniel, changes
While display engine entering into low power state no need to disable
cdclk pll as CSR firmware of dmc will take care. If pll is already
enabled firmware execution sequence will be blocked. This is one
of the criteria for dmc to work properly.
v1: Initial version.
v2: Based on review comment from
Another interesting criteria to work dmc as expected is pw1 to be
enabled by driver and dmc will shut it off in its execution
sequence. If already disabled by driver dmc will get confuse and
behave differently than expected found during pc10 entry issue
for skl.
So berfore we disable power-well 1,
This patch remove the function call to set the firmware
loading status as uninitialized during suspend.
Dmc firmware will restore the firmware in normal suspend. In previous
patch added a check to directly read the hardware status and load
the firmware if got reset during resume from suspend-hiber
Mmio register access after dc6/dc5 entry is not allowed when
DC6 power states are enabled according to bspec (bspec-id 0527),
so enabling dc6 as the last call in suspend flow.
v1: Initial version.
v2: Based on review comment from Daniel,
- created a seperate patch for csr uninitialization set cal
Dmc will restore the csr program except DC9, cold boot,
warm reset, PCI function level reset, and hibernate/suspend.
intel_csr_load_program() function is used to load the firmware
data from kernel memory to csr address space.
All values of csr address space will be zero if it got reset and
the fi
After getting feedback from various people, I've recently pushed a few
changes to igt to add/move a 'basic' set of subtests. The intention is
that this set of tests always pass, and will be used by the PRTS system
on a per-patch basis as a merge criteria. The total runtime for all the
basic tests
On 24 Aug 2015 14:42, Patrik Jakobsson wrote:
> +PKG_CHECK_MODULES([LIBDRM], [libdrm],
> + [CPPFLAGS="$CPPFLAGS $LIBDRM_CFLAGS"
> +AC_CHECK_HEADERS([drm.h i915_drm.h])],
> + [AC_CHECK_HEADERS([drm/drm.h drm/i915_drm.h])])
i would make the drm/xxx headers
On 24 Aug 2015 14:42, Patrik Jakobsson wrote:
> We need to be able to store private data in the tcb across it's
> lifetime. To ensure proper destruction of the data a free_priv_data
> callback must be provided if an allocation is stored in priv_data. The
> callback is executed automatically when th
The unclaimed register bit is only triggered when someone touches the
specified register range.
For the normal use case (with i915.mmio_debug=0), this commit will
avoid the extra __raw_i915_read32() call for every register outside
the specified range, at the expense of a few additional "if"
statem
Dear git bisect user,
Even though this is the patch that introduced the WARN() you're
bisecting, please notice that it's very likely that the problem you're
facing was already present before this commit. In other words: this
commit adds code to detect errors and give WARN()s about them, but the
er
From: Daniel Vetter
The userspace might need some sort of cache coherency management e.g. when CPU
and GPU domains are being accessed through dma-buf at the same time. To
circumvent this problem there are begin/end coherency markers, that forward
directly to existing dma-buf device drivers vfunc
Does this series comprehend all of the ddr-dvfs/PM-5 watermark reworks that
Ville did towards the end of CHV, or is this series additive to that?
Gavin Hindman
Senior Program Manager
SSG/OTC – Open Source Technology Center
-Original Message-
From: Intel-gfx [mailto:intel-gfx-boun...@lis
Jani - do you believe that this series will need to be reworked following merge
of your cleanup series? We've got some outstanding CHV hot-plug issues that
Sonika's series should fix, so we need to get it in, but should definitely take
the path towards longer-term quality.
Gavin Hindman
Senio
Hmm, so we might need to make it global again, because we would want to check
the live status for hdmi in the hdmi optimization series:
http://lists.freedesktop.org/archives/intel-gfx/2015-August/074306.html
Maybe we can drop this patch alone?
Regards,
Sonika
-Original Message-
From: In
On 08/25/2015 07:15 PM, Daniel Vetter wrote:
Faster than recompiling.
Note that restore_fbdev_mode_unlocked is a bit special and the only
one which returns an error code when fbdev isn't there - i915 needs
that one to not fall over with some additional fbcon related restore
code. Everyone else
So, looks like I can use intel_digital_port_connected for hdmi case.
In that case, we can make this function global and add a case for bxt as well.
Regards,
Sonika
-Original Message-
From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of
Jani Nikula
Sent: Thursday,
Oh, bxt is here..:) Spoke too soon..
But will need to make it based upon intel_encoder->hpd_pin because of the A0/A1
WA for BXT.
Also, we need to make intel_digital_port_connected global to be accessed from
intel_hdmi.c
Regards,
Sonika
-Original Message-
From: Intel-gfx [mailto:intel-gf
On Wed, 26 Aug 2015, "Jindal, Sonika" wrote:
> Oh, bxt is here..:) Spoke too soon..
> But will need to make it based upon intel_encoder->hpd_pin because of the
> A0/A1 WA for BXT.
That should anyway be a separate patch changing the port->port to a port
acquired from pin_to_port. We'll take it ou
The cleanup series has already been reviewed, this one hasn't. The
cleanup series should actually make patch 3/4 simpler to
review. Otherwise there really isn't conflict.
BR,
Jani.
On Wed, 26 Aug 2015, "Hindman, Gavin" wrote:
> Jani - do you believe that this series will need to be reworked fo
On Wed, Aug 19, 2015 at 04:46:13PM +0300, Mika Kuoppala wrote:
> Arun Siluvery writes:
>
> > MI_STORE_REGISTER_MEM, MI_LOAD_REGISTER_MEM instructions are not really
> > variable length instructions unlike MI_LOAD_REGISTER_IMM where it expects
> > (reg, addr) pairs so use fixed length for these in
On Mon, Aug 24, 2015 at 04:38:23PM -0700, Rodrigo Vivi wrote:
> We also need to call the frontbuffer flip to trigger proper
> invalidations when disabling planes. Otherwise we will miss
> screen updates when disabling sprites or cursor.
>
> On core platforms where HW tracking also works, this issu
Hi, Tiago.
On 08/26/2015 02:02 AM, Tiago Vignatti wrote:
> From: Daniel Vetter
>
> The userspace might need some sort of cache coherency management e.g. when CPU
> and GPU domains are being accessed through dma-buf at the same time. To
> circumvent this problem there are begin/end coherency marke
76 matches
Mail list logo
