Re: [Intel-gfx] [PATCH 06/14] drm/i915: Use drm_for_each_fb in i915_debugfs.c

2015-07-10 Thread Ville Syrjälä
On Thu, Jul 09, 2015 at 11:44:29PM +0200, Daniel Vetter wrote: > Just so I have a user for this macro. > > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/i915/i915_debugfs.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_debugfs.c >

[Intel-gfx] [PATCH v2 10/15] drm/i915: Force common lane on for the PPS kick on CHV

2015-07-10 Thread ville . syrjala
From: Ville Syrjälä With DPIO powergating active the DPLL can't be accessed unless something else is keeping the common lane in the channel on. That means the PPS kick procedure could fail to enable the PLL. Power up some data lanes to force the common lane to power up so that the PLL can be ena

Re: [Intel-gfx] [PATCH 01/12] drm/i915: use correct power domain for csr loading

2015-07-10 Thread Animesh Manna
On 7/10/2015 1:34 AM, Daniel Vetter wrote: Grabbing a runtime pm reference with intel_runtime_pm_get will only prevent device D3. But dmc firmware is required even earlier (namely for the skl power well 2). Hence we need to grab a rpm reference higher up in the hierarchy. For simplicity just g

Re: [Intel-gfx] [PATCH 02/12] drm/i915: Only allow rpm on gen9+ with dmc loaded

2015-07-10 Thread Animesh Manna
On 7/10/2015 1:34 AM, Daniel Vetter wrote: Instead of trying to deal with this complexity we'll simply require that the dmc firmware is available for runtime pm support. We do that by not releasing the rpm reference we acquire when starting the firmware loader work. Note that since we hold a rp

Re: [Intel-gfx] drm/i915: Update WaFlushCoherentL3CacheLinesAtContextSwitch

2015-07-10 Thread Dan Carpenter
Hello Arun Siluvery, The patch 9e00084750c0: "drm/i915: Update WaFlushCoherentL3CacheLinesAtContextSwitch" from Jul 3, 2015, leads to the following static checker warning: drivers/gpu/drm/i915/intel_lrc.c:1188 gen8_init_indirectctx_bb() warn: unsigned 'index' is never less than ze

Re: [Intel-gfx] [PATCH 1/2] uxa: fix the call to PixmapSyncDirtyHelper, broken by xserver's 90db5ed

2015-07-10 Thread Chris Wilson
On Thu, Jul 09, 2015 at 07:36:16PM +1000, Dave Airlie wrote: > Please just use > > #ifdef HAS_DIRTYTRACKING_ROTATION > > avoids the pain of versions. Thanks, amended and pushed. -Chris -- Chris Wilson, Intel Open Source Technology Centre ___ Intel-gf

Re: [Intel-gfx] [PATCH v4 17/18] drm/i915: Wa32bitGeneralStateOffset & Wa32bitInstructionBaseOffset

2015-07-10 Thread Chris Wilson
On Thu, Jul 09, 2015 at 05:19:27PM +0100, Michel Thierry wrote: > On 7/7/2015 4:15 PM, Michel Thierry wrote: > >There are some allocations that must be only referenced by 32-bit > >offsets. To limit the chances of having the first 4GB already full, > >objects not requiring this workaround use DRM_M

Re: [Intel-gfx] [PATCH v4 00/18] 48-bit PPGTT

2015-07-10 Thread Chris Wilson
On Tue, Jul 07, 2015 at 04:14:45PM +0100, Michel Thierry wrote: > These are the rebased patches, after Mika's final ppgtt clean-up series landed > (it relies in the macros added) and Akash review comments. > > In order expand the GPU address space, a 4th level translation is added, the > Page Map

Re: [Intel-gfx] [PATCH v4 00/18] 48-bit PPGTT

2015-07-10 Thread Michel Thierry
On 7/10/2015 10:39 AM, Chris Wilson wrote: On Tue, Jul 07, 2015 at 04:14:45PM +0100, Michel Thierry wrote: These are the rebased patches, after Mika's final ppgtt clean-up series landed (it relies in the macros added) and Akash review comments. In order expand the GPU address space, a 4th level

[Intel-gfx] [PATCH] tests/kms_color:Color IGT

2015-07-10 Thread Dhanya Pillai
From: Dhanya This patch will verify color correction capability of a display driver. Gamma/CSC/De-gamma supported. Signed-off-by: Dhanya --- tests/Makefile.sources | 3 + tests/kms_color.c | 639 + 2 files changed, 642 insertions(+) creat

Re: [Intel-gfx] [PATCH] tests/kms_color:Color IGT

2015-07-10 Thread David Weinehall
On Fri, Jul 10, 2015 at 04:02:53PM +0530, Dhanya Pillai wrote: > From: Dhanya > > This patch will verify color correction capability of a display driver. > Gamma/CSC/De-gamma supported. > > Signed-off-by: Dhanya > --- > tests/Makefile.sources | 3 + > tests/kms_color.c | 639 >

[Intel-gfx] [RFC] drm/i915: Add gen check for fb size

2015-07-10 Thread Vandana Kannan
From gen7, the platform can support fb of size < 3x3. Adding this check for gen along with fb width & height. Note: IVB is gen7 but its not clear if it can support width < 3 and height < 3. This patch has been tested in Android environment. Signed-off-by: Vandana Kannan --- drivers/gpu/drm/i915

[Intel-gfx] [PATCH 0/2] VBT and I_boost fixes

2015-07-10 Thread Antti Koskipaa
These are required for SKL PV. I tested these on SNB and SKL. Antti Koskipaa (2): drm/i915: Allow parsing of variable size child device entries from VBT drm/i915: Per-DDI I_boost override drivers/gpu/drm/i915/i915_drv.h | 3 +++ drivers/gpu/drm/i915/intel_bios.c | 30

[Intel-gfx] [PATCH 2/2] drm/i915: Per-DDI I_boost override

2015-07-10 Thread Antti Koskipaa
An OEM may request increased I_boost beyond the recommended values by specifying an I_boost value to be applied to all swing entries for a port. These override values are specified in VBT. v2: rebase and remove unused iboost_bit variable Issue: VIZ-5676 Signed-off-by: Antti Koskipaa --- drivers

[Intel-gfx] [PATCH 1/2] drm/i915: Allow parsing of variable size child device entries from VBT

2015-07-10 Thread Antti Koskipaa
VBT version 196 increased the size of common_child_dev_config. The parser code assumed that the size of this structure would not change. So now, instead of checking for smaller size, check that the VBT entry is not too large and memcpy only child_dev_size amount of data, leaving any trailing entri

Re: [Intel-gfx] [PATCH 3/9] drm/i915: Simplify CHV pipe A power well code

2015-07-10 Thread Sivakumar Thulasimani
Reviewed-by: Sivakumar Thulasimani On 6/29/2015 5:55 PM, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä The pipe A power well is the "disp2d" well on CHV and pipe B and C wells don't even exist. Thereforce we can remove the checks for pipe A vs. others and just assume it's always p

Re: [Intel-gfx] [PATCH 4/9] drm/i915: Refactor VLV display power well init/deinit

2015-07-10 Thread Sivakumar Thulasimani
Reviewed-by: Sivakumar Thulasimani On 6/29/2015 5:55 PM, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä We do the exact same steps around the disp2d/pipe A power well enable/disable on VLV and CHV. Refactor the shared code into some helpers. Note that this means we now call vlv_po

Re: [Intel-gfx] [PATCH v2] drm/i915: Don't forget to mark crtc as inactive after disable

2015-07-10 Thread Damien Lespiau
Hi Patrik, Please do Cc the patch author and reviewer when finding a regression, they are superb candidates for the review, especially when they are busy rewriting the display code. On Wed, Jul 08, 2015 at 03:31:52PM +0200, Patrik Jakobsson wrote: > Watermark calculations depend on the intel_crtc

Re: [Intel-gfx] [PATCH 5/9] drm/i915: Clear out DPLL state from pipe config in DSI get config

2015-07-10 Thread Sivakumar Thulasimani
Reviewed-by: Sivakumar Thulasimani On 6/29/2015 5:55 PM, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä VLV/CHV don't use the DPLL with DSI, so just clear out the DPLL state from the pipe_config in intel_dsi_get_config(). This avoids spurious state checker warnings. We already did

Re: [Intel-gfx] drm/i915: Update WaFlushCoherentL3CacheLinesAtContextSwitch

2015-07-10 Thread Siluvery, Arun
On 10/07/2015 09:25, Dan Carpenter wrote: Hello Arun Siluvery, The patch 9e00084750c0: "drm/i915: Update WaFlushCoherentL3CacheLinesAtContextSwitch" from Jul 3, 2015, leads to the following static checker warning: drivers/gpu/drm/i915/intel_lrc.c:1188 gen8_init_indirectctx_bb()

Re: [Intel-gfx] [PATCH v2] drm/i915: Don't forget to mark crtc as inactive after disable

2015-07-10 Thread Patrik Jakobsson
On Fri, Jul 10, 2015 at 12:22:51PM +0100, Damien Lespiau wrote: > Hi Patrik, > > Please do Cc the patch author and reviewer when finding a regression, > they are superb candidates for the review, especially when they are busy > rewriting the display code. Hmm, I figured they would be picked up fr

Re: [Intel-gfx] [PATCH 5/9] drm/i915: Clear out DPLL state from pipe config in DSI get config

2015-07-10 Thread Sivakumar Thulasimani
On 7/1/2015 6:12 PM, Daniel Vetter wrote: On Tue, Jun 30, 2015 at 02:50:33PM +0300, Ville Syrjälä wrote: On Tue, Jun 30, 2015 at 12:13:37PM +0200, Daniel Vetter wrote: On Mon, Jun 29, 2015 at 08:08:27PM +0300, Ville Syrjälä wrote: On Mon, Jun 29, 2015 at 07:56:05PM +0300, Ville Syrjälä wrote

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Allow parsing of variable size child device entries from VBT

2015-07-10 Thread David Weinehall
On Fri, Jul 10, 2015 at 02:10:54PM +0300, Antti Koskipaa wrote: > VBT version 196 increased the size of common_child_dev_config. The parser > code assumed that the size of this structure would not change. > > So now, instead of checking for smaller size, check that the VBT entry is > not too large

Re: [Intel-gfx] [PATCH 6/9] drm/i915: Move DPLL ref/cri/VGA mode frobbing to the disp2d well enable

2015-07-10 Thread Sivakumar Thulasimani
Reviewed-by: Sivakumar Thulasimani On 6/29/2015 5:55 PM, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä Bunch of stuff needs the DPLL ref/cri clocks on both VLV and CHV, and having VGA mode enabled causes some problems for CHV. So let's just pull the code to configure those bits i

Re: [Intel-gfx] [PATCH v3 4/5] drm: Add decoding of i915 ioctls

2015-07-10 Thread Patrik Jakobsson
On Wed, Jul 08, 2015 at 03:11:36AM +0300, Dmitry V. Levin wrote: > On Mon, Jul 06, 2015 at 04:40:24PM +0200, Gabriel Laskar wrote: > > On Mon, 6 Jul 2015 12:35:52 +0200, Patrik Jakobsson wrote: > > > On Fri, Jul 03, 2015 at 03:36:09AM +0300, Dmitry V. Levin wrote: > > > > On Wed, Jul 01, 2015 at 02

[Intel-gfx] [PATCH] drm/i915: Update PM interrupts before updating the freq

2015-07-10 Thread Praveen Paneri
From: Deepak S Currently we update the freq before masking the interrupts, which can allow new interrupts to occur before the frequency has changed. These extra interrupts might waste some cpu cycles. This patch corrects this by masking interrupts prior to updating the frequency. Signed-off-by:

Re: [Intel-gfx] [PATCH v3 4/5] drm: Add decoding of i915 ioctls

2015-07-10 Thread Dmitry V. Levin
On Fri, Jul 10, 2015 at 02:36:38PM +0200, Patrik Jakobsson wrote: > On Wed, Jul 08, 2015 at 03:11:36AM +0300, Dmitry V. Levin wrote: > > On Mon, Jul 06, 2015 at 04:40:24PM +0200, Gabriel Laskar wrote: [...] > > > Anyway, SYS_FUNC(ioctl) is a bit complicated, and the handling of the > > > fallbacks

[Intel-gfx] [PATCH i-g-t] lib/igt_gt.c : allow changes to stop_rings mode bits

2015-07-10 Thread tim . gore
From: Tim Gore In function igt_set_stop_rings, the test igt_assert_f(flags == 0 || current == 0, .. will fail if we are trying to force a hang but the STOP_RINGS_ALLOW_BAN or STOP_RINGS_ALLOW_ERROR bit is set. With the introduction of per ring resets in the driver (in android) these bits do no

Re: [Intel-gfx] [v3 0/7] Crystalcove (CRC) PMIC based panel and pwm control

2015-07-10 Thread Shobhit Kumar
On Mon, Jun 29, 2015 at 3:48 AM, Paul Gortmaker wrote: > [Re: [Intel-gfx] [v3 0/7] Crystalcove (CRC) PMIC based panel and pwm control] > On 26/06/2015 (Fri 20:47) Ville Syrjälä wrote: > >> On Fri, Jun 26, 2015 at 06:31:37PM +0200, Daniel Vetter wrote: >> > On Fri, Jun 26, 2015 at 02:32:03PM +0530

Re: [Intel-gfx] [PATCH] drm/i915: Adjust BXT HDMI port clock limits

2015-07-10 Thread Imre Deak
On ma, 2015-07-06 at 14:44 +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Since > commit e62925567c7926e78bc8ca976cde5c28ea265a49 > Author: Vandana Kannan > Date: Wed Jul 1 17:02:57 2015 +0530 > > drm/i915/bxt: BUNs related to port PLL > > BXT DPLL can now gener

Re: [Intel-gfx] [PATCH] drm/i915: Adjust BXT HDMI port clock limits

2015-07-10 Thread Imre Deak
On ke, 2015-07-08 at 15:07 +0530, Kannan, Vandana wrote: > > On 7/6/2015 5:14 PM, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > Since > > commit e62925567c7926e78bc8ca976cde5c28ea265a49 > > Author: Vandana Kannan > > Date: Wed Jul 1 17:02:57 2015 +0530 > > > >

Re: [Intel-gfx] [PATCH] drm/i915: Adjust BXT HDMI port clock limits

2015-07-10 Thread Damien Lespiau
On Fri, Jul 10, 2015 at 04:09:42PM +0300, Imre Deak wrote: > On ma, 2015-07-06 at 14:44 +0300, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > Since > > commit e62925567c7926e78bc8ca976cde5c28ea265a49 > > Author: Vandana Kannan > > Date: Wed Jul 1 17:02:57 2015 +0530 >

Re: [Intel-gfx] [PATCH] drm/i915: Adjust BXT HDMI port clock limits

2015-07-10 Thread Ville Syrjälä
On Fri, Jul 10, 2015 at 02:18:57PM +0100, Damien Lespiau wrote: > On Fri, Jul 10, 2015 at 04:09:42PM +0300, Imre Deak wrote: > > On ma, 2015-07-06 at 14:44 +0300, ville.syrj...@linux.intel.com wrote: > > > From: Ville Syrjälä > > > > > > Since > > > commit e62925567c7926e78bc8ca976cde5c28ea265a4

[Intel-gfx] [PATCH i-g-t] tests/gem_reset_stats.c: fix "ban" tests with scheduler

2015-07-10 Thread tim . gore
From: Tim Gore The tests for context banning fail when the gpu scheduler is enabled. The test causes a hang (using an infinite loop batch) and then queues up some work behind it on both the hanging context and also on a second "good" context. On the "good" context it queues up 2 batch buffers. Af

Re: [Intel-gfx] [PATCH] drm/i915: Adjust BXT HDMI port clock limits

2015-07-10 Thread Damien Lespiau
On Fri, Jul 10, 2015 at 04:21:27PM +0300, Ville Syrjälä wrote: > On Fri, Jul 10, 2015 at 02:18:57PM +0100, Damien Lespiau wrote: > > On Fri, Jul 10, 2015 at 04:09:42PM +0300, Imre Deak wrote: > > > On ma, 2015-07-06 at 14:44 +0300, ville.syrj...@linux.intel.com wrote: > > > > From: Ville Syrjälä >

Re: [Intel-gfx] [PATCH] drm/i915: Update WaFlushCoherentL3CacheLinesAtContextSwitch

2015-07-10 Thread Dave Gordon
On 06/07/15 16:41, Chris Wilson wrote: On Mon, Jul 06, 2015 at 04:33:05PM +0200, Daniel Vetter wrote: On Mon, Jul 06, 2015 at 02:16:54PM +0100, Dave Gordon wrote: On 06/07/15 13:38, Daniel Vetter wrote: On Mon, Jul 06, 2015 at 12:52:51PM +0100, Dave Gordon wrote: On 03/07/15 16:42, Chris Wils

Re: [Intel-gfx] [RFC 00/11] TDR/watchdog timeout support for gen8

2015-07-10 Thread Tomas Elf
On 09/07/2015 19:47, Chris Wilson wrote: On Mon, Jun 08, 2015 at 06:03:18PM +0100, Tomas Elf wrote: This patch series introduces the following features: * Feature 1: TDR (Timeout Detection and Recovery) for gen8 execlist mode. * Feature 2: Watchdog Timeout (a.k.a "media engine reset") for gen8.

Re: [Intel-gfx] [RFC 00/11] TDR/watchdog timeout support for gen8

2015-07-10 Thread Tomas Elf
On 10/07/2015 16:24, Tomas Elf wrote: On 09/07/2015 19:47, Chris Wilson wrote: On Mon, Jun 08, 2015 at 06:03:18PM +0100, Tomas Elf wrote: This patch series introduces the following features: * Feature 1: TDR (Timeout Detection and Recovery) for gen8 execlist mode. * Feature 2: Watchdog Timeout

Re: [Intel-gfx] [PATCH v2 1/4] drm/i915: Enable WA batch buffers for Gen9

2015-07-10 Thread Mika Kuoppala
Arun Siluvery writes: > This patch only enables support for Gen9, the actual WA will be > initialized in subsequent patches. > > The WARN that we use to warn user if WA batch support is not available > for a particular Gen is replaced with DRM_ERROR as warning here doesn't > really add much value

Re: [Intel-gfx] [PATCH v2 1/4] drm/i915: Enable WA batch buffers for Gen9

2015-07-10 Thread Siluvery, Arun
On 10/07/2015 16:52, Mika Kuoppala wrote: Arun Siluvery writes: This patch only enables support for Gen9, the actual WA will be initialized in subsequent patches. The WARN that we use to warn user if WA batch support is not available for a particular Gen is replaced with DRM_ERROR as warning

Re: [Intel-gfx] [PATCH 02/12] drm/i915: Only allow rpm on gen9+ with dmc loaded

2015-07-10 Thread Daniel Vetter
On Fri, Jul 10, 2015 at 01:50:23PM +0530, Animesh Manna wrote: > > > On 7/10/2015 1:34 AM, Daniel Vetter wrote: > >Instead of trying to deal with this complexity we'll simply require > >that the dmc firmware is available for runtime pm support. We do that > >by not releasing the rpm reference we

Re: [Intel-gfx] [PATCH 01/12] drm/i915: use correct power domain for csr loading

2015-07-10 Thread Daniel Vetter
On Fri, Jul 10, 2015 at 01:42:09PM +0530, Animesh Manna wrote: > > > On 7/10/2015 1:34 AM, Daniel Vetter wrote: > >Grabbing a runtime pm reference with intel_runtime_pm_get will only > >prevent device D3. But dmc firmware is required even earlier (namely > >for the skl power well 2). > > > >Hence

[Intel-gfx] [PATCH] drm/i915: Use drm_for_each_fb in i915_debugfs.c

2015-07-10 Thread Daniel Vetter
Just so I have a user for this macro. v2: Use the right macro - somehow I thought gcc should scream at me, but list_for_each isn't really typesafe unfortunately. Spotted by Ville. Cc: Ville Syrjälä Signed-off-by: Daniel Vetter --- drivers/gpu/drm/i915/i915_debugfs.c | 4 +++- 1 file changed, 3

[Intel-gfx] [PATCHv9] drm/i915: Added Programming of the MOCS

2015-07-10 Thread Francisco Jerez
From: Peter Antoine This change adds the programming of the MOCS registers to the gen 9+ platforms. The set of MOCS configuration entries introduced by this patch is intended to be minimal but sufficient to cover the needs of current userspace - i.e. a good set of defaults. It is expected to be e

[Intel-gfx] [QA 2015/07/03 ww27] Testing report for `drm-intel-testing`

2015-07-10 Thread christophe . prigent
Hello, We launched Intel GPU Tools on 6 platforms: Skylake-Y, Braswell-M, Broadwell-U, Baytrail M and T, Haswell-ULT to validate kernel 4.1 tag drm-intel-testing-2015-07-03. Test Environment: Kernel 4.1 from git://anongit.freedesktop.org/drm-intel tag drm-inte

[Intel-gfx] [RFC 0/2] Add Pooled EU support

2015-07-10 Thread Arun Siluvery
These patches enabled Pooled EU support for BXT, they are implemented by Armin Reese. I am sending these patches in its current form for comments. These patches modify Golden batch to have a set of modification values where we can change the commands based on Gen. The commands to enable Pooled EU

[Intel-gfx] [RFC 1/2] drm/i915: Offsets for golden context BB modification

2015-07-10 Thread Arun Siluvery
From: Armin Reese Golden context batch buffers now contain a set of offsets at which contents can optionally be modified. This allows the driver to customize the GC batch for various chipsets in a GEN family. v1 - Originally, the i915 driver was only allowed to insert MI_BATCH_BUFFER_END comman

[Intel-gfx] [RFC 2/2] drm/i915/bxt: Enable pooled EUs for BXT

2015-07-10 Thread Arun Siluvery
From: Armin Reese The pooled EU feature for BXT will be enabled by the GEN9 golden context BB. Pooling EUs allows more execution units to be available for rendering operations and should result in improved performance. The golden context batch buffer is used to enable the feature so it will be

Re: [Intel-gfx] [PATCH] drm/i915: Adjust BXT HDMI port clock limits

2015-07-10 Thread shuang . he
Tested-By: Intel Graphics QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 6726 -Summary- Platform Delta drm-intel-nightly Series Applied ILK

Re: [Intel-gfx] [PATCH 7/7] drm/i915: Kill intel_dp->{link_bw, rate_select}

2015-07-10 Thread shuang . he
Tested-By: Intel Graphics QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 6727 -Summary- Platform Delta drm-intel-nightly Series Applied ILK

Re: [Intel-gfx] [PATCH] drm/i915: storm detection documentation update

2015-07-10 Thread shuang . he
Tested-By: Intel Graphics QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 6743 -Summary- Platform Delta drm-intel-nightly Series Applied ILK

Re: [Intel-gfx] [PATCH v4 18/18] drm/i915/gen8: Flip the 48b switch

2015-07-10 Thread shuang . he
Tested-By: Intel Graphics QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 6746 -Summary- Platform Delta drm-intel-nightly Series Applied ILK