Re: [Intel-gfx] [PATCH] drm/i915: Reset logical ring contexts' head and tail during GPU reset

2015-02-17 Thread Dave Gordon
On 16/02/15 16:12, Thomas Daniel wrote: > Work was getting left behind in LRC contexts during reset. This causes a hang > if the GPU is reset when HEAD==TAIL because the context's ringbuffer head and > tail don't get reset and retiring a request doesn't alter them, so the ring > still appears full

[Intel-gfx] [PATCH i-g-t] tests/gem_render_linear_blits: split into two subtests

2015-02-17 Thread tim . gore
From: Tim Gore The gem_render_linear_blits test tends to get oom killed on low memory (< 4GB) Android systems. This is because the test tries to allocate (sysinfo.totalram * 9 / 10) in buffer objects and the remaining 10% of memory is not always enough for the Android system. After a discussion w

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Re-order some checks to do the unlikely one first

2015-02-17 Thread Damien Lespiau
On Mon, Feb 16, 2015 at 09:03:51PM +, Chris Wilson wrote: > On Mon, Feb 16, 2015 at 06:25:10PM +, Damien Lespiau wrote: > > instpm_mode != relative_constants_mode is quite unlikely to happen, so > > we can test it first to use C's && short-circuiting and not test on > > 'ring'. > > > > I k

Re: [Intel-gfx] [PATCH 5/5] drm/irq: Don't call ->get_vblank_counter directly from irq_uninstall/cleanup

2015-02-17 Thread Imre Deak
On pe, 2015-02-13 at 21:03 +0100, Daniel Vetter wrote: > The pipe might already have been shut down, and then it's not a good > idea to call hw accessor functions. Instead use the same logic as > drm_vblank_off which has all the necessary checks to avoid troubles or > inconsistency. > > Noticed by

Re: [Intel-gfx] [PATCH 2/7] drm/i915/skl: Updated the gen6_set_rps function

2015-02-17 Thread Damien Lespiau
On Fri, Feb 06, 2015 at 08:26:33PM +0530, akash.g...@intel.com wrote: > From: Akash Goel > > On SKL, the frequency programmed in RPNSWREQ (A008) register > has to be in units of 16.66 MHZ. So updated the gen6_set_rps > function, as per this change. > > Signed-off-by: Akash Goel > --- Right, we

Re: [Intel-gfx] [PATCH 1/7] drm/i915/skl: Added new macros

2015-02-17 Thread Damien Lespiau
On Fri, Feb 06, 2015 at 08:26:32PM +0530, akash.g...@intel.com wrote: > +#define FREQ_1_28_US(us) (((us) * 100) >> 7) > +#define FREQ_1_33_US(us) (((us) * 3) >> 2) > +#define GT_FREQ_FROM_PERIOD(us, dev) (IS_GEN9(dev) ? \ > + FREQ_1_33_US(us) : \ > +

Re: [Intel-gfx] [PATCH 4/7] drm/i915/skl: Updated the gen6_rps_limits function

2015-02-17 Thread Damien Lespiau
On Fri, Feb 06, 2015 at 08:26:35PM +0530, akash.g...@intel.com wrote: > From: Akash Goel > > RP Interrupt Up/Down Frequency Limits register (A014) definition > has changed for SKL. Updated the gen6_rps_limits function as per that > > Signed-off-by: Akash Goel Ah, this is the change I was looki

Re: [Intel-gfx] [PATCH 4/7] drm/i915/skl: Updated the gen6_rps_limits function

2015-02-17 Thread Damien Lespiau
On Tue, Feb 17, 2015 at 02:44:56PM +, Damien Lespiau wrote: > On Fri, Feb 06, 2015 at 08:26:35PM +0530, akash.g...@intel.com wrote: > > + if (IS_GEN9(dev_priv->dev)) { > > + limits = (dev_priv->rps.max_freq_softlimit * GEN9_FREQ_SCALER) > > << 23; > > + if (val <= dev_pri

Re: [Intel-gfx] [PATCH 2/7] drm/i915/skl: Updated the gen6_set_rps function

2015-02-17 Thread Damien Lespiau
On Tue, Feb 17, 2015 at 02:31:08PM +, Damien Lespiau wrote: > On Fri, Feb 06, 2015 at 08:26:33PM +0530, akash.g...@intel.com wrote: > > From: Akash Goel > > > > On SKL, the frequency programmed in RPNSWREQ (A008) register > > has to be in units of 16.66 MHZ. So updated the gen6_set_rps > > fu

Re: [Intel-gfx] [PATCH 4/7] drm/i915/skl: Updated the gen6_rps_limits function

2015-02-17 Thread Damien Lespiau
On Tue, Feb 17, 2015 at 03:01:39PM +, Damien Lespiau wrote: > On Tue, Feb 17, 2015 at 02:44:56PM +, Damien Lespiau wrote: > > On Fri, Feb 06, 2015 at 08:26:35PM +0530, akash.g...@intel.com wrote: > > > + if (IS_GEN9(dev_priv->dev)) { > > > + limits = (dev_priv->rps.max_freq_softlimi

Re: [Intel-gfx] [PATCH 1/7] drm/i915/skl: Added new macros

2015-02-17 Thread Goel, Akash
Thanks for the review. Agree it's not an appropriate name. Please kindly suggest one. 'GT_TIME_COUNTER_UNITS_FROM_PERIOD' ?? Best regards Akash -Original Message- From: Lespiau, Damien Sent: Tuesday, February 17, 2015 8:10 PM To: Goel, Akash Cc: intel-gfx@lists.freedesktop.org Subject

Re: [Intel-gfx] [PATCH 1/7] drm/i915/skl: Added new macros

2015-02-17 Thread Damien Lespiau
How about GT_INTERVAL_FROM_US()? GT_EVALUATION_COUNTER_FROM_US()? something along these lines I guess. -- Damien On Tue, Feb 17, 2015 at 03:20:53PM +, Goel, Akash wrote: > Thanks for the review. Agree it's not an appropriate name. > Please kindly suggest one. > 'GT_TIME_COUNTER_UNITS_FROM

Re: [Intel-gfx] [PATCH 1/7] drm/i915/skl: Added new macros

2015-02-17 Thread Goel, Akash
Will prefer GT_INTERVAL_FROM_US, as GT_EVALUATION_COUNTER_FROM_US would be more specific. Best regards Akash -Original Message- From: Lespiau, Damien Sent: Tuesday, February 17, 2015 8:56 PM To: Goel, Akash Cc: intel-gfx@lists.freedesktop.org Subject: Re: [PATCH 1/7] drm/i915/skl: Added

Re: [Intel-gfx] [PATCH 6/7] drm/i915/skl: Updated the 'i915_frequency_info' debugs function

2015-02-17 Thread Damien Lespiau
On Fri, Feb 06, 2015 at 08:26:37PM +0530, akash.g...@intel.com wrote: > From: Akash Goel > > Added support for SKL in the 'i915_frequency_info' debugfs function > > Signed-off-by: Akash Goel > --- > drivers/gpu/drm/i915/i915_debugfs.c | 10 -- > 1 file changed, 8 insertions(+), 2 delet

Re: [Intel-gfx] [PATCH 7/7] drm/i915/skl: Enabling processing of Turbo interrupts

2015-02-17 Thread Damien Lespiau
On Fri, Feb 06, 2015 at 08:26:38PM +0530, akash.g...@intel.com wrote: > From: Akash Goel > > Earlier Turbo interrupts were not being processed for SKL, > as something was amiss in turbo programming for SKL. > Now missing changes have been added, so enabling the Turbo > interrupt processing for SK

Re: [Intel-gfx] [PATCH 5/7] drm/i915/skl: Updated the gen9_enable_rps function

2015-02-17 Thread Damien Lespiau
On Fri, Feb 06, 2015 at 08:26:36PM +0530, akash.g...@intel.com wrote: > From: Akash Goel > > On SKL, GT frequency is programmed in units of 16.66 MHZ units compared > to 50 MHZ for older platforms. Also the time value specified for Up/Down EI & > Up/Down thresholds are expressed in units of 1.33

Re: [Intel-gfx] [PATCH 0/7] Added missing changes for Turbo feature on SKL

2015-02-17 Thread Damien Lespiau
On Fri, Feb 06, 2015 at 08:26:31PM +0530, akash.g...@intel.com wrote: > From: Akash Goel > > This patch series add missing changes, required for proper functioning of the > Turbo feature on SKL. Something I noticed from reading the PM code is that we get the RPe frequency from the punit for HSW/

Re: [Intel-gfx] [PATCH] drm: Fix the CRTC_STEREO_DOUBLE_ONLY define to include stero modes

2015-02-17 Thread Matt Roper
On Mon, Feb 16, 2015 at 03:12:31PM +, Damien Lespiau wrote: > The CRTC_STEREO_DOUBLE_ONLY define was introduced in commit: > > commit ecb7e16bf187bc369cf6a5cd108582c01329980d > Author: Gustavo Padovan > Date: Mon Dec 1 15:40:09 2014 -0800 > > drm: add helper to get crtc timings

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Re-order some checks to do the unlikely one first

2015-02-17 Thread Chris Wilson
On Tue, Feb 17, 2015 at 11:48:25AM +, Damien Lespiau wrote: > On Mon, Feb 16, 2015 at 09:03:51PM +, Chris Wilson wrote: > > On Mon, Feb 16, 2015 at 06:25:10PM +, Damien Lespiau wrote: > > > instpm_mode != relative_constants_mode is quite unlikely to happen, so > > > we can test it first

Re: [Intel-gfx] [PATCH 5/7] drm/i915/skl: Updated the gen9_enable_rps function

2015-02-17 Thread Akash Goel
On Tue, 2015-02-17 at 15:47 +, Damien Lespiau wrote: > On Fri, Feb 06, 2015 at 08:26:36PM +0530, akash.g...@intel.com wrote: > > From: Akash Goel > > > > On SKL, GT frequency is programmed in units of 16.66 MHZ units compared > > to 50 MHZ for older platforms. Also the time value specified fo

Re: [Intel-gfx] [PATCH 6/7] drm/i915/skl: Updated the 'i915_frequency_info' debugs function

2015-02-17 Thread Akash Goel
On Tue, 2015-02-17 at 15:38 +, Damien Lespiau wrote: > On Fri, Feb 06, 2015 at 08:26:37PM +0530, akash.g...@intel.com wrote: > > From: Akash Goel > > > > Added support for SKL in the 'i915_frequency_info' debugfs function > > > > Signed-off-by: Akash Goel > > --- > > drivers/gpu/drm/i915/i