Re: [Intel-gfx] Kernel 3.19rc6 flooding intel_check_page_flip warnings when using compton

2015-02-04 Thread Jani Nikula
On Mon, 02 Feb 2015, Sakari Kapanen wrote: > Dear maintainers, > > On an Asus Zenbook UX32VD laptop with an i5-3317U CPU and Intel HD4000 > graphics, I'm experiencing the following with the latest 3.19rc6 > mainline kernel (built from the Arch Linux AUR package: > https://aur.archlinux.org/pack

Re: [Intel-gfx] [PATCH 2/3] drm/i915/skl: Declare that GT3 has a second VCS

2015-02-04 Thread Daniel Vetter
On Tue, Feb 03, 2015 at 05:55:05PM -0800, Rodrigo Vivi wrote: > On Thu, Jan 29, 2015 at 6:13 AM, Damien Lespiau > wrote: > > Signed-off-by: Damien Lespiau > > --- > > drivers/gpu/drm/i915/i915_drv.c | 19 +-- > > 1 file changed, 17 insertions(+), 2 deletions(-) > > > > diff --git

Re: [Intel-gfx] [PATCH 3/3] drm/i915/skl: Remove the check enforcing VCS2 to be gen8 only

2015-02-04 Thread Daniel Vetter
On Tue, Feb 03, 2015 at 05:55:46PM -0800, Rodrigo Vivi wrote: > Good catch! > > Reviewed-by: Rodrigo Vivi > > On Thu, Jan 29, 2015 at 6:13 AM, Damien Lespiau > wrote: Tiny commit messages! I've added a short blurb explaining that we track this in intel_info already. > > Signed-off-by: Damien

Re: [Intel-gfx] [PATCH v2] tests/gem_userptr_blits: Race between close and invalidate

2015-02-04 Thread Daniel Vetter
On Tue, Feb 03, 2015 at 08:24:12PM +, Chris Wilson wrote: > On Tue, Feb 03, 2015 at 08:13:56PM +0100, Michał Winiarski wrote: > > It was possible for invalidate range start mmu notifier callback to race > > with releasing userptr object. If the object is released prior to > > taking a spinlock

Re: [Intel-gfx] [PATCH 1/4] drm/irq: Add drm_crtc_vblank_reset

2015-02-04 Thread Ville Syrjälä
On Tue, Feb 03, 2015 at 11:30:11AM +0100, Daniel Vetter wrote: > At driver load we need to tell the vblank code about the state of the > pipes, so that the logic around reject vblank_get when the pipe is off > works correctly. > > Thus far i915 used drm_vblank_off, but one of the side-effects of i

Re: [Intel-gfx] [PATCH] drm/i915: Ensure plane->state->fb stays in sync with plane->fb

2015-02-04 Thread Daniel Vetter
On Tue, Feb 03, 2015 at 01:10:04PM -0800, Matt Roper wrote: > plane->state->fb and plane->fb should always reference the same FB so > that atomic and legacy codepaths have the same view of display state. > In commit > > commit db068420560511de80ac59222644f2bdf278c3d5 > Author: Matt

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Use frame buffer modifiers for tiled display

2015-02-04 Thread Tvrtko Ursulin
On 02/03/2015 07:47 PM, Daniel Vetter wrote: On Tue, Feb 03, 2015 at 05:22:31PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Start using frame buffer modifiers instead of object tiling mode for display purposes. To ensure compatibility with old userspace which is using set_tiling and do

[Intel-gfx] [PATCH] drm: Add support to find drm_panel by name

2015-02-04 Thread Shobhit Kumar
For scenarios where OF is not available, we can use panel identification by name. v2: Use const char *name instead of name[NAME_MAX] (Thierry) CC: Thierry Reding Signed-off-by: Shobhit Kumar --- drivers/gpu/drm/drm_panel.c | 18 ++ include/drm/drm_panel.h | 3 +++ 2 files

Re: [Intel-gfx] [PATCH 1/3] drm/i915/skl: Split the SKL PCI ids by GT

2015-02-04 Thread Damien Lespiau
On Tue, Feb 03, 2015 at 05:51:29PM -0800, Rodrigo Vivi wrote: > On Thu, Jan 29, 2015 at 6:13 AM, Damien Lespiau > wrote: > > We need to have a separate GT3 struct intel_device_info to declare they > > have a second VCS. Let's start by splitting the PCI ids per-GT. > > > > Signed-off-by: Damien Les

[Intel-gfx] [PULL] drm-intel-next

2015-02-04 Thread Daniel Vetter
Hi Dave, As discussed on irc one more pull for a bit of atomic goodies. Otherwise just random all over. Plus one fixup on top of the tag because we've accidentally broken thread-safety for the hangcheck. drm-intel-next-2015-01-30: - chv rps improvements from Ville - atomic state handling prep wor

Re: [Intel-gfx] [PATCH 2/2] drm/i915/skl: Also detect eDRAM on SKL

2015-02-04 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 5707 -Summary- Platform Delta drm-intel-nightly Series Applied PNV +1 282/283

Re: [Intel-gfx] [BISECTED REGRESSION in 3.19-rc1] [drm/i915] WARNING: drivers/gpu/drm/drm_irq.c:1077 drm_wait_one_vblank

2015-02-04 Thread Paul Bolle
Andrey Skvortsov schreef op zo 01-02-2015 om 00:16 [+0300]: > this warning exist in v3.19-rc6 and does not in v3.18. Bisection > points to the commit 51e31d49c890552 "drm/i915: Use generic vblank wait". > I have two machines with integrated Intel graphics and the problem > happens only on the old o

Re: [Intel-gfx] [PATCH 1/3] drm/i915/skl: Split the SKL PCI ids by GT

2015-02-04 Thread Damien Lespiau
On Tue, Feb 03, 2015 at 05:51:29PM -0800, Rodrigo Vivi wrote: > On Thu, Jan 29, 2015 at 6:13 AM, Damien Lespiau > wrote: > > We need to have a separate GT3 struct intel_device_info to declare they > > have a second VCS. Let's start by splitting the PCI ids per-GT. > > > > Signed-off-by: Damien Les

[Intel-gfx] [PATCH 2/3 v2] drm/i915/skl: Declare that GT3 has a second VCS

2015-02-04 Thread Damien Lespiau
v2: leave intel_skylake_info alone (Rodrigo, Daniel) Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_drv.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c index 8039cec..6f4f3c5 10

Re: [Intel-gfx] Multiple declarations for intel_fbc_enabled

2015-02-04 Thread Jani Nikula
On Mon, 02 Feb 2015, Ed Maste wrote: > A FreeBSD developer discovered that intel_fbc_enabled has a > declaration in two headers: > > sys/dev/drm2/i915/i915_drv.h:extern bool intel_fbc_enabled(struct > drm_device *dev); > sys/dev/drm2/i915/intel_drv.h:extern bool intel_fbc_enabled(struct > drm_devi

Re: [Intel-gfx] DELL Latitude e5540 Intel 4400 3rd display problem

2015-02-04 Thread Jani Nikula
On Mon, 02 Feb 2015, Gergely Nógrádi wrote: > I can't configure the 2nd or 3rd display on my Dell Latitude e5540 > notebook and Dell NB Port Replicator. > I tried to connect DVI, DP and VGA to Port Replicator and it is > working only in mirror mode. > The only way to use 2 external display if I co

Re: [Intel-gfx] [PATCH 2/2] drm/i915/skl: Implementation of SKL display power well support

2015-02-04 Thread Damien Lespiau
On Tue, Feb 03, 2015 at 01:06:31AM +0200, Imre Deak wrote: > > +static struct i915_power_well skl_power_wells[] = { > > + { > > + .name = "always-on", > > + .always_on = 1, > > + .domains = SKL_DISPLAY_ALWAYS_ON_POWER_DOMAINS, > > + .ops = &i9xx_always_on_p

[Intel-gfx] [PATCH 2/2 v10] drm/i915/skl: Implementation of SKL display power well support

2015-02-04 Thread Damien Lespiau
From: Satheeshakrishna M This patch implements core logic of SKL display power well. v2: Addressed Imre's comments - Added respective DDIs under power well #1 and #2 - Simplified repetitive code in power well programming v3: Implemented Imre's comments - Further simplifi

Re: [Intel-gfx] [PATCH] drm: Add support to find drm_panel by name

2015-02-04 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 5711 -Summary- Platform Delta drm-intel-nightly Series Applied PNV +1 282/283

Re: [Intel-gfx] [PATCH 2/2 v10] drm/i915/skl: Implementation of SKL display power well support

2015-02-04 Thread Daniel Vetter
On Wed, Feb 04, 2015 at 01:57:44PM +, Damien Lespiau wrote: > From: Satheeshakrishna M > > This patch implements core logic of SKL display power well. > > v2: Addressed Imre's comments > - Added respective DDIs under power well #1 and #2 > - Simplified repetitive code in power we

Re: [Intel-gfx] [PATCH 2/2] drm/i915/skl: Implementation of SKL display power well support

2015-02-04 Thread Imre Deak
On ke, 2015-02-04 at 13:53 +, Damien Lespiau wrote: > On Tue, Feb 03, 2015 at 01:06:31AM +0200, Imre Deak wrote: > > > +static struct i915_power_well skl_power_wells[] = { > > > + { > > > + .name = "always-on", > > > + .always_on = 1, > > > + .domains = SKL_DISPLAY_ALWAY

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Use frame buffer modifiers for tiled display

2015-02-04 Thread Daniel Vetter
On Wed, Feb 04, 2015 at 10:01:45AM +, Tvrtko Ursulin wrote: > > On 02/03/2015 07:47 PM, Daniel Vetter wrote: > >On Tue, Feb 03, 2015 at 05:22:31PM +, Tvrtko Ursulin wrote: > >>From: Tvrtko Ursulin > >> > >>Start using frame buffer modifiers instead of object tiling mode > >>for display pu

Re: [Intel-gfx] [PATCH 2/2] drm/i915/skl: Implementation of SKL display power well support

2015-02-04 Thread Damien Lespiau
On Wed, Feb 04, 2015 at 04:20:28PM +0200, Imre Deak wrote: > On ke, 2015-02-04 at 13:53 +, Damien Lespiau wrote: > > On Tue, Feb 03, 2015 at 01:06:31AM +0200, Imre Deak wrote: > > > > +static struct i915_power_well skl_power_wells[] = { > > > > + { > > > > + .name = "always-

Re: [Intel-gfx] [PATCH 2/2] drm/i915/skl: Implementation of SKL display power well support

2015-02-04 Thread Imre Deak
On ke, 2015-02-04 at 16:20 +0200, Imre Deak wrote: > On ke, 2015-02-04 at 13:53 +, Damien Lespiau wrote: > > On Tue, Feb 03, 2015 at 01:06:31AM +0200, Imre Deak wrote: > > > > +static struct i915_power_well skl_power_wells[] = { > > > > + { > > > > + .name = "always-on", > >

Re: [Intel-gfx] [PATCH 2/2] drm/i915/skl: Implementation of SKL display power well support

2015-02-04 Thread Imre Deak
On ke, 2015-02-04 at 14:24 +, Damien Lespiau wrote: > On Wed, Feb 04, 2015 at 04:20:28PM +0200, Imre Deak wrote: > > On ke, 2015-02-04 at 13:53 +, Damien Lespiau wrote: > > > On Tue, Feb 03, 2015 at 01:06:31AM +0200, Imre Deak wrote: > > > > > +static struct i915_power_well skl_power_wells[

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Use frame buffer modifiers for tiled display

2015-02-04 Thread Tvrtko Ursulin
On 02/04/2015 02:25 PM, Daniel Vetter wrote: On Wed, Feb 04, 2015 at 10:01:45AM +, Tvrtko Ursulin wrote: On 02/03/2015 07:47 PM, Daniel Vetter wrote: On Tue, Feb 03, 2015 at 05:22:31PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Start using frame buffer modifiers instead of object

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Use frame buffer modifiers for tiled display

2015-02-04 Thread Daniel Vetter
On Wed, Feb 04, 2015 at 03:09:38PM +, Tvrtko Ursulin wrote: > On 02/04/2015 02:25 PM, Daniel Vetter wrote: > >On Wed, Feb 04, 2015 at 10:01:45AM +, Tvrtko Ursulin wrote: > >> > >>On 02/03/2015 07:47 PM, Daniel Vetter wrote: > >>>On Tue, Feb 03, 2015 at 05:22:31PM +, Tvrtko Ursulin wrote

Re: [Intel-gfx] [PATCH 1/3] drm/i915/skl: Split the SKL PCI ids by GT

2015-02-04 Thread Rodrigo Vivi
On Wed, Feb 4, 2015 at 5:10 AM, Damien Lespiau wrote: > On Tue, Feb 03, 2015 at 05:51:29PM -0800, Rodrigo Vivi wrote: >> On Thu, Jan 29, 2015 at 6:13 AM, Damien Lespiau >> wrote: >> > We need to have a separate GT3 struct intel_device_info to declare they >> > have a second VCS. Let's start by sp

Re: [Intel-gfx] [PATCH 2/3 v2] drm/i915/skl: Declare that GT3 has a second VCS

2015-02-04 Thread Rodrigo Vivi
just reinforcing.. Reviewed-by: Rodrigo Vivi On Wed, Feb 4, 2015 at 5:22 AM, Damien Lespiau wrote: > v2: leave intel_skylake_info alone (Rodrigo, Daniel) > > Signed-off-by: Damien Lespiau > --- > drivers/gpu/drm/i915/i915_drv.c | 17 - > 1 file changed, 16 insertions(+), 1 del

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Use frame buffer modifiers for tiled display

2015-02-04 Thread Tvrtko Ursulin
On 02/04/2015 03:33 PM, Daniel Vetter wrote: On Wed, Feb 04, 2015 at 03:09:38PM +, Tvrtko Ursulin wrote: On 02/04/2015 02:25 PM, Daniel Vetter wrote: On Wed, Feb 04, 2015 at 10:01:45AM +, Tvrtko Ursulin wrote: On 02/03/2015 07:47 PM, Daniel Vetter wrote: On Tue, Feb 03, 2015 at 05:2

[Intel-gfx] [PATCH] tests/kms_addfb: Add support for fb modifiers

2015-02-04 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Just a few basic tests to make sure fb modifiers can be used and behave sanely when mixed with the old set_tiling API. Signed-off-by: Tvrtko Ursulin --- lib/ioctl_wrappers.c | 45 ++ lib/ioctl_wrappers.h | 36

Re: [Intel-gfx] [BISECTED REGRESSION in 3.19-rc1] [drm/i915] WARNING: drivers/gpu/drm/drm_irq.c:1077 drm_wait_one_vblank

2015-02-04 Thread Andrey Skvortsov
On Wed, Feb 04, 2015 at 01:32:14PM +0100, Paul Bolle wrote: > Andrey Skvortsov schreef op zo 01-02-2015 om 00:16 [+0300]: > > this warning exist in v3.19-rc6 and does not in v3.18. Bisection > > points to the commit 51e31d49c890552 "drm/i915: Use generic vblank wait". > > I have two machines with i

Re: [Intel-gfx] [regression in linux-next] i915: broken graphics on laptop

2015-02-04 Thread Chris Wilson
On Wed, Feb 04, 2015 at 09:26:27PM +0300, Andrey Skvortsov wrote: > On Tue, Feb 03, 2015 at 08:21:52PM +, Chris Wilson wrote: > > On Tue, Feb 03, 2015 at 10:15:47PM +0300, Andrey Skvortsov wrote: > > > Hi, > > > > > > tested next-20150202. System boots, but graphic output is broken (empty > >

Re: [Intel-gfx] Multiple declarations for intel_fbc_enabled

2015-02-04 Thread Ed Maste
On 4 February 2015 at 08:27, Jani Nikula wrote: > On Mon, 02 Feb 2015, Ed Maste wrote: >> A FreeBSD developer discovered that intel_fbc_enabled has a >> declaration in two headers: >> >> ... > > Fixed by > > commit 7ff0ebcc1e30e3216c8c62ee71f59ac830b10364 Thanks. Sorry for the double post - one

Re: [Intel-gfx] [PATCH 1/4] drm/i915/bdw: Implement non-coherent ctx w/a

2015-02-04 Thread Ben Widawsky
On Mon, Feb 02, 2015 at 01:21:19PM +, Damien Lespiau wrote: > On Mon, Feb 02, 2015 at 02:33:48PM +0200, Ville Syrjälä wrote: > > On Thu, Jan 08, 2015 at 07:59:10PM -0800, Ben Widawsky wrote: > > > Implements a required workaround whose implications aren't entirely clear > > > to me > > > from