Re: [Intel-gfx] [PATCH] drm/i915: Remove nested work in gpu error handling

2015-02-02 Thread Chris Wilson
On Wed, Jan 28, 2015 at 05:03:14PM +0200, Mika Kuoppala wrote: > @@ -2616,6 +2612,9 @@ void i915_handle_error(struct drm_device *dev, bool > wedged, > va_list args; > char error_msg[80]; > > + if (WARN_ON(mutex_is_locked(&dev_priv->dev->struct_mutex))) > + return; > +

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Enable asynchronous nuclear flips

2015-02-02 Thread Daniel Vetter
On Sat, Jan 31, 2015 at 12:07:56PM -0800, Matt Roper wrote: > On Sat, Jan 31, 2015 at 10:30:29AM +0100, Daniel Vetter wrote: > > On Fri, Jan 30, 2015 at 04:22:38PM -0800, Matt Roper wrote: > > > The initial i915 nuclear pageflip support rejected asynchronous updates. > > > Allow all work after we s

[Intel-gfx] Kernel 3.19rc6 flooding intel_check_page_flip warnings when using compton

2015-02-02 Thread Sakari Kapanen
Dear maintainers, On an Asus Zenbook UX32VD laptop with an i5-3317U CPU and Intel HD4000 graphics, I'm experiencing the following with the latest 3.19rc6 mainline kernel (built from the Arch Linux AUR package: https://aur.archlinux.org/packages/linux-mainline/ ). The problem is related to the

Re: [Intel-gfx] [PATCH] drm/i915: Remove nested work in gpu error handling

2015-02-02 Thread Daniel Vetter
On Mon, Feb 02, 2015 at 09:17:14AM +, Chris Wilson wrote: > On Wed, Jan 28, 2015 at 05:03:14PM +0200, Mika Kuoppala wrote: > > @@ -2616,6 +2612,9 @@ void i915_handle_error(struct drm_device *dev, bool > > wedged, > > va_list args; > > char error_msg[80]; > > > > + if (WARN_ON(mutex

Re: [Intel-gfx] [RFC 2/6] drm/i915: Add tiled framebuffer modifiers

2015-02-02 Thread Daniel Vetter
On Fri, Jan 30, 2015 at 05:36:54PM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > To be used from the new addfb2 extension. > > Signed-off-by: Tvrtko Ursulin > --- > include/uapi/drm/i915_drm.h | 13 + > 1 file changed, 13 insertions(+) > > diff --git a/include/uapi/drm/i

Re: [Intel-gfx] [RFC 4/6] drm/i915: Use framebuffer tiling mode for display purposes

2015-02-02 Thread Daniel Vetter
On Fri, Jan 30, 2015 at 05:36:56PM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > To prepare for framebuffer modifiers, move tiling definition from the > object into the framebuffer. Move in a way that framebuffer tiling is > now used for display while object tiling remains for fencing.

Re: [Intel-gfx] [RFC 6/6] drm/i915: Announce support for framebuffer modifiers

2015-02-02 Thread Daniel Vetter
On Fri, Jan 30, 2015 at 05:36:58PM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Let the DRM core know we can handle it. > > Signed-off-by: Tvrtko Ursulin > --- > drivers/gpu/drm/i915/intel_display.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/i915/int

Re: [Intel-gfx] [RFC 5/6] drm/i915: Allow fb modifier to set framebuffer tiling

2015-02-02 Thread Daniel Vetter
On Fri, Jan 30, 2015 at 05:36:57PM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Use the fb modifier if it was specified over object tiling mode. > > Signed-off-by: Tvrtko Ursulin > --- > drivers/gpu/drm/i915/intel_display.c | 40 > +--- > 1 file chan

Re: [Intel-gfx] [RFC 2/6] drm/i915: Add tiled framebuffer modifiers

2015-02-02 Thread Daniel Vetter
On Mon, Feb 02, 2015 at 10:41:24AM +0100, Daniel Vetter wrote: > On Fri, Jan 30, 2015 at 05:36:54PM +, Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > > > To be used from the new addfb2 extension. > > > > Signed-off-by: Tvrtko Ursulin > > --- > > include/uapi/drm/i915_drm.h | 13 +++

Re: [Intel-gfx] [PATCH] drm/i915: Remove nested work in gpu error handling

2015-02-02 Thread Chris Wilson
On Mon, Feb 02, 2015 at 10:38:19AM +0100, Daniel Vetter wrote: > On Mon, Feb 02, 2015 at 09:17:14AM +, Chris Wilson wrote: > > On Wed, Jan 28, 2015 at 05:03:14PM +0200, Mika Kuoppala wrote: > > > @@ -2616,6 +2612,9 @@ void i915_handle_error(struct drm_device *dev, bool > > > wedged, > > > va

Re: [Intel-gfx] [RFC 2/6] drm/i915: Add tiled framebuffer modifiers

2015-02-02 Thread Tvrtko Ursulin
On 02/02/2015 09:58 AM, Daniel Vetter wrote: On Mon, Feb 02, 2015 at 10:41:24AM +0100, Daniel Vetter wrote: On Fri, Jan 30, 2015 at 05:36:54PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin To be used from the new addfb2 extension. Signed-off-by: Tvrtko Ursulin --- include/uapi/drm/i9

Re: [Intel-gfx] [RFC 4/6] drm/i915: Use framebuffer tiling mode for display purposes

2015-02-02 Thread Tvrtko Ursulin
On 02/02/2015 09:49 AM, Daniel Vetter wrote: On Fri, Jan 30, 2015 at 05:36:56PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin To prepare for framebuffer modifiers, move tiling definition from the object into the framebuffer. Move in a way that framebuffer tiling is now used for display wh

Re: [Intel-gfx] [RFC 5/6] drm/i915: Allow fb modifier to set framebuffer tiling

2015-02-02 Thread Tvrtko Ursulin
On 02/02/2015 09:54 AM, Daniel Vetter wrote: On Fri, Jan 30, 2015 at 05:36:57PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Use the fb modifier if it was specified over object tiling mode. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/intel_display.c | 40 ++

Re: [Intel-gfx] [PATCH 1/3] drm/i915/skl: Split the SKL PCI ids by GT

2015-02-02 Thread Damien Lespiau
On Fri, Jan 30, 2015 at 09:30:07AM +0200, Jani Nikula wrote: > On a related note, I'm contemplating sending a patch to obliterate the > _INTEL_BDW_M and _INTEL_BDW_D macros from i915_pciids.h because it hides > the IDs from a simple grep. Yes, please! -- Damien __

Re: [Intel-gfx] [PATCH 1/4] drm/i915/bdw: Implement non-coherent ctx w/a

2015-02-02 Thread Ville Syrjälä
On Thu, Jan 08, 2015 at 07:59:10PM -0800, Ben Widawsky wrote: > Implements a required workaround whose implications aren't entirely clear to > me > from the description. In particular I do not know if this effects legacy > contexts, execlists, or both. > > I couldn't find a real workaround name,

Re: [Intel-gfx] [PATCH 1/4] drm/i915/bdw: Implement non-coherent ctx w/a

2015-02-02 Thread Damien Lespiau
On Mon, Feb 02, 2015 at 02:33:48PM +0200, Ville Syrjälä wrote: > On Thu, Jan 08, 2015 at 07:59:10PM -0800, Ben Widawsky wrote: > > Implements a required workaround whose implications aren't entirely clear > > to me > > from the description. In particular I do not know if this effects legacy > > co

Re: [Intel-gfx] [PATCH] drm/i915/bdw: Implement WaForceContextSaveRestoreNonCoherent

2015-02-02 Thread Ville Syrjälä
On Tue, Jan 27, 2015 at 06:13:13PM +, Damien Lespiau wrote: > Signed-off-by: Damien Lespiau OK, so this has the right w/a name whereas Ben's earlier patch didn't. So we should go with this version instead. Reviewed-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/i915_reg.h | 1 + >

[Intel-gfx] [PATCH] memcg, shmem: fix shmem migration to use lrucare. (was: Re: memcontrol.c BUG)

2015-02-02 Thread Michal Hocko
On Thu 29-01-15 18:04:15, Hugh Dickins wrote: > On Wed, 28 Jan 2015, Michal Hocko wrote: > > On Wed 28-01-15 08:48:52, Chris Wilson wrote: > > > On Wed, Jan 28, 2015 at 08:13:06AM +1000, Dave Airlie wrote: > > > > https://bugzilla.redhat.com/show_bug.cgi?id=1165369 > > > > > > > > ov 18 09:23:22 e

[Intel-gfx] Significance of Golden context

2015-02-02 Thread Siluvery, Arun
Hi, Could someone explain the significance of Null context/Golden state? I understand we are initializing 3D state in this batch and we send this at the beginning to start the HW with a known state but what are implications of not doing this? what kind of issues we can expect if we don't do th

Re: [Intel-gfx] [PATCH] drm/i915/skl: Enable eDRAM for gen9 as well

2015-02-02 Thread Damien Lespiau
On Fri, Jan 30, 2015 at 05:23:06PM +0100, Daniel Vetter wrote: > On Thu, Jan 29, 2015 at 12:42:35PM +, Damien Lespiau wrote: > > Suggested-by: Daniel Vetter > > Signed-off-by: Damien Lespiau > > Hm, I've thought the magic bit moved ... or have you found it in configdb > again? The eDRAM pre

Re: [Intel-gfx] [PATCH] drm/i915/documentation: Add intel_uncore.c to drm.tmpl

2015-02-02 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 5677 -Summary- Platform Delta drm-intel-nightly Series Applied PNV 353/353

[Intel-gfx] [PATCH] drm/i915: Track old framebuffer instead of object

2015-02-02 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Daniel Vetter spotted a bug while reviewing some of my refactoring in this are of the code. I'll quote: """ > @@ -9764,6 +9768,7 @@ static int intel_crtc_page_flip(struct drm_crtc *crtc, > work->event = event; > work->crtc = crtc; > work->old_fb_obj = intel

Re: [Intel-gfx] [RFC 2/6] drm/i915: Add tiled framebuffer modifiers

2015-02-02 Thread Daniel Vetter
On Mon, Feb 02, 2015 at 10:23:57AM +, Tvrtko Ursulin wrote: > > On 02/02/2015 09:58 AM, Daniel Vetter wrote: > >On Mon, Feb 02, 2015 at 10:41:24AM +0100, Daniel Vetter wrote: > >>On Fri, Jan 30, 2015 at 05:36:54PM +, Tvrtko Ursulin wrote: > >>>From: Tvrtko Ursulin > >>> > >>>To be used fr

Re: [Intel-gfx] [RFC 2/6] drm/i915: Add tiled framebuffer modifiers

2015-02-02 Thread Daniel Vetter
On Mon, Feb 02, 2015 at 10:23:57AM +, Tvrtko Ursulin wrote: > > On 02/02/2015 09:58 AM, Daniel Vetter wrote: > >On Mon, Feb 02, 2015 at 10:41:24AM +0100, Daniel Vetter wrote: > >>On Fri, Jan 30, 2015 at 05:36:54PM +, Tvrtko Ursulin wrote: > >>>From: Tvrtko Ursulin > >>> > >>>To be used fr

Re: [Intel-gfx] [RFC 2/6] drm/i915: Add tiled framebuffer modifiers

2015-02-02 Thread Rob Clark
On Mon, Feb 2, 2015 at 4:41 AM, Daniel Vetter wrote: > On Fri, Jan 30, 2015 at 05:36:54PM +, Tvrtko Ursulin wrote: >> From: Tvrtko Ursulin >> >> To be used from the new addfb2 extension. >> >> Signed-off-by: Tvrtko Ursulin >> --- >> include/uapi/drm/i915_drm.h | 13 + >> 1 file

Re: [Intel-gfx] [RFC 2/6] drm/i915: Add tiled framebuffer modifiers

2015-02-02 Thread Rob Clark
On Mon, Feb 2, 2015 at 10:58 AM, Daniel Vetter wrote: > On Mon, Feb 02, 2015 at 10:23:57AM +, Tvrtko Ursulin wrote: >> >> On 02/02/2015 09:58 AM, Daniel Vetter wrote: >> >On Mon, Feb 02, 2015 at 10:41:24AM +0100, Daniel Vetter wrote: >> >>On Fri, Jan 30, 2015 at 05:36:54PM +, Tvrtko Ursuli

[Intel-gfx] Multiple declarations for intel_fbc_enabled

2015-02-02 Thread Ed Maste
A FreeBSD developer discovered that intel_fbc_enabled has a declaration in two headers: sys/dev/drm2/i915/i915_drv.h:extern bool intel_fbc_enabled(struct drm_device *dev); sys/dev/drm2/i915/intel_drv.h:extern bool intel_fbc_enabled(struct drm_device *dev); We have a slightly older version of the

Re: [Intel-gfx] [RFC 2/6] drm/i915: Add tiled framebuffer modifiers

2015-02-02 Thread Tvrtko Ursulin
On 02/02/2015 04:32 PM, Rob Clark wrote: On Mon, Feb 2, 2015 at 4:41 AM, Daniel Vetter wrote: On Fri, Jan 30, 2015 at 05:36:54PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin To be used from the new addfb2 extension. Signed-off-by: Tvrtko Ursulin --- include/uapi/drm/i915_drm.h | 13

Re: [Intel-gfx] [RFC 2/6] drm/i915: Add tiled framebuffer modifiers

2015-02-02 Thread Daniel Vetter
On Mon, Feb 02, 2015 at 04:42:32PM +, Tvrtko Ursulin wrote: > > On 02/02/2015 04:32 PM, Rob Clark wrote: > >On Mon, Feb 2, 2015 at 4:41 AM, Daniel Vetter wrote: > >>On Fri, Jan 30, 2015 at 05:36:54PM +, Tvrtko Ursulin wrote: > >>>From: Tvrtko Ursulin > >>> > >>>To be used from the new ad

Re: [Intel-gfx] [RFC 4/6] drm/i915: Use framebuffer tiling mode for display purposes

2015-02-02 Thread Daniel Vetter
On Mon, Feb 02, 2015 at 10:29:19AM +, Tvrtko Ursulin wrote: > > On 02/02/2015 09:49 AM, Daniel Vetter wrote: > >On Fri, Jan 30, 2015 at 05:36:56PM +, Tvrtko Ursulin wrote: > >>From: Tvrtko Ursulin > >> > >>To prepare for framebuffer modifiers, move tiling definition from the > >>object in

[Intel-gfx] [PATCH v2] drm/i915: Introduce intel_set_rps()

2015-02-02 Thread ville . syrjala
From: Ville Syrjälä Replace the valleyview_set_rps() and gen6_set_rps() calls with intel_set_rps() which itself does the IS_VALLEYVIEW() check. The code becomes simpler since the callers don't have to do this check themselves. Most of the change was performe with the following semantic patch: @@

Re: [Intel-gfx] [RFC 5/6] drm/i915: Allow fb modifier to set framebuffer tiling

2015-02-02 Thread Daniel Vetter
On Mon, Feb 02, 2015 at 10:36:30AM +, Tvrtko Ursulin wrote: > > On 02/02/2015 09:54 AM, Daniel Vetter wrote: > >On Fri, Jan 30, 2015 at 05:36:57PM +, Tvrtko Ursulin wrote: > >>From: Tvrtko Ursulin > >> > >>Use the fb modifier if it was specified over object tiling mode. > >> > >>Signed-of

[Intel-gfx] [PATCH] drm/i915: Ignore DRM_MODE_FLAG_DBLCLK flag with DP

2015-02-02 Thread ville . syrjala
From: Ville Syrjälä The DP spec has nothing at all to say about double clocked modes. One might assume they don't exist, and if you think about the concept doesn't make much sense since the link already runs at higher fixed frequency. So let's drop the DRM_MODE_FLAG_DBLCLK checks and simply use t

Re: [Intel-gfx] [PATCH] drm/i915: Ignore DRM_MODE_FLAG_DBLCLK flag with DP

2015-02-02 Thread Daniel Vetter
On Mon, Feb 02, 2015 at 07:16:33PM +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > The DP spec has nothing at all to say about double clocked modes. One > might assume they don't exist, and if you think about the concept > doesn't make much sense since the link already runs

Re: [Intel-gfx] [RFC 5/6] drm/i915: Allow fb modifier to set framebuffer tiling

2015-02-02 Thread Tvrtko Ursulin
On 02/02/2015 05:15 PM, Daniel Vetter wrote: On Mon, Feb 02, 2015 at 10:36:30AM +, Tvrtko Ursulin wrote: On 02/02/2015 09:54 AM, Daniel Vetter wrote: On Fri, Jan 30, 2015 at 05:36:57PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Use the fb modifier if it was specified over object

Re: [Intel-gfx] [PATCH] drm/i915: Ignore DRM_MODE_FLAG_DBLCLK flag with DP

2015-02-02 Thread Ville Syrjälä
On Mon, Feb 02, 2015 at 06:21:31PM +0100, Daniel Vetter wrote: > On Mon, Feb 02, 2015 at 07:16:33PM +0200, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > The DP spec has nothing at all to say about double clocked modes. One > > might assume they don't exist, and if you think

Re: [Intel-gfx] Multiple declarations for intel_fbc_enabled

2015-02-02 Thread Daniel Vetter
On Mon, Feb 02, 2015 at 11:40:13AM -0500, Ed Maste wrote: > A FreeBSD developer discovered that intel_fbc_enabled has a > declaration in two headers: > > sys/dev/drm2/i915/i915_drv.h:extern bool intel_fbc_enabled(struct > drm_device *dev); > sys/dev/drm2/i915/intel_drv.h:extern bool intel_fbc_enab

Re: [Intel-gfx] [RFC 2/6] drm/i915: Add tiled framebuffer modifiers

2015-02-02 Thread Rob Clark
On Mon, Feb 2, 2015 at 11:59 AM, Daniel Vetter wrote: > On Mon, Feb 02, 2015 at 04:42:32PM +, Tvrtko Ursulin wrote: >> >> On 02/02/2015 04:32 PM, Rob Clark wrote: >> >On Mon, Feb 2, 2015 at 4:41 AM, Daniel Vetter wrote: >> >>On Fri, Jan 30, 2015 at 05:36:54PM +, Tvrtko Ursulin wrote: >> >

Re: [Intel-gfx] [RFC 5/6] drm/i915: Allow fb modifier to set framebuffer tiling

2015-02-02 Thread Daniel Vetter
On Mon, Feb 02, 2015 at 05:30:36PM +, Tvrtko Ursulin wrote: > > On 02/02/2015 05:15 PM, Daniel Vetter wrote: > >On Mon, Feb 02, 2015 at 10:36:30AM +, Tvrtko Ursulin wrote: > >> > >>On 02/02/2015 09:54 AM, Daniel Vetter wrote: > >>>On Fri, Jan 30, 2015 at 05:36:57PM +, Tvrtko Ursulin wr

[Intel-gfx] [PATCH i-g-t] kms_cursor_crc: Kernel now checks for integer overflow

2015-02-02 Thread Matt Roper
As of kernel commit commit a679064a7e9e8799177a64a31668a34a1bc6a4f1 Author: Matt Roper Date: Fri Jan 30 16:22:37 2015 -0800 drm/i915: Switch planes from transitional helpers to full atomic helpers the kernel now checks for cursor coordinates that would result in integer ov

Re: [Intel-gfx] [PATCH 2/2] drm/i915/skl: Implementation of SKL display power well support

2015-02-02 Thread Imre Deak
On Fri, 2015-01-16 at 15:57 +, Damien Lespiau wrote: > From: Satheeshakrishna M > > This patch implements core logic of SKL display power well. > > v2: Addressed Imre's comments > - Added respective DDIs under power well #1 and #2 > - Simplified repetitive code in power well prog

Re: [Intel-gfx] [PATCH] RFC: drm: add support for tiled/compressed/etc modifier in addfb2 (v1.5)

2015-02-02 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 5678 -Summary- Platform Delta drm-intel-nightly Series Applied PNV -8 353/353

[Intel-gfx] [PATCH] drm/i915: Fix frontbuffer false positve.

2015-02-02 Thread Rodrigo Vivi
frontbuffer bits must be updated during commit times not on atomica prepare one, otherwise we have a risk of false positive. Cc Daniel Vetter Cc: Sonika Jindal Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/intel_display.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) di

Re: [Intel-gfx] i915: WARN_ON(val > dev_priv->rps.max_freq_softlimit)

2015-02-02 Thread O'Rourke, Tom
On Thu, Jan 29, 2015 at 08:56:06PM -0500, Michael Auchter wrote: > On Thu, Jan 29, 2015 at 06:12:31PM +0100, Daniel Vetter wrote: > > On Wed, Jan 28, 2015 at 10:36:02PM -0800, O'Rourke, Tom wrote: > > > On Wed, Jan 28, 2015 at 01:28:58PM +0200, Ville Syrjälä wrote: > > > > On Wed, Jan 28, 2015 at 0

Re: [Intel-gfx] [PATCH] drm/i915: Track old framebuffer instead of object

2015-02-02 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 5695 -Summary- Platform Delta drm-intel-nightly Series Applied PNV 353/353

Re: [Intel-gfx] [PATCH] drm/i915: Ignore DRM_MODE_FLAG_DBLCLK flag with DP

2015-02-02 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 5698 -Summary- Platform Delta drm-intel-nightly Series Applied PNV -1 353/353

Re: [Intel-gfx] [RFC v3 1/4] drm: Add support to find drm_panel by name

2015-02-02 Thread Shobhit Kumar
On 01/27/2015 03:01 PM, Shobhit Kumar wrote: > For scenarios where OF is not available, we can use panel identification by > name. Any body had a look at this ? Regards Shobhit > > Signed-off-by: Shobhit Kumar > --- > drivers/gpu/drm/drm_panel.c | 18 ++ > include/drm/drm_pane

[Intel-gfx] [PATCH] drm/i915: Correct the variable holding the value for EOT to write

2015-02-02 Thread Shobhit Kumar
This isuue got introduced in - commit 24ee0e64909bf7f1953d87d3e1e29d93eafcad73 Author: Gaurav K Singh Date: Fri Dec 5 14:24:21 2014 +0530 drm/i915: Update the DSI enable path to support dual Signed-off-by: Shobhit Kumar --- drivers/gpu/drm/i915/intel_dsi.c | 2 +- 1 file changed, 1 inse

Re: [Intel-gfx] [PATCH] drm/i915: Fix frontbuffer false positve.

2015-02-02 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 5699 -Summary- Platform Delta drm-intel-nightly Series Applied PNV 353/353