Re: [Intel-gfx] [PATCH] drm/mm: Support 4 GiB and larger ranges

2015-01-27 Thread Thierry Reding
On Tue, Jan 27, 2015 at 07:07:44AM +0100, Thomas Hellstrom wrote: > On 01/26/2015 11:51 PM, Dave Airlie wrote: > > On 23 January 2015 at 18:05, Thierry Reding > > wrote: > >> From: Thierry Reding > >> > >> The current implementation is limited by the number of addresses that > >> fit into an uns

Re: [Intel-gfx] [PATCH] drm/mm: Support 4 GiB and larger ranges

2015-01-27 Thread Thomas Hellstrom
On 01/27/2015 09:15 AM, Thierry Reding wrote: > On Tue, Jan 27, 2015 at 07:07:44AM +0100, Thomas Hellstrom wrote: >> On 01/26/2015 11:51 PM, Dave Airlie wrote: >>> On 23 January 2015 at 18:05, Thierry Reding wrote: From: Thierry Reding The current implementation is limited by the n

Re: [Intel-gfx] [RFC PATCH 05/12] drm/i915/dsi: remove unnecessary dsi device callbacks

2015-01-27 Thread Shobhit Kumar
On 01/23/2015 08:52 PM, Daniel Vetter wrote: On Fri, Jan 23, 2015 at 03:14:41PM +0530, Shobhit Kumar wrote: On 01/22/2015 06:53 PM, Jani Nikula wrote: On Thu, 22 Jan 2015, Shobhit Kumar wrote: There had been a instance where we had to drive different resolution (lower) than the native one. Al

Re: [Intel-gfx] [RFC PATCH 07/12] drm/i915/dsi: switch to drm_panel interface

2015-01-27 Thread Shobhit Kumar
On 01/23/2015 09:01 PM, Daniel Vetter wrote: On Fri, Jan 23, 2015 at 04:27:46PM +0530, Shobhit Kumar wrote: On 01/16/2015 05:57 PM, Jani Nikula wrote: @@ -881,13 +889,23 @@ void intel_dsi_init(struct drm_device *dev) drm_connector_register(connector); - fixed_mode = dsi->dev_ops

Re: [Intel-gfx] [PATCH] drm/mm: Support 4 GiB and larger ranges

2015-01-27 Thread Chris Wilson
On Tue, Jan 27, 2015 at 08:51:12AM +1000, Dave Airlie wrote: > On 23 January 2015 at 18:05, Thierry Reding wrote: > > From: Thierry Reding > > > > The current implementation is limited by the number of addresses that > > fit into an unsigned long. This causes problems on 32-bit Tegra where > > un

Re: [Intel-gfx] [PATCH 10/10] drm/i915: Add i915.nuclear_pageflip command line param to force atomic (v4)

2015-01-27 Thread Daniel Vetter
On Thu, Jan 22, 2015 at 04:53:12PM -0800, Matt Roper wrote: > We don't have full atomic modeset support yet, but the "nuclear > pageflip" subset of functionality (i.e., plane operations only) should > be ready. Allow the user to force atomic on for debug purposes, or for > fixed-purpose embedded d

[Intel-gfx] [RFC v3 2/4] mfd: Add a new cell device for panel controlled by crystal cove pmic

2015-01-27 Thread Shobhit Kumar
On BYT-T configuration, panel enable/disable signals are routed through PMIC. Add a cell device for the same. Signed-off-by: Shobhit Kumar --- drivers/mfd/intel_soc_pmic_crc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/mfd/intel_soc_pmic_crc.c b/drivers/mfd/intel_soc_pmic_crc

[Intel-gfx] [RFC v3 1/4] drm: Add support to find drm_panel by name

2015-01-27 Thread Shobhit Kumar
For scenarios where OF is not available, we can use panel identification by name. Signed-off-by: Shobhit Kumar --- drivers/gpu/drm/drm_panel.c | 18 ++ include/drm/drm_panel.h | 3 +++ 2 files changed, 21 insertions(+) diff --git a/drivers/gpu/drm/drm_panel.c b/drivers/gpu/

[Intel-gfx] [RFC v3 3/4] drm/i915: Add new panel driver based on crystal cove pmic

2015-01-27 Thread Shobhit Kumar
This driver provides support for the "crystal_cove_panel" cell device. On BYT-T pmic has to be used to enable/disable panel. v2: Addressed Jani's comments - Moved inside i915 - Correct licensing - Remove unused stuff - Do not initialize prepare/unprepare as they are not needed as o

[Intel-gfx] [RFC v3 0/4] Crystal Cove PMIC based Panel and Backlight Control

2015-01-27 Thread Shobhit Kumar
Hi All Please find modifed set of patches using regmap interface to accedd the PMIC registers. These patches implement a drm_panel as a platform driver for the mfd_cell device declared in intel_soc_pmic_core.c. DRM is extended to provide a find panel by name in absence of OF. Backlight control

[Intel-gfx] [RFC v3 4/4] drm/i915: Enable DSI panel enable/disable based on PMIC

2015-01-27 Thread Shobhit Kumar
This allows for proper PPS during enable/disable of BYT-T platforms where these signals are routed through PMIC. Needs DRM_PANEL to be selected by default as well v2: Adapt to panel find function name change in drm_panel Signed-off-by: Shobhit Kumar --- drivers/gpu/drm/i915/Kconfig

Re: [Intel-gfx] [PATCH] drivers: gpu: drm: i915: intel_fifo_underrun.c: Fix a typo in comment

2015-01-27 Thread Daniel Vetter
On Tue, Jan 27, 2015 at 09:56:49AM +0200, Jani Nikula wrote: > On Mon, 26 Jan 2015, Kumar Amit Mehta wrote: > > The comment for intel_cpu_fifo_underrun_irq_handler() is not consistent > > with the code and the rest of the comment for this routine. This patch > > fixes this typo in comment. > > > >

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Add gt_act_freq_mhz sysfs file

2015-01-27 Thread Ville Syrjälä
On Mon, Jan 26, 2015 at 08:42:56PM +, Chris Wilson wrote: > On Mon, Jan 26, 2015 at 12:22:07PM -0800, O'Rourke, Tom wrote: > > On Sun, Jan 25, 2015 at 09:34:33AM +, Chris Wilson wrote: > > > On Fri, Jan 23, 2015 at 09:04:24PM +0200, ville.syrj...@linux.intel.com > > > wrote: > > > > From:

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Be consistent on printing seqnos

2015-01-27 Thread Chris Wilson
On Mon, Jan 26, 2015 at 06:03:06PM +0200, Mika Kuoppala wrote: > We have had %x and %u intermixed. Bring everything in line and > use %x > > Signed-off-by: Mika Kuoppala Thanks, these had been annoying me for ages. Reviewed-by: Chris Wilson -Chris -- Chris Wilson, Intel Open Source Technolog

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Remove nested work in gpu error handling

2015-01-27 Thread Chris Wilson
On Mon, Jan 26, 2015 at 06:03:05PM +0200, Mika Kuoppala wrote: > Now when we declare gpu errors only through our own dedicated > hangcheck workqueue there is no need to have a separate workqueue > for handling the resetting and waking up the clients as the deadlock > concerns are no more. > > The

[Intel-gfx] [PULL] topic/atomic-core

2015-01-27 Thread Daniel Vetter
Hi Dave, Mostly just small fixes and polish all over, plus the dpms-on-atomic stuff. Cheers, Daniel The following changes since commit 281d1bbd34b734e4f22b30b6f3b673dda46a7470: Merge remote-tracking branch 'origin/master' into drm-next (2015-01-22 10:44:41 +1000) are available in the git r

[Intel-gfx] [PATCH i-g-t 2/3] lib: print warning and critical messages when listing subtests

2015-01-27 Thread Thomas Wood
These messages are sent to stderr and could indicate an issue when enumerating subtests. Signed-off-by: Thomas Wood --- lib/igt_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/igt_core.c b/lib/igt_core.c index 2692fe4..bc588e2 100644 --- a/lib/igt_core.c +++ b/lib/

[Intel-gfx] [PATCH i-g-t 3/3] lib: validate subtest names

2015-01-27 Thread Thomas Wood
Subtest names should only contain '-', '_' and alphanumeric characters. Signed-off-by: Thomas Wood --- lib/igt_core.c | 12 1 file changed, 12 insertions(+) diff --git a/lib/igt_core.c b/lib/igt_core.c index bc588e2..d74f6f8 100644 --- a/lib/igt_core.c +++ b/lib/igt_core.c @@ -54,6

[Intel-gfx] [PATCH i-g-t 1/3] lib: warning messages should be sent to stderr

2015-01-27 Thread Thomas Wood
This is a regression from commit df11a0f (lib: add a critical warning level). Signed-off-by: Thomas Wood --- lib/igt_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/igt_core.c b/lib/igt_core.c index 7b47b32..2692fe4 100644 --- a/lib/igt_core.c +++ b/lib/igt_core.c

[Intel-gfx] [RFC v3] drm/i915: Android native sync support

2015-01-27 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Add Android native sync support with fences exported as file descriptors via the execbuf ioctl (rsvd2 field is used). This is a continuation of Jesse Barnes's previous work, squashed to arrive at the final destination, cleaned up, with some fixes and preliminary light testin

Re: [Intel-gfx] [RFC v3] drm/i915: Android native sync support

2015-01-27 Thread Chris Wilson
On Tue, Jan 27, 2015 at 11:29:36AM +, Tvrtko Ursulin wrote: > +static void i915_gem_request_unreference_worker(struct work_struct *work) > +{ > + struct drm_i915_gem_request *req = > + container_of(work, struct drm_i915_gem_request, unref_work); > + struct drm_device *dev =

Re: [Intel-gfx] [RFC v3] drm/i915: Android native sync support

2015-01-27 Thread Tvrtko Ursulin
On 01/27/2015 11:40 AM, Chris Wilson wrote: On Tue, Jan 27, 2015 at 11:29:36AM +, Tvrtko Ursulin wrote: +static void i915_gem_request_unreference_worker(struct work_struct *work) +{ + struct drm_i915_gem_request *req = + container_of(work, struct drm_i915_gem_request, unr

Re: [Intel-gfx] [PATCH v4 01/24] drm/i915/trace: Fix offsets for 64b

2015-01-27 Thread Mika Kuoppala
Michel Thierry writes: > From: Ben Widawsky > > Signed-off-by: Ben Widawsky > Signed-off-by: Michel Thierry > --- > drivers/gpu/drm/i915/i915_trace.h | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_trace.h > b/drivers/gpu/drm/i915/i9

Re: [Intel-gfx] [RFC v3] drm/i915: Android native sync support

2015-01-27 Thread Chris Wilson
On Tue, Jan 27, 2015 at 12:13:14PM +, Tvrtko Ursulin wrote: > On 01/27/2015 11:40 AM, Chris Wilson wrote: > >On Tue, Jan 27, 2015 at 11:29:36AM +, Tvrtko Ursulin wrote: > >>+static void i915_gem_request_unreference_worker(struct work_struct *work) > >>+{ > >>+ struct drm_i915_gem_request

Re: [Intel-gfx] [RFC PATCH 05/12] drm/i915/dsi: remove unnecessary dsi device callbacks

2015-01-27 Thread Daniel Vetter
On Tue, Jan 27, 2015 at 02:11:18PM +0530, Shobhit Kumar wrote: > On 01/23/2015 08:52 PM, Daniel Vetter wrote: > >On Fri, Jan 23, 2015 at 03:14:41PM +0530, Shobhit Kumar wrote: > >>On 01/22/2015 06:53 PM, Jani Nikula wrote: > >>>On Thu, 22 Jan 2015, Shobhit Kumar wrote: > There had been a insta

Re: [Intel-gfx] [RFC PATCH 05/12] drm/i915/dsi: remove unnecessary dsi device callbacks

2015-01-27 Thread Chris Wilson
On Tue, Jan 27, 2015 at 02:09:21PM +0100, Daniel Vetter wrote: > On Tue, Jan 27, 2015 at 02:11:18PM +0530, Shobhit Kumar wrote: > > On 01/23/2015 08:52 PM, Daniel Vetter wrote: > > >On Fri, Jan 23, 2015 at 03:14:41PM +0530, Shobhit Kumar wrote: > > >>On 01/22/2015 06:53 PM, Jani Nikula wrote: > > >

Re: [Intel-gfx] [RFC v3] drm/i915: Android native sync support

2015-01-27 Thread Tvrtko Ursulin
On 01/27/2015 12:18 PM, Chris Wilson wrote: On Tue, Jan 27, 2015 at 12:13:14PM +, Tvrtko Ursulin wrote: On 01/27/2015 11:40 AM, Chris Wilson wrote: [snip] Explain how fence_release interacts with enable_signalling. Presumably either the core fence routines cleanup the outstanding signal

[Intel-gfx] [PATCH i-g-t 1/2] lib: add subtest start and exit status code messages to debug output

2015-01-27 Thread Thomas Wood
Signed-off-by: Thomas Wood --- lib/igt_core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/igt_core.c b/lib/igt_core.c index d74f6f8..41f84bb 100644 --- a/lib/igt_core.c +++ b/lib/igt_core.c @@ -729,6 +729,7 @@ bool __igt_run_subtest(const char *subtest_name) } kmsg

[Intel-gfx] [PATCH i-g-t 2/2] lib: add exit status message to simple tests

2015-01-27 Thread Thomas Wood
Add an exit status message to simple tests, similar to the one printed for subtests. This includes the test outcome and the time taken to run the test. Signed-off-by: Thomas Wood --- lib/igt_core.c | 30 +- 1 file changed, 29 insertions(+), 1 deletion(-) diff --git a

[Intel-gfx] [PATCH 1/2] drm/i915: Handle CHV in vlv_set_rps_idle()

2015-01-27 Thread ville . syrjala
From: Ville Syrjälä Move the CHV check into vlv_set_rps_idle() to simplify the caller a bit. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_pm.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel

[Intel-gfx] [PATCH 2/2] drm/i915: Introduce intel_set_rps()

2015-01-27 Thread ville . syrjala
From: Ville Syrjälä Replace the valleyview_set_rps() and gen6_set_rps() calls with intel_set_rps() which itself does the IS_VALLEYVIEW() check. The code becomes simpler since the callers don't have to do this check themselves. Most of the change was performe with the following semantic patch: @@

Re: [Intel-gfx] [PATCH v2] agp/intel: Serialise after GTT updates

2015-01-27 Thread Daniel Vetter
On Mon, Jan 26, 2015 at 10:47:10AM +, Chris Wilson wrote: > An interesting bug occurs on Pineview through which the root cause is > that the writes of the PTE values into the GTT is not serialised with > subsequent memory access through the GTT (when using WC updates of the > PTE values). This

Re: [Intel-gfx] [PATCH 2/5] drm/i915: Fallback to using CPU relocations for large batch buffers

2015-01-27 Thread Daniel Vetter
On Wed, Jan 14, 2015 at 11:20:56AM +, Chris Wilson wrote: > If the batch buffer is too large to fit into the aperture and we need a > GTT mapping for relocations, we currently fail. This only applies to a > subset of machines for a subset of environments, quite undesirable. We > can simply chec

[Intel-gfx] infinite loop on shutdown

2015-01-27 Thread Patrick Welche
On shutdown, my sandy bridge laptop hangs in an infinite loop in: xf86-video-intel/src/sna/sna_threads.c: 69 while (t->func == NULL) 70 pthread_cond_wait(&t->cond, &t->mutex); Any idea on how to stop it waiting and just quit? (Or what to look for

Re: [Intel-gfx] [PATCH 1/1] drm/i915: Add debugfs tunable for forcewake hysteresis

2015-01-27 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 5640 -Summary- Platform Delta drm-intel-nightly Series Applied PNV 353/353

[Intel-gfx] [PATCH] drm/i915/bdw: Implement WaForceContextSaveRestoreNonCoherent

2015-01-27 Thread Damien Lespiau
Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_reg.h | 1 + drivers/gpu/drm/i915/intel_ringbuffer.c | 2 ++ 2 files changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index ae8ea42..47bc4e2 100644 --- a/drivers/gpu/drm/i91

Re: [Intel-gfx] [PATCH] drm/mm: Support 4 GiB and larger ranges

2015-01-27 Thread Russell King - ARM Linux
On Tue, Jan 27, 2015 at 09:31:26AM +0100, Thomas Hellstrom wrote: > On 01/27/2015 09:15 AM, Thierry Reding wrote: > > Are you referring to the 4 GiB - 1 comment? The point I was trying to > > make is not that the granularity of the IOVA space needs to be 1 byte > > but rather that using an unsigned

Re: [Intel-gfx] infinite loop on shutdown

2015-01-27 Thread Chris Wilson
On Tue, Jan 27, 2015 at 04:33:01PM +, Patrick Welche wrote: > On shutdown, my sandy bridge laptop hangs in an infinite loop in: > xf86-video-intel/src/sna/sna_threads.c: > > 69 while (t->func == NULL) > 70 pthread_cond_wait(&t->cond, &t->mutex)

Re: [Intel-gfx] [PATCH 2/5] drm/i915: Fallback to using CPU relocations for large batch buffers

2015-01-27 Thread Chris Wilson
On Tue, Jan 27, 2015 at 04:09:37PM +0100, Daniel Vetter wrote: > On Wed, Jan 14, 2015 at 11:20:56AM +, Chris Wilson wrote: > > static int > > i915_gem_execbuffer_reserve_vma(struct i915_vma *vma, > > struct intel_engine_cs *ring, > > @@ -536,14 +589,21 @@ i915_gem_

Re: [Intel-gfx] [PATCH v2] agp/intel: Serialise after GTT updates

2015-01-27 Thread Chris Wilson
On Tue, Jan 27, 2015 at 03:58:05PM +0100, Daniel Vetter wrote: > On Mon, Jan 26, 2015 at 10:47:10AM +, Chris Wilson wrote: > > An interesting bug occurs on Pineview through which the root cause is > > that the writes of the PTE values into the GTT is not serialised with > > subsequent memory ac

[Intel-gfx] memcontrol.c BUG

2015-01-27 Thread Dave Airlie
https://bugzilla.redhat.com/show_bug.cgi?id=1165369 ov 18 09:23:22 elissa.gathman.org kernel: page:f5e36a40 count:2 mapcount:0 mapping: (null) index:0x0 Nov 18 09:23:22 elissa.gathman.org kernel: page flags: 0x80090029(locked|uptodate|lru|swapcache|swapbacked) Nov 18 09:23:22 elissa.gathman.org k

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Use intel_gpu_freq() and intel_freq_opcode()

2015-01-27 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 5641 -Summary- Platform Delta drm-intel-nightly Series Applied PNV -1 353/353

[Intel-gfx] [PATCH] gem_render_copy: Provide an all pixels check

2015-01-27 Thread Ben Widawsky
Signed-off-by: Ben Widawsky --- tests/gem_render_copy.c | 32 +++- 1 file changed, 31 insertions(+), 1 deletion(-) diff --git a/tests/gem_render_copy.c b/tests/gem_render_copy.c index 006b6f5..6348eee 100644 --- a/tests/gem_render_copy.c +++ b/tests/gem_render_copy.c

[Intel-gfx] [PATCH] drm/mst: fix recursive sleep warning on qlock

2015-01-27 Thread Dave Airlie
From: Dave Airlie With drm-next, we can get a backtrace like below, this is due to the callback checking the txmsg state taking the mutex, which can cause a sleep inside a sleep, Fix this my creating a spinlock protecting the txmsg state and locking it in appropriate places. : [ cut

Re: [Intel-gfx] [RFC PATCH 05/12] drm/i915/dsi: remove unnecessary dsi device callbacks

2015-01-27 Thread Shobhit Kumar
On 01/27/2015 06:43 PM, Chris Wilson wrote: On Tue, Jan 27, 2015 at 02:09:21PM +0100, Daniel Vetter wrote: On Tue, Jan 27, 2015 at 02:11:18PM +0530, Shobhit Kumar wrote: On 01/23/2015 08:52 PM, Daniel Vetter wrote: On Fri, Jan 23, 2015 at 03:14:41PM +0530, Shobhit Kumar wrote: On 01/22/2015 0

[Intel-gfx] [PATCH v2] dma-buf: cleanup dma_buf_export() to make it easily extensible

2015-01-27 Thread Sumit Semwal
At present, dma_buf_export() takes a series of parameters, which makes it difficult to add any new parameters for exporters, if required. Make it simpler by moving all these parameters into a struct, and pass the struct * as parameter to dma_buf_export(). While at it, unite dma_buf_export_named()

Re: [Intel-gfx] [PATCH v2] agp/intel: Serialise after GTT updates

2015-01-27 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 5643 -Summary- Platform Delta drm-intel-nightly Series Applied PNV -1 353/353