Re: [Intel-gfx] [PATCH 1/7] drm: Renaming DP training vswing pre emph defines

On Wed, Aug 27, 2014 at 03:11:08PM +0200, Thierry Reding wrote: > > So we're left with > > > > #define DP_TRAIN_VOLTAGE_SWING_LEVEL_0 (0 << 0) > > > > Vs > > > > #define DP_TRAIN_VOLTAGE_SWING_LEVEL(x) ((x) << 0) > > > > The second variant doesn't really bring much more clarity? Can

Re: [Intel-gfx] [PATCH] drm/i915: Remove bogus __init annotation from DMI callbacks

On Wed, 27 Aug 2014, Mathias Krause wrote: > The __init annotations for the DMI callback functions are wrong as this > code can be called even after the module has been initialized, e.g. like > this: > > # echo 1 > /sys/bus/pci/devices/:00:02.0/remove > # modprobe i915 > # echo 1 > /sys/

[Intel-gfx] [QA 08/28 ww35] Testing report for `drm-intel-testing` (was: Updated -next)

Summary We covered the platform: Broadwell, Baytrail-M, Haswell (mobile, desktop and ULT), Ivybridge, SandyBridge, IronLake. In this circle, 1 new bugs is filed. Bug 83094 - [BDW Bisected]System dmesg contains "ERROR" when machine resumes from s

Re: [Intel-gfx] [PATCH v3] drm/i915/bdw: BDW Software Turbo

On Wed, Aug 27, 2014 at 08:57:56PM +0200, Daniel Vetter wrote: > On Thu, Aug 14, 2014 at 12:37:53PM -0700, Jesse Barnes wrote: > > On Mon, 11 Aug 2014 23:33:57 +0200 > > Daniel Vetter wrote: > > > > > On Mon, Aug 11, 2014 at 11:08:38AM -0700, Daisy Sun wrote: > > > > BDW supports GT C0 residency

Re: [Intel-gfx] [PATCH] drm/i915/bdw: Render state init for Execlists

On Thu, Aug 21, 2014 at 11:40:54AM +0100, Thomas Daniel wrote: > From: Oscar Mateo > > The batchbuffer that sets the render context state is submitted > in a different way, and from different places. > > We needed to make both the render state preparation and free functions > outside accesible,

[Intel-gfx] [PULL] drm-intel-fixes

Hi Dave - Some more fixes for 3.17, mostly stable material. BR, Jani. The following changes since commit 52addcf9d6669fa439387610bc65c92fa0980cef: Linux 3.17-rc2 (2014-08-25 15:36:20 -0700) are available in the git repository at: git://anongit.freedesktop.org/drm-intel tags/drm-intel-fix

Re: [Intel-gfx] i915: Regression: +4W in idle power use on Macbook Pro 15 (late 2013)

On Mon, Aug 25, 2014 at 3:22 AM, Jani Nikula wrote: > > [just moving from lkml to intel-gfx for a better fitting audience] > > On Mon, 25 Aug 2014, Jani Nikula wrote: > > On Fri, 22 Aug 2014, Eric Rannaud wrote: > >> Hi, > >> > >> Between 3.15.4 and 3.15.8, there was an increase in idle power >

Re: [Intel-gfx] i915: Regression: +4W in idle power use on Macbook Pro 15 (late 2013)

On Thu, Aug 28, 2014 at 9:41 AM, Sean V Kelley wrote: > For what it's worth, I have a Mid-2014, Macbook Pro Retina (13inch display), > running Archlinux with 3.16. > > Definitely, enable_fbc is a win for me and I do manually enable it. But I > am still seeing what I believe to be > a regression o

[Intel-gfx] [PATCH 4/9] drm/i915: split intel_update_plane into check() and commit()

From: Gustavo Padovan Due to the upcoming atomic modesetting feature we need to separate some update functions into a check step that can fail and a commit step that should, ideally, never fail. This commit splits intel_update_plane() and its commit part can still fail due to the fb pinning proc

[Intel-gfx] [PATCH 8/9] drm/i915: return error if fb is NULL

From: Gustavo Padovan intel_pipe_check_base() should return an error is the fb received is set to NULL. Signed-off-by: Gustavo Padovan --- drivers/gpu/drm/i915/intel_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gp

[Intel-gfx] [PATCH 9/9] drm/i915: split intel_pipe_set_base() into check() and commit()

From: Gustavo Padovan Take out some parts of code that can fail from it and move them to intel_pipe_check_base(), the only failure point in intel_pipe_set_base() now is the fb pinning procudure. Signed-off-by: Gustavo Padovan --- drivers/gpu/drm/i915/intel_display.c | 39 +

[Intel-gfx] [PATCH 6/9] drm/i915: split intel_crtc_cursor_set_obj() into check() and commit()

From: Gustavo Padovan Create intel_crtc_cursor_create_obj() to check any need setting before we call intel_crtc_cursor_set_obj() to apply the cursor updates. intel_crtc_cursor_check_obj() must always be called before intel_crtc_cursor_set_obj(). Signed-off-by: Gustavo Padovan --- drivers/gpu/d

[Intel-gfx] [PATCH 3/9] drm/i915: fix memleak in intel_set_config_save_state()

From: Gustavo Padovan If the save_encoder_crtcs or save_connector_encoders allocation fail we need to free everything we have already allocated. Signed-off-by: Gustavo Padovan --- drivers/gpu/drm/i915/intel_display.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git

[Intel-gfx] [PATCH 1/9] drm/i915: init sprites with univeral plane init function

From: Derek Foreman Really just for completeness - old init function ends up making the plane exactly the same way due to the way the enums are set up. Signed-off-by: Derek Foreman --- drivers/gpu/drm/i915/intel_sprite.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[Intel-gfx] [PATCH 7/9] drm/i915: split intel_primary_plane_setplane() into check() and commit()

From: Gustavo Padovan As a preparation for atomic updates we need to split the code to check everything we are going to commit first. This patch starts the work to split intel_primary_plane_setplane() into check() and commit() parts. More work is expected on this to get a better split of the two

[Intel-gfx] [PATCH 5/9] drm/i915: split intel_cursor_plane_update() into check() and commit()

From: Gustavo Padovan Due to the upcoming atomic modesetting feature we need to separate some update functions into a check step that can fail and a commit step that should, ideally, never fail. The commit part can still fail, but that should be solved in another upcoming patch. Signed-off-by:

[Intel-gfx] [PATCH 2/9] drm/i915: trivial: remove unneed set to NULL

From: Gustavo Padovan At this point of the code the obj var is already NULL, so we don't need to set it again to NULL. Signed-off-by: Gustavo Padovan --- drivers/gpu/drm/i915/intel_display.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/

Re: [Intel-gfx] i915: Regression: +4W in idle power use on Macbook Pro 15 (late 2013)

Hi, On Tuesday 26 August 2014 16:00:51, Eric Rannaud wrote： > On Tue, Aug 26, 2014 at 1:59 PM, Daniel Vetter wrote: > >> Forcing FBC with i915.enable_fbc=1 brings the idle power consumption > >> back to under 7W, however. > >> This is all on 3.15.4-ARCH-00041-gf4db98240ac2. > > > > Any signific