Re: [Intel-gfx] [PATCH 10/10] drm/i915: Enable semaphores on BDW

2014-07-07 Thread Daniel Vetter
On Mon, Jun 30, 2014 at 05:14:50PM -0700, Ben Widawsky wrote: > On Mon, Jun 30, 2014 at 09:53:44AM -0700, Rodrigo Vivi wrote: > > Signed-off-by: Rodrigo Vivi > > Reviewed-by: Ben Widawsky Pulled in entire series. Yay! -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Trace point callbacks for validation

2014-07-07 Thread Daniel Vetter
On Tue, Jul 01, 2014 at 05:24:23PM +0100, daniele.ceraolospu...@intel.com wrote: > From: Daniele Ceraolo Spurio > > These callbacks can be assigned to specific functions inside an external > validation kernel module. This module can then extract run-time > information to make sure everything is w

Re: [Intel-gfx] pin OABUFFER to GGTT

2014-07-07 Thread Daniel Vetter
On Tue, Jul 01, 2014 at 08:54:27PM +0100, Chris Wilson wrote: > On Tue, Jul 01, 2014 at 05:16:30PM +, Mateo Lozano, Oscar wrote: > > > The issue is they need: > > > > > > A) A buffer object. > > > B) Bound to GGTT. > > > C) That userspace knows the GGTT offset of, so that they can program > >

Re: [Intel-gfx] WAs in init_clock_gating?

2014-07-07 Thread Daniel Vetter
On Tue, Jul 01, 2014 at 04:51:07PM +, Mateo Lozano, Oscar wrote: > Is there any reason why the WAs are applied in *_init_clock_gating? We > are finding that some of them are lost during reset, and also the > default context ends up with wrong values because the render context is > restored & sa

Re: [Intel-gfx] how to build intel-gpu-tools without cairo

2014-07-07 Thread Daniel Vetter
On Thu, Jul 03, 2014 at 09:47:13PM +, Liu, Ying2 wrote: > Damien, > > We run intel-gpu-tool in VMware esx console. We didn't port display part of > intel gpu driver to esx, so we don't need any display tests at all. > If you could provide us a solution to run intel gpu tools without cairo, th

Re: [Intel-gfx] [PATCH] drm/i915: Revert "drm/i915: Reject the pin ioctl on gen6+"

2014-07-07 Thread Daniel Vetter
On Thu, Jul 03, 2014 at 08:12:35AM +0100, Damien Lespiau wrote: > This reverts commit 02f6bcccf7c324115747aae2f0addd6af5d321cd. > > The OA buffer can contain global data (in particular, not linked to a > context or a single batch execution) about GPU events (eg. hw context > switches, rc6 transiti

Re: [Intel-gfx] [PATCH i-g-t 1/2] pipe_crc: Warn if the CRC values is 0xffffffff

2014-07-07 Thread Daniel Vetter
On Mon, Jul 07, 2014 at 06:03:29PM +0100, Damien Lespiau wrote: > This is what we read when the CRC logic in in a powered down well. We > really don't want that to happen. > > In theory, it's possible 0x to be a valid CRC value, so I don't > assert here. I think we also should go through

Re: [Intel-gfx] [PATCH i-g-t 1/2] kms_plane: Add panning test for primary plane

2014-07-07 Thread Daniel Vetter
On Mon, Jul 07, 2014 at 06:04:45PM +0100, Damien Lespiau wrote: > From: Yi Sun > > Get CRCs of a full red and a full blue surface as reference. > > Create a big framebuffer that is twice width and twice height as the > current display mode. The interesting stuff happens for framebuffers with of

Re: [Intel-gfx] WAs in init_clock_gating?

2014-07-07 Thread Jesse Barnes
On Mon, 7 Jul 2014 22:50:08 +0200 Daniel Vetter wrote: > On Tue, Jul 01, 2014 at 04:51:07PM +, Mateo Lozano, Oscar wrote: > > Is there any reason why the WAs are applied in *_init_clock_gating? We > > are finding that some of them are lost during reset, and also the > > default context ends u

Re: [Intel-gfx] [PATCH] drm/i915: Revert "drm/i915: Reject the pin ioctl on gen6+"

2014-07-07 Thread Jesse Barnes
On Mon, 7 Jul 2014 23:04:55 +0200 Daniel Vetter wrote: > On Thu, Jul 03, 2014 at 08:12:35AM +0100, Damien Lespiau wrote: > > This reverts commit 02f6bcccf7c324115747aae2f0addd6af5d321cd. > > > > The OA buffer can contain global data (in particular, not linked to a > > context or a single batch e

Re: [Intel-gfx] [PATCH 05/10] drm/i915: Implement MI decode for gen8

2014-07-07 Thread Daniel Vetter
On Mon, Jun 30, 2014 at 09:53:39AM -0700, Rodrigo Vivi wrote: > Ipehr just carries Dword 0 and on Gen 8, offsets are located > on Dword 2 and 3 of MI_SEMAPHORE_WAIT. > > This implementation was based on Ben's work and on Ville's suggestion for Ben > > Cc: Ville Syrjälä > Cc: Ben Widawsky > Sign

Re: [Intel-gfx] [PATCH i-g-t] kms_universal_plane: Don't assert outside of fixtures/subtests

2014-07-07 Thread Daniel Vetter
On Fri, Jul 04, 2014 at 12:01:24PM +0100, Damien Lespiau wrote: > Doing otherwise breaks listing the subtests. The test was throwing an > error out when universal planes were disabled as well because of that. > > Cc: Matt Roper > Signed-off-by: Damien Lespiau > --- > tests/kms_universal_plane.c

Re: [Intel-gfx] [PATCH 1/5] drm/i915: don't write powered down IRQ registers on Gen 8

2014-07-07 Thread Daniel Vetter
On Fri, Jul 04, 2014 at 11:50:29AM -0300, Paulo Zanoni wrote: > From: Paulo Zanoni > > If we enable unclaimed register reporting on Gen 8, we will discover > that the IRQ registers for pipes B and C are also on the power well, > so writes to them when the power well is disabled result in unclaime

Re: [Intel-gfx] how to build intel-gpu-tools without cairo

2014-07-07 Thread Liu, Ying2
I will try to disable the cairo tests on esx. Thanks Ying -Original Message- From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel Vetter Sent: Monday, July 07, 2014 1:53 PM To: Liu, Ying2 Cc: intel-gfx@lists.freedesktop.org Subject: Re: [Intel-gfx] how to build intel-

Re: [Intel-gfx] WAs in init_clock_gating?

2014-07-07 Thread Daniel Vetter
On Mon, Jul 7, 2014 at 11:16 PM, Jesse Barnes wrote: > I don't think it's unreasonable to use a macro that checks a global > list for whether to apply a given WA. They'll be scattered all over, > but at least it'll be easy to see: > 1) whether we implement a given workaround > and > 2) which

[Intel-gfx] [PATCH] drm/i915: Implement MI decode for gen8

2014-07-07 Thread Rodrigo Vivi
Ipehr just carries Dword 0 and on Gen 8, offsets are located on Dword 2 and 3 of MI_SEMAPHORE_WAIT. This implementation was based on Ben's work and on Ville's suggestion for Ben v2: fix typo. Removing spurious 0% from debug msg "0x%0%0". (Daniel) Cc: Daniel Vetter Cc: Ville Syrjälä Cc: Ben Wid

Re: [Intel-gfx] linux-next: Tree for Jun 19 (drm/i915)

2014-07-07 Thread Rafael J. Wysocki
On Monday, July 07, 2014 10:06:59 PM Daniel Vetter wrote: > On Mon, Jul 07, 2014 at 10:01:27PM +0200, Rafael J. Wysocki wrote: > > On Monday, July 07, 2014 04:54:23 PM Daniel Vetter wrote: > > > On Wed, Jun 25, 2014 at 01:01:36AM +0200, Rafael J. Wysocki wrote: > > > > On Tuesday, June 24, 2014 02:

Re: [Intel-gfx] [PATCH 4/5] drm/i915: reorganize the unclaimed register detection code

2014-07-07 Thread Daniel Vetter
On Fri, Jul 04, 2014 at 11:50:32AM -0300, Paulo Zanoni wrote: > From: Paulo Zanoni > > The current code only runs when we do an I915_WRITE operation. It > checks if the unclaimed register flag is set before we do the > operation, and then it checks it again after we do the operation. This > doubl

Re: [Intel-gfx] [PATCH 2/3] drm/i915: correct BLC vs PWM enable/disable ordering

2014-07-07 Thread Daniel Vetter
On Thu, Jun 19, 2014 at 11:00:20AM -0700, Jesse Barnes wrote: > Jani, can you review this one? It's still needed for us to conform to > the eDP timing spec. Jani's already goofing off on vacation and I couldn't spot his r-b. Merged anyway, I guess people will scream fast enough if this breaks stu

Re: [Intel-gfx] [PATCH 1/4] drm/i915: don't warn if IRQs are disabled when shutting down display IRQs

2014-07-07 Thread Paulo Zanoni
(documenting what we discussed on IRC) 2014-06-20 13:29 GMT-03:00 Jesse Barnes : > This was always the case on our suspend path, but it was recently > exposed by the change to use our runtime IRQ disable routine rather than > the full DRM IRQ disable. Keep the warning on the enable side, as that

Re: [Intel-gfx] [PATCH 1/4] drm/i915: don't warn if IRQs are disabled when shutting down display IRQs

2014-07-07 Thread Jesse Barnes
On Mon, 7 Jul 2014 18:48:47 -0300 Paulo Zanoni wrote: > (documenting what we discussed on IRC) > > 2014-06-20 13:29 GMT-03:00 Jesse Barnes : > > This was always the case on our suspend path, but it was recently > > exposed by the change to use our runtime IRQ disable routine rather than > > the

Re: [Intel-gfx] Linux 3.16-rc2

2014-07-07 Thread Jiri Kosina
On Mon, 7 Jul 2014, Chris Wilson wrote: > > > this patch on top of v3.16-rc3-62-gd92a333 makes the resume from ram > > > regression go away on my machine: > > > > Hm, we could conditionalize this hack on IS_G4X ... Chris, thoughts? > > As different machines favour different w/a, I think the issu

Re: [Intel-gfx] [PATCH i-g-t] kms_universal_plane: Don't assert outside of fixtures/subtests

2014-07-07 Thread Damien Lespiau
On Mon, Jul 07, 2014 at 11:18:49PM +0200, Daniel Vetter wrote: > On Fri, Jul 04, 2014 at 12:01:24PM +0100, Damien Lespiau wrote: > > Doing otherwise breaks listing the subtests. The test was throwing an > > error out when universal planes were disabled as well because of that. > > > > Cc: Matt Rop

Re: [Intel-gfx] [PATCH] drm/i915: make system freeze support depend on CONFIG_ACPI_SLEEP

2014-07-07 Thread Rafael J. Wysocki
On 6/24/2014 5:12 PM, Imre Deak wrote: On Tue, 2014-06-24 at 17:53 +0300, Jani Nikula wrote: On Tue, 24 Jun 2014, Imre Deak wrote: On Tue, 2014-06-24 at 16:54 +0300, Jani Nikula wrote: On Mon, 23 Jun 2014, Imre Deak wrote: To achieve further power savings during system freeze (aka connected

Re: [Intel-gfx] [PATCH] drm/i915: make system freeze support depend on CONFIG_ACPI_SLEEP

2014-07-07 Thread Rafael J. Wysocki
On 7/8/2014 1:13 AM, Rafael J. Wysocki wrote: On 6/24/2014 5:12 PM, Imre Deak wrote: On Tue, 2014-06-24 at 17:53 +0300, Jani Nikula wrote: On Tue, 24 Jun 2014, Imre Deak wrote: On Tue, 2014-06-24 at 16:54 +0300, Jani Nikula wrote: On Mon, 23 Jun 2014, Imre Deak wrote: To achieve further po

Re: [Intel-gfx] linux-next: Tree for Jun 19 (drm/i915)

2014-07-07 Thread Rafael J. Wysocki
On Monday, July 07, 2014 11:49:22 PM Rafael J. Wysocki wrote: > On Monday, July 07, 2014 10:06:59 PM Daniel Vetter wrote: > > On Mon, Jul 07, 2014 at 10:01:27PM +0200, Rafael J. Wysocki wrote: > > > On Monday, July 07, 2014 04:54:23 PM Daniel Vetter wrote: > > > > On Wed, Jun 25, 2014 at 01:01:36AM

Re: [Intel-gfx] pin OABUFFER to GGTT

2014-07-07 Thread Bragg, Robert
On Mon, Jul 7, 2014 at 9:43 PM, Daniel Vetter wrote: > On Tue, Jul 01, 2014 at 08:54:27PM +0100, Chris Wilson wrote: > > On Tue, Jul 01, 2014 at 05:16:30PM +, Mateo Lozano, Oscar wrote: > > > > The issue is they need: > > > > > > > > A) A buffer object. > > > > B) Bound to GGTT. > > > > C) Th

[Intel-gfx] [PATCH 1/2] drm/i915: Introduce intel_fb_obj() macro

2014-07-07 Thread Matt Roper
Add an intel_fb_obj() macro that returns the GEM object associated with a DRM framebuffer. This macro is safe to call on NULL framebuffers (a NULL object pointer will be returned in this case). Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/intel_drv.h | 1 + 1 file changed, 1 insertion(+)

[Intel-gfx] [PATCH 2/2] drm/i915: Make use of intel_fb_obj()

2014-07-07 Thread Matt Roper
This should hopefully simplify the display code slightly and also solves at least one mistake in intel_pipe_set_base() where to_intel_framebuffer(fb)->obj is referenced during local variable initialization, before 'if (!fb)' gets checked. Potential uses of this macro were identified via the follow

Re: [Intel-gfx] [PATCH v2] drm/i915/opregion: ignore firmware requests for backlight change

2014-07-07 Thread Aaron Lu
On 07/07/2014 09:01 PM, Rafael J. Wysocki wrote: > On Monday, July 07, 2014 03:43:51 PM Aaron Lu wrote: >> Some Thinkpad laptops' firmware will initiate a backlight level change >> request through operation region on the events of AC plug/unplug, but >> since we are not using firmware's interface t

Re: [Intel-gfx] [PATCH v2] drm/i915/opregion: ignore firmware requests for backlight change

2014-07-07 Thread Aaron Lu
On 07/07/2014 08:51 PM, Rafael J. Wysocki wrote: > On Monday, July 07, 2014 03:43:51 PM Aaron Lu wrote: >> Some Thinkpad laptops' firmware will initiate a backlight level change >> request through operation region on the events of AC plug/unplug, but >> since we are not using firmware's interface t

[Intel-gfx] [PATCH] drm/i915: Introduce FBC False Color for debug purposes.

2014-07-07 Thread Rodrigo Vivi
With this bit enabled, HW changes the color when compressing frames for debug purposes. ALthough the simple way to enable a single bit is over intel_reg_write, this value is overwriten on next update_fbc so depending on the workload it is not possible to set this bit with intel-gpu-tools. So this

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Kick out vga console

2014-07-07 Thread Ed Tomlinson
Hi Daniel, The patch below also works. You can use my Tested By for it. Thanks Ed Tomlinson PS. I _really_ need to get a serial console working on my i7 box. On Monday 07 July 2014 14:26:54 Daniel Vetter wrote: > On Mon, Jul 07, 2014 at 06:45:49AM -0400, Ed Tomlinson wrote: > > Daniel, > > >

Re: [Intel-gfx] [PATCH] drm/i915: Restrict GPU boost to the RCS engine

2014-07-07 Thread Deepak S
On Monday 07 July 2014 02:35 PM, Daniel Vetter wrote: On Tue, Jun 24, 2014 at 05:22:17PM +0530, Deepak S wrote: Hi Chris/Daniel, The patch is helping in some of the side-effects due to gpu boost. I still need to get more data. I will keep the thread updated. Ping. Might as well review it, to

[Intel-gfx] [v3 01/13] drm: Move DRM_ROTATE bits out of omapdrm into drm_crtc.h

2014-07-07 Thread sonika . jindal
From: Ville Syrjälä The rotation property stuff should be standardized among all drivers. Move the bits to drm_crtc.h from omap_drv.h. Signed-off-by: Ville Syrjälä Reviewed-by: Imre Deak --- drivers/gpu/drm/omapdrm/omap_drv.h |7 --- include/drm/drm_crtc.h |8

[Intel-gfx] [v3 03/13] drm: Add drm_mode_create_rotation_property()

2014-07-07 Thread sonika . jindal
From: Ville Syrjälä Add a function to create a standards compliant rotation property. Signed-off-by: Ville Syrjälä Reviewed-by: Imre Deak --- drivers/gpu/drm/drm_crtc.c | 18 ++ include/drm/drm_crtc.h |2 ++ 2 files changed, 20 insertions(+) diff --git a/drivers/gpu

[Intel-gfx] [v3 02/13] drm: Add support_bits parameter to drm_property_create_bitmask()

2014-07-07 Thread sonika . jindal
From: Ville Syrjälä Make drm_property_create_bitmask() a bit more generic by allowing the caller to specify which bits are in fact supported. This allows multiple callers to use the same enum list, but still create different versions of the same property with different list of supported bits. v2

[Intel-gfx] [v3 00/13] Support for 180 degree HW rotation

2014-07-07 Thread sonika . jindal
From: Sonika Jindal Enables 180 degree rotation for sprite and primary planes. Updated the primary plane rotation support as per the new universal plane design. Most of these patches were already reviewed in intel-gfx in February 2014 thats why there is version history in few of them. v2: Moved

[Intel-gfx] [v3 04/13] drm/omap: Switch omapdrm over to drm_mode_create_rotation_property()

2014-07-07 Thread sonika . jindal
From: Ville Syrjälä Use the new drm_mode_create_rotation_property() in omapdrm. Cc: dri-de...@lists.freedesktop.org Signed-off-by: Ville Syrjälä Reviewed-by: Rob Clark Reviewed-by: Imre Deak Reviewed-by: Sagar Kamble --- drivers/gpu/drm/omapdrm/omap_plane.c | 20 +++- 1 fi

[Intel-gfx] [v3 08/13] drm/i915: Make intel_plane_restore() return an error

2014-07-07 Thread sonika . jindal
From: Ville Syrjälä Propagate the error from intel_update_plane() up through intel_plane_restore() to the caller. This will be used for rollback purposes when setting properties fails. Cc: dri-de...@lists.freedesktop.org Signed-off-by: Ville Syrjälä Reviewed-by: Imre Deak --- drivers/gpu/drm/

[Intel-gfx] [v3 05/13] drm: Add drm_rect rotation functions

2014-07-07 Thread sonika . jindal
From: Ville Syrjälä Add some helper functions to move drm_rects between different rotated coordinate spaces. One function does the forward transform and another does the inverse. Cc: dri-de...@lists.freedesktop.org Signed-off-by: Ville Syrjälä Reviewed-by: Imre Deak --- drivers/gpu/drm/drm_re

[Intel-gfx] [v3 07/13] drm/i915: Add 180 degree sprite rotation support

2014-07-07 Thread sonika . jindal
From: Ville Syrjälä The sprite planes (in fact all display planes starting from gen4) support 180 degree rotation. Add the relevant low level bits to the sprite code to make use of that feature. The upper layers are not yet plugged in. v2: HSW handles the rotated buffer offset automagically v3

[Intel-gfx] [v3 09/13] drm/i915: Add rotation property for sprites

2014-07-07 Thread sonika . jindal
From: Ville Syrjälä Sprite planes support 180 degree rotation. The lower layers are now in place, so hook in the standard rotation property to expose the feature to the users. v2: Moving rotation_property to drm_plane Cc: dri-de...@lists.freedesktop.org Signed-off-by: Ville Syrjälä Signed-off-

[Intel-gfx] [v3 11/13] drm: Resetting rotation property

2014-07-07 Thread sonika . jindal
From: Sonika Jindal Reset rotation property to 0 wherever applicable v2: Also calling set_property of the plane to set the rotation in the plane structure. Cc: damien.lesp...@intel.com Signed-off-by: Sonika Jindal Reviewed-by: Damien Lespiau --- drivers/gpu/drm/drm_fb_helper.c | 16 +++

[Intel-gfx] [v3 10/13] drm/i915: Add 180 degree primary plane rotation support

2014-07-07 Thread sonika . jindal
From: Sonika Jindal Primary planes support 180 degree rotation. Expose the feature through rotation drm property. v2: Calculating linear/tiled offsets based on pipe source width and height. Added 180 degree rotation support in ironlake_update_plane. v3: Checking if CRTC is active before issuein

[Intel-gfx] [v3 06/13] drm: Add drm_rotation_simplify()

2014-07-07 Thread sonika . jindal
From: Ville Syrjälä drm_rotation_simplify() can be used to eliminate unsupported rotation flags. It will check if any unsupported flags are present, and if so it will modify the rotation to an alternate form by adding 180 degrees to rotation angle, and flipping the reflect x and y bits. The hope

[Intel-gfx] [v3 12/13] Documentation: drm: Removing placeholders for generic drm properties description

2014-07-07 Thread sonika . jindal
From: Sagar Kamble These property descriptions were kept as placeholder. Removing them for simplicity. Cc: damien.lesp...@intel.com Cc: daniel.vet...@ffwll.ch Cc: ville.syrj...@linux.intel.com Signed-off-by: Sagar Kamble Reviewed-by: Damien Lespiau --- Documentation/DocBook/drm.tmpl | 64 +

[Intel-gfx] [v3 13/13] Documentation: drm: describing rotation property for i915

2014-07-07 Thread sonika . jindal
From: Sagar Kamble Cc: damien.lesp...@intel.com Cc: daniel.vet...@ffwll.ch Cc: ville.syrj...@linux.intel.com Signed-off-by: Sagar Kamble Reviewed-by: Damien Lespiau --- Documentation/DocBook/drm.tmpl | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/Documentation/

Re: [Intel-gfx] [PATCH] drm/i915: Restrict GPU boost to the RCS engine

2014-07-07 Thread Chris Wilson
On Wed, Jul 09, 2014 at 10:09:00AM +0530, Deepak S wrote: > > On Monday 07 July 2014 02:35 PM, Daniel Vetter wrote: > >On Tue, Jun 24, 2014 at 05:22:17PM +0530, Deepak S wrote: > >>Hi Chris/Daniel, > >> > >>The patch is helping in some of the side-effects due to gpu boost. I > >>still need to get

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Make use of intel_fb_obj()

2014-07-07 Thread Chris Wilson
On Mon, Jul 07, 2014 at 06:21:48PM -0700, Matt Roper wrote: > This should hopefully simplify the display code slightly and also > solves at least one mistake in intel_pipe_set_base() where > to_intel_framebuffer(fb)->obj is referenced during local variable > initialization, before 'if (!fb)' gets c

<    1   2