On Mon, Jun 02, 2014 at 09:51:27PM +, O'Rourke, Tom wrote:
> >From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel
> >Vetter
> >Sent: Monday, June 02, 2014 1:26 AM
> >To: O'Rourke, Tom
> >Cc: intel-gfx@lists.freedesktop.org; Ben Widawsky; Kristen Carlson Accardi
> >Subject:
On Mon, Jun 02, 2014 at 11:54:10PM +0530, Vijay Purushothaman wrote:
> On 5/16/2014 5:43 AM, Rodrigo Vivi wrote:
> >Now we have the active/inactive state for exit and this actually changes the
> >HW enable bit the status was a bit confusing for users. So let's provide
> >more info.
> >
> >Signed-of
On Tue, Jun 03, 2014 at 01:42:03AM +, Lin, Mengdong wrote:
> > -Original Message-
> > From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch]
>
> > > Hi Daniel,
> > >
> > > Would you please share more info about your idea?
> > >
> > > - What would be an avsink device represent here?
> > >
On Tue, Jun 03, 2014 at 06:05:45AM +, Yang, Guang A wrote:
> Tested-by: "Yang, Guang A"
> With this patch, the 32 bit system can be able to boot normally.
I wonder what's going to happen on 64 bit kernels with 32 bit userspace.
Since that one's a really common thing with games. Whatever. Queu
On Mon, Jun 02, 2014 at 07:06:52PM +0100, Damien Lespiau wrote:
> On Mon, Jun 02, 2014 at 10:12:06AM -0700, Matt Roper wrote:
> > Signed-off-by: Matt Roper
>
> The commit message is a bit terse and could do with some digging.
> Something like:
>
> Those LUT where defined in the original sprite p
From: Robert Beckett
Replaced ever growing switch for gen version with chained conditionals.
Futre gen's only need to add a new one if they require something different.
Reviewed-by: Damien Lespiau
Signed-off-by: Robert Beckett
[danvet: Picked from internal tree and white-wash commit message.]
On Mon, 02 Jun 2014, clinton.a.tay...@intel.com wrote:
> From: Clint Taylor
>
> The panel power sequencer on vlv doesn't appear to accept changes to its
> T12 power down duration during warm reboots. This change forces a delay
> for warm reboots to the T12 panel timing as defined in the VBT table
On 5/16/2014 5:43 AM, Rodrigo Vivi wrote:
Let's be more conservative and protect platforms that don't
support PSR from unecessary interactions.
Signed-off-by: Rodrigo Vivi
---
drivers/gpu/drm/i915/intel_dp.c | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/dr
On 5/16/2014 5:43 AM, Rodrigo Vivi wrote:
Being more conservative by enabling PSR only on psr_enable function.
Signed-off-by: Rodrigo Vivi
---
drivers/gpu/drm/i915/intel_dp.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/driv
On 5/16/2014 10:12 PM, Rodrigo Vivi wrote:
On Fri, May 16, 2014 at 3:23 AM, Chris Wilson mailto:ch...@chris-wilson.co.uk>> wrote:
On Thu, May 15, 2014 at 08:13:05PM -0400, Rodrigo Vivi wrote:
> The perfect solution for psr_exit is the hardware tracking the
changes and
> doin
On 5/16/2014 5:43 AM, Rodrigo Vivi wrote:
Signed-off-by: Rodrigo Vivi
---
drivers/gpu/drm/i915/intel_dp.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index 28144d3..9421b0b 100644
--- a/drivers/gpu/drm/i915/intel_d
On 6/3/2014 1:10 PM, Daniel Vetter wrote:
On Mon, Jun 02, 2014 at 11:54:10PM +0530, Vijay Purushothaman wrote:
On 5/16/2014 5:43 AM, Rodrigo Vivi wrote:
Now we have the active/inactive state for exit and this actually changes the
HW enable bit the status was a bit confusing for users. So let's
On 5/16/2014 5:43 AM, Rodrigo Vivi wrote:
On the current structure HSW doesn't support PSR with sprites enabled
but sprites can be enabled after PSR was enabled what would cause
user to miss screen updates.
Could you please explain this a bit more? Did you get a confirmation
from h/w team that
Generated using semantic patches:
@@
expression E;
@@
- drm_get_connector_name(&E)
+ E.name
@@
expression E;
@@
- drm_get_connector_name(E)
+ E->name
v2: Turn drm_get_connector_name(&E) into E.name instead of &(E)->name.
Acked-by: David Herrmann
Signed-off-by: Jani Nikula
---
drivers/gpu/d
Generated using semantic patch:
@@
expression E;
@@
- drm_get_connector_name(E)
+ E->name
Acked-by: David Herrmann
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_crtc.c | 4 ++--
drivers/gpu/drm/drm_crtc_helper.c | 6 +++---
drivers/gpu/drm/drm_edid.c | 6 +++---
drive
Generated using semantic patch:
@@
expression E;
@@
- drm_get_connector_name(E)
+ E->name
Acked-by: Alex Deucher
Acked-by: David Herrmann
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/radeon/radeon_connectors.c | 19 ---
drivers/gpu/drm/radeon/radeon_display.c| 2 +-
2
Hi all, this is v2 of [1] to remove drm_get_connector_name() and
drm_get_encoder_name(), adding patch 1 for imx in staging and making
some dereferences less of an eye sore. This is based on Dave's drm-next
branch.
BR,
Jani.
[1] http://mid.gmane.org/cover.1401110921.git.jani.nik...@intel.com
Ja
Generated using semantic patch:
@@
expression E;
@@
- drm_get_connector_name(E)
+ E->name
Acked-by: David Herrmann
Signed-off-by: Jani Nikula
---
drivers/staging/imx-drm/imx-drm-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/imx-drm/imx-drm-core.c
Generated using semantic patch:
@@
expression E;
@@
- drm_get_encoder_name(E)
+ E->name
Acked-by: David Herrmann
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_crtc.c| 2 +-
drivers/gpu/drm/drm_crtc_helper.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/dr
Generated using semantic patches:
@@
expression E;
@@
- drm_get_connector_name(&E)
+ E.name
@@
expression E;
@@
- drm_get_connector_name(E)
+ E->name
v2: Turn drm_get_connector_name(&E) into E.name instead of &(E)->name.
Acked-by: David Herrmann
Signed-off-by: Jani Nikula
---
drivers/gpu/d
No longer used or needed as the structs have a name field.
Acked-by: David Herrmann
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_crtc.c | 20
include/drm/drm_crtc.h | 2 --
2 files changed, 22 deletions(-)
diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/dr
Generated using semantic patches:
@@
expression E;
@@
- drm_get_encoder_name(&E)
+ E.name
@@
expression E;
@@
- drm_get_encoder_name(E)
+ E->name
v2: Turn drm_get_encoder_name(&E) into E.name instead of &(E)->name.
Acked-by: David Herrmann
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i91
On Wed, 28 May 2014, Damien Lespiau wrote:
> Functions that can't fail are such a bliss to work with, it'd be shame
> to miss the occasion. The "failure" mode is the DSI connector not being
> created, the rest of the initialization can carry on happily.
>
> We weren't even checking that value anyw
Kenneth, please file a bug report on DRM/Intel at [1], with the below
information, and attach dmesg from boot with drm.debug=0xe module
parameter set.
Please find a further question below inline.
[1] https://bugs.freedesktop.org/enter_bug.cgi?product=DRI
On Wed, 28 May 2014, "Kenneth R. Crudup"
On Tue, Jun 03, 2014 at 03:05:14PM +0300, Jani Nikula wrote:
> > - return false;
> > + return;
>
> Okay this went in already, but I find return statements at the end of
> void functions like that a bit silly...
>
> ...but hey, you can send a fix removing that! ;)
Sigh, will do, thanks for po
intel_dsi_init() lost its return value in:
Damien Lespiau
Date: Wed May 28 12:30:56 2014 +0100
drm/i915: Make intel_dsi_init() return void
However, I left a return; at the end of the function and, as Jani noticed, it
looks silly.
Suggested-by: Jani Nikula
Signed-off-by: Damien Lesp
On Tue, 03 Jun 2014, Damien Lespiau wrote:
> intel_dsi_init() lost its return value in:
>
> Damien Lespiau
> Date: Wed May 28 12:30:56 2014 +0100
>
> drm/i915: Make intel_dsi_init() return void
>
> However, I left a return; at the end of the function and, as Jani noticed, it
> looks si
On Tue, Jun 03, 2014 at 04:35:01PM +0300, Jani Nikula wrote:
> On Tue, 03 Jun 2014, Damien Lespiau wrote:
> > intel_dsi_init() lost its return value in:
> >
> > Damien Lespiau
> > Date: Wed May 28 12:30:56 2014 +0100
> >
> > drm/i915: Make intel_dsi_init() return void
> >
> > However,
The drm core shouldn't depend upon any helpers, and we make sure this
doesn't accidentally happen by moving them into the helper-only
drm_kms_helper.ko module.
Cc: Matt Roper
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/Makefile | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
d
From: Tim Gore
The missing macro that was preventing the gem_exec_params
test from building is now in i915_drm.h, in ABT at least,
and this test can now build. So I have removed it from the
skip list in Android.mk
For Gmin I have added a patch for i915_drm.h to the Wiki
Signed-off-by: Tim Gore
From: Tim Gore
kms_render.c included testdisplay.h but did not need it.
This was preventing it from building on Android due to the
lack of a Glib port. So I have removed this #include and
changed Android.mk so that kms_render is built if we have
cairo.
Signed-off-by: Tim Gore
---
tests/Android
78dc0c04745ad4485b994f67833f4a155749f01d added REQUIRED_MODULES to the
driver link line for... some reason. That pulled in the libs from the
XF86DRI check, which near as I can tell has always been wrong, all of
the other extension checks just look for the protocol module and
xextproto doesn't defi
On Tue, Jun 03, 2014 at 02:37:27PM +0100, Damien Lespiau wrote:
> On Tue, Jun 03, 2014 at 04:35:01PM +0300, Jani Nikula wrote:
> > On Tue, 03 Jun 2014, Damien Lespiau wrote:
> > > intel_dsi_init() lost its return value in:
> > >
> > > Damien Lespiau
> > > Date: Wed May 28 12:30:56 2014 +010
Hi Daniel, dear intel experts,
We've put a crtc restriction on VGA (it needs to be crtc 0) to work around
some issues. DVI/LVDS should work on crtc 1. You can set this with the
--crtc knob for xrandr.
Unfortunately, I cannot. Whenever I put DVI1 (which is connected to the
internal screen) on c
On Tue, Jun 03, 2014 at 03:38:56PM +0200, Daniel Vetter wrote:
> The drm core shouldn't depend upon any helpers, and we make sure this
> doesn't accidentally happen by moving them into the helper-only
> drm_kms_helper.ko module.
>
> Cc: Matt Roper
> Signed-off-by: Daniel Vetter
Are there any KM
On Tue, Jun 03, 2014 at 04:38:40PM +0200, Thomas Richter wrote:
> Hi Daniel, dear intel experts,
>
> >We've put a crtc restriction on VGA (it needs to be crtc 0) to work around
> >some issues. DVI/LVDS should work on crtc 1. You can set this with the
> >--crtc knob for xrandr.
> >
> Unfortunately,
Signed-off-by: Imre Deak
---
tools/quick_dump/quick_dump.py | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/tools/quick_dump/quick_dump.py b/tools/quick_dump/quick_dump.py
index 523f675..2eb7724 100755
--- a/tools/quick_dump/quick_dump.py
+++ b/tools/quick_dump/quick_dump.
On Tue, Jun 03, 2014 at 03:18:31PM +0100, tim.g...@intel.com wrote:
> From: Tim Gore
>
> kms_render.c included testdisplay.h but did not need it.
> This was preventing it from building on Android due to the
> lack of a Glib port. So I have removed this #include and
> changed Android.mk so that km
On Tue, Jun 3, 2014 at 4:44 PM, Matt Roper wrote:
> On Tue, Jun 03, 2014 at 03:38:56PM +0200, Daniel Vetter wrote:
>> The drm core shouldn't depend upon any helpers, and we make sure this
>> doesn't accidentally happen by moving them into the helper-only
>> drm_kms_helper.ko module.
>>
>> Cc: Matt
On Tue, Jun 03, 2014 at 10:26:46AM -0400, Adam Jackson wrote:
> 78dc0c04745ad4485b994f67833f4a155749f01d added REQUIRED_MODULES to the
> driver link line for... some reason. That pulled in the libs from the
> XF86DRI check, which near as I can tell has always been wrong, all of
> the other extensi
On Tue, Jun 03, 2014 at 04:49:25PM +0200, Daniel Vetter wrote:
> On Tue, Jun 3, 2014 at 4:44 PM, Matt Roper wrote:
> > On Tue, Jun 03, 2014 at 03:38:56PM +0200, Daniel Vetter wrote:
> >> The drm core shouldn't depend upon any helpers, and we make sure this
> >> doesn't accidentally happen by movin
The drm core shouldn't depend upon any helpers, and we make sure this
doesn't accidentally happen by moving them into the helper-only
drm_kms_helper.ko module.
v2: Don't break the build for vmwgfx, spotted by Matt.
Cc: Matt Roper
Cc: Thomas Hellstrom
Signed-off-by: Daniel Vetter
---
drivers/g
Am 03.06.2014 16:45, schrieb Daniel Vetter:
Yeah, both connectors use CRTC 0. Have you tried what happens if you:
- disable DVI1 first (--off)
- then enable it on crtc 1?
Same difference, internal screen goes blank with --off, and stays blank
after moving it to crtc 1 if I try to re-enable i
On Tue, Jun 03, 2014 at 05:46:40PM +0300, Imre Deak wrote:
> Signed-off-by: Imre Deak
Very-much-wanted-by: Daniel Vetter
> ---
> tools/quick_dump/quick_dump.py | 5 +
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/tools/quick_dump/quick_dump.py b/tools/quick_dump/quick_d
On Mon, Jun 02, 2014 at 02:18:14PM +0100, Sam Jansen wrote:
>Hello intel-gfx,
>I'm working on an application using VA-API for H264 encode+decode, and
>JPEG decode on an Atom E3815. Unfortunately we've hit what I believe is a
>kernel bug, and the "perf top" output is pointing at i915
On Tue, Jun 03, 2014 at 05:04:52PM +0200, Thomas Richter wrote:
> Am 03.06.2014 16:45, schrieb Daniel Vetter:
>
> >
> >Yeah, both connectors use CRTC 0. Have you tried what happens if you:
> >- disable DVI1 first (--off)
> >- then enable it on crtc 1?
>
> Same difference, internal screen goes bla
Am 03.06.2014 17:14, schrieb Chris Wilson:
On Tue, Jun 03, 2014 at 05:04:52PM +0200, Thomas Richter wrote:
Am 03.06.2014 16:45, schrieb Daniel Vetter:
Yeah, both connectors use CRTC 0. Have you tried what happens if you:
- disable DVI1 first (--off)
- then enable it on crtc 1?
Same differen
On Tue, 03 Jun 2014, Daniel Vetter wrote:
> On Tue, Jun 03, 2014 at 05:46:40PM +0300, Imre Deak wrote:
>> Signed-off-by: Imre Deak
>
> Very-much-wanted-by: Daniel Vetter
AOL'd-by: Jani Nikula
>> ---
>> tools/quick_dump/quick_dump.py | 5 +
>> 1 file changed, 1 insertion(+), 4 deletions(-
On Tue, Jun 03, 2014 at 05:19:26PM +0200, Thomas Richter wrote:
> Am 03.06.2014 17:14, schrieb Chris Wilson:
> >On Tue, Jun 03, 2014 at 05:04:52PM +0200, Thomas Richter wrote:
> >>Am 03.06.2014 16:45, schrieb Daniel Vetter:
> >>
> >>>
> >>>Yeah, both connectors use CRTC 0. Have you tried what happe
Am 03.06.2014 17:26, schrieb Chris Wilson:
I should have said VGA. Thinking about it, it is likely a shared DDC line
so that only a single EDID can be read.
Actually, it gets the EDID from the VGA panel just fine, also shows me
the modes it supports. DVI1 has no edit, though it gets its allo
On Tue, Jun 03, 2014 at 05:50:06PM +0200, Thomas Richter wrote:
> Am 03.06.2014 17:26, schrieb Chris Wilson:
>
> >
> >I should have said VGA. Thinking about it, it is likely a shared DDC line
> >so that only a single EDID can be read.
>
> Actually, it gets the EDID from the VGA panel just fine, a
From: Clint Taylor
The panel power sequencer on vlv doesn't appear to accept changes to its
T12 power down duration during warm reboots. This change forces a delay
for warm reboots to the T12 panel timing as defined in the VBT table for
the connected panel.
Ver2: removed redundant pr_crit(), com
On Tue, Apr 29, 2014 at 1:30 PM, Jani Nikula wrote:
> Historically we've exposed the full backlight PWM duty cycle range to
> the userspace, in the name of "mechanism, not policy". However, it turns
> out there are both panels and board designs where there is a minimum
> duty cycle that is require
The drm core shouldn't depend upon any helpers, and we make sure this
doesn't accidentally happen by moving them into the helper-only
drm_kms_helper.ko module.
v2: Don't break the build for vmwgfx, spotted by Matt.
v3: Unbreak the depency loop around CONFIG_FB (not actually a loop
since it involv
2014-05-22 11:48 GMT-03:00 :
> From: Ville Syrjälä
>
> Add a mechanism by which you can queue up watermark update to happen
> after the vblank counter has reached a certain value. The vblank
> interrupt handler will schedule a work which will do the actual
> watermark programming in process conte
On Tue, Jun 03, 2014 at 03:50:12PM -0300, Paulo Zanoni wrote:
> 2014-05-22 11:48 GMT-03:00 :
> > From: Ville Syrjälä
> >
> > Add a mechanism by which you can queue up watermark update to happen
> > after the vblank counter has reached a certain value. The vblank
> > interrupt handler will schedul
On Tue, Jun 3, 2014 at 6:40 PM, Stéphane Marchesin wrote:
> On Tue, Apr 29, 2014 at 1:30 PM, Jani Nikula wrote:
>> Historically we've exposed the full backlight PWM duty cycle range to
>> the userspace, in the name of "mechanism, not policy". However, it turns
>> out there are both panels and boa
2014-05-22 11:48 GMT-03:00 :
> From: Ville Syrjälä
>
> We need to perform watermark programming before and after changing the
> plane configuration. Add two new vfuncs to do that. The pre phase is
> supposed to switch over to the intermediate watermarks which are
> computed so that they can deal
rendercopy was failing to emit 3DSTATE_WM_DEPTH_STENCIL, which is a new
packet on Broadwell. Mesa emits this packet.
This appears to fix various tests on a fresh boot, when Mesa has never
run.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=78890
Bugzilla: https://bugs.freedesktop.org/sho
On Tue, Jun 03, 2014 at 02:52:30PM -0700, Kenneth Graunke wrote:
> rendercopy was failing to emit 3DSTATE_WM_DEPTH_STENCIL, which is a new
> packet on Broadwell. Mesa emits this packet.
>
> This appears to fix various tests on a fresh boot, when Mesa has never
> run.
>
> Bugzilla: https://bugs.f
2014-05-22 11:48 GMT-03:00 :
> From: Ville Syrjälä
>
> Switch the code over to using the two phase watermark update. The steps
> generally follow this pattern:
>
> 1. Calculate new plane parameters for changed planes
> 2. Calculate new target and intermediate watermarks
> 3. Check that both the t
From: Chris Wilson
Touching the VGA resources on an IVB EFI machine causes hard hangs when
we then kick out the efifb. Ouch.
Apparently this also prevents unclaimed register errors on hsw and
hard machine hangs on my i855gm when trying to unbind fbcon.
Also, we want this to make I915_FBDEV=n sa
makes sure the platform match what is expected.
Sample output:
bwidawsk@ironside ~/intel-gfx/intel-gpu-tools (master)$ sudo
./tests/gem_exec_nop
PCI ID: 0x0a16 IGT-Version: 1.6-g21bcc3f (x86_64) (Linux: 3.14.4-1-ARCH x86_64)
Signed-off-by: Ben Widawsky
---
lib/igt_core.c | 17 ++---
On 3 June 2014 21:56, Jani Nikula wrote:
> Hi all, this is v2 of [1] to remove drm_get_connector_name() and
> drm_get_encoder_name(), adding patch 1 for imx in staging and making
> some dereferences less of an eye sore. This is based on Dave's drm-next
> branch.
>
I pushed these, after regeneratin
On 4 June 2014 03:30, Daniel Vetter wrote:
> The drm core shouldn't depend upon any helpers, and we make sure this
> doesn't accidentally happen by moving them into the helper-only
> drm_kms_helper.ko module.
>
> v2: Don't break the build for vmwgfx, spotted by Matt.
>
> v3: Unbreak the depency lo
On Mon, 2014-06-02 at 10:19 +0200, Daniel Vetter wrote:
> On Sun, Jun 01, 2014 at 12:12:50PM +0530, Akash Goel wrote:
> > On Mon, 2014-05-19 at 13:03 +0530, Akash Goel wrote:
> > > On Mon, 2014-05-19 at 08:56 +0200, Daniel Vetter wrote:
> > > > On Sun, May 18, 2014 at 11:27:00AM +0530, Akash Goel w
From: Dave Airlie
The digital ports from Ironlake and up have the ability to distinguish
between long and short HPD pulses. Displayport 1.1 only uses the short
form to request link retraining usually, so we haven't really needed
support for it until now.
However with DP 1.2 MST we need to handle
On Mon, May 26, 2014 at 7:26 PM, Daniel Vetter wrote:
> On Thu, May 22, 2014 at 05:48:06PM +0300, ville.syrj...@linux.intel.com wrote:
>> From: Ville Syrjälä
>>
>> Because of the upcoming vblank interrupt driven watermark update
>> mechanism we will have use for vblank interrupts during plane
>>
This is a note to let you know that I've just added the patch titled
drm/i915: Disable self-refresh for untiled fbs on i915gm
to the 3.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
This is a note to let you know that I've just added the patch titled
drm/i915: quirk invert brightness for Acer Aspire 5336
to the 3.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
On Wed, May 21, 2014 at 11:07:21AM +0200, Daniel Vetter wrote:
> Hi Greg,
>
> This is a set of drm/i915 patches which didn't apply cleanly on for 3.14. All
> absed on 3.14.4. I've left out the bdw patches for now and will sign up
> someone
> else for that task.
Thanks for the patches, all now ap
This is a note to let you know that I've just added the patch titled
drm/i915: Fix unsafe loop iteration over vma whilst unbinding them
to the 3.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the pat
This is a note to let you know that I've just added the patch titled
drm/i915: move power domain init earlier during system resume
to the 3.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is
73 matches
Mail list logo
