Re: [Intel-gfx] [PATCH i-g-t] kms_cursor_crc: Move igt_pipe_crc_{new, free} to init

On Thu, May 22, 2014 at 08:12:58PM +0300, Ville Syrjälä wrote: > On Thu, May 22, 2014 at 10:06:37AM -0700, Matt Roper wrote: > > On Thu, May 22, 2014 at 08:01:09PM +0300, Ville Syrjälä wrote: > > > On Thu, May 22, 2014 at 09:47:39AM -0700, Matt Roper wrote: > > > > If a subtest fails, cleanup_crtc(

Re: [Intel-gfx] [PATCH 43/66] drm/i915: Disable pipe before ports on ilk

On Thu, May 22, 2014 at 04:25:05PM -0300, Paulo Zanoni wrote: > 2014-04-24 18:55 GMT-03:00 Daniel Vetter : > > The modeset sequence docs are very clear that we should disable the > > pipe before we switch off any ports, for both pch ports and the cpu > > edp port. > > > > In practice it doesn't see

Re: [Intel-gfx] [PATCH 46/66] drm/i915: Move hsw_fdi_link_train into intel_crt.c

2014-04-24 18:55 GMT-03:00 Daniel Vetter : > The pch encoder case really isn't anything generic on hsw: > - It's for the vga port only and > - the vga port does only exist on some hsw platforms. > > Imo it helps the generic code flow a lot if we shovel all this into > hsw specific enable/disable ho

Re: [Intel-gfx] [PATCH 44/66] drm/i915: Pass port explicitly to intel_ddi_get_hw_state

On Thu, May 22, 2014 at 04:38:07PM -0300, Paulo Zanoni wrote: > 2014-04-24 18:55 GMT-03:00 Daniel Vetter : > > Well, the newly created intel_ddi_get_port_state. > > > > In general intel_ddi.c has way too intimate knowledge with everyone > > else as exemplified with all the encoder/connector noodlin

Re: [Intel-gfx] [PATCH 47/66] drm/i915: Move pch fifo underrun report enabling to hsw_crt_pre_enable

2014-04-24 18:55 GMT-03:00 Daniel Vetter : > With this all the pch pre-enable work has been moved into the special > hsw crt encoder functions. For the same reasons I gave in the other patches, I'm not convinced this is an improvement to our code. It looks like we're just breaking the abstraction

[Intel-gfx] [PATCH] drm/i915: Unexport intel_ddi_connector_get_hw_state

The connector->get_hw_state function is actually platform dependent. So move it out of the shared connector init functions. This allows us to drop another intel_ddi.c export. v2: Fix segfaults when the dp connector fails to initialize (e.g. due there not being a panel). Spotted by Paulo. Cc: Paul

[Intel-gfx] [PATCH 6/6] drm/i915: Switch to unified plane cursor handling (v4)

The DRM core will translate calls to legacy cursor ioctls into universal cursor calls automatically, so there's no need to maintain the legacy cursor support. This greatly simplifies the transition since we don't have to handle reference counting differently depending on which cursor interface was

Re: [Intel-gfx] [PATCH 3/6] drm/i915: Split the ringbuffers from the rings (2/3)

On Thu, May 22, 2014 at 02:13:35PM +0100, oscar.ma...@intel.com wrote: > From: Oscar Mateo > > This refactoring has been performed using the following Coccinelle > semantic script: > > @@ > struct intel_engine_cs r; > @@ > ( > - (r).obj > + r.buffer->obj > | > - (

Re: [Intel-gfx] [PATCH 4/6] drm/i915: Split the ringbuffers from the rings (3/3)

On Thu, May 22, 2014 at 02:13:36PM +0100, oscar.ma...@intel.com wrote: > From: Oscar Mateo > > Manual cleanup after the previous Coccinelle script. > > Yes, I could write another Coccinelle script to do this but I > don't want labor-replacing robots making an honest programmer's > work obsolete

Re: [Intel-gfx] [PATCH 5/6] drm/i915: s/i915_hw_context/intel_context

On Thu, May 22, 2014 at 02:13:37PM +0100, oscar.ma...@intel.com wrote: > From: Oscar Mateo > > Up until now, contexts had one (and only one) backing object that was > used by the hardware to save/restore render ring contexts (via the > MI_SET_CONTEXT command). Other rings did not have or need thi

Re: [Intel-gfx] [PATCH 4/6] drm/i915: Split the ringbuffers from the rings (3/3)

On Thu, May 22, 2014 at 11:37:50PM +0200, Daniel Vetter wrote: > On Thu, May 22, 2014 at 02:13:36PM +0100, oscar.ma...@intel.com wrote: > > From: Oscar Mateo > > > > Manual cleanup after the previous Coccinelle script. > > > > Yes, I could write another Coccinelle script to do this but I > > don

Re: [Intel-gfx] [PATCH 0/6] Execlists prep-work

On Thu, May 22, 2014 at 02:13:32PM +0100, oscar.ma...@intel.com wrote: > From: Oscar Mateo > > These patches contain refactoring and preparatory work for Execlists [1]. > > [1http://lists.freedesktop.org/archives/intel-gfx/2014-May/044847.html] > http://lists.freedesktop.org/archives/intel-gfx/2

Re: [Intel-gfx] [PATCH 46/66] drm/i915: Move hsw_fdi_link_train into intel_crt.c

On Thu, May 22, 2014 at 05:28:05PM -0300, Paulo Zanoni wrote: > 2014-04-24 18:55 GMT-03:00 Daniel Vetter : > > The pch encoder case really isn't anything generic on hsw: > > - It's for the vga port only and > > - the vga port does only exist on some hsw platforms. > > > > Imo it helps the generic c

Re: [Intel-gfx] [PATCH 47/66] drm/i915: Move pch fifo underrun report enabling to hsw_crt_pre_enable

On Thu, May 22, 2014 at 05:38:13PM -0300, Paulo Zanoni wrote: > 2014-04-24 18:55 GMT-03:00 Daniel Vetter : > > With this all the pch pre-enable work has been moved into the special > > hsw crt encoder functions. > > For the same reasons I gave in the other patches, I'm not convinced > this is an i

[Intel-gfx] [I-G-T][PATCH] Add panning test for primary plane.

Get CRCs of a full red and a full blue surface as reference. Create a big framebuffer that is twice width and twice height as the current display mode. Fill the top left quarter with red, bottom right quarter with blue Check the scanned out image with the CRTC at position (0, 0) of the framebuffe

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Add aspect ratio property for HDMI

Adding dri-devel.. On May-22-2014 4:50 PM, Kannan, Vandana wrote: > Create and attach the drm property to set aspect ratio. If there is no user > specified value, then PAR_NONE/Automatic option is set by default. User can > select aspect ratio 4:3 or 16:9. The aspect ratio selected by user would >

Re: [Intel-gfx] [PATCH 01/11] drm/dp_helper: add defines for DP 1.2 and MST support.

Dave Airlie Tuesday, May 20, 2014 7:54 PM From: Dave Airlie This just adds the defines from the DP 1.2 spec, which we will use later. Signed-off-by: Dave Airlie --- include/drm/drm_dp_helper.h | 78 + 1 file changed, 78

Re: [Intel-gfx] [PATCH 02/11] drm: add DP MST encoder type

Dave Airlie Tuesday, May 20, 2014 7:54 PM From: Dave Airlie This adds an encoder type for DP MST encoders. Signed-off-by: Dave Airlie --- drivers/gpu/drm/drm_crtc.c | 1 + include/uapi/drm/drm_mode.h | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/gpu/

Re: [Intel-gfx] [PATCH 04/11] drm/crtc: add interface to reinitialise the legacy mode group

Dave Airlie Tuesday, May 20, 2014 7:54 PM From: Dave Airlie This can be called to update things after dynamic connectors/encoders are created/deleted. Signed-off-by: Dave Airlie --- drivers/gpu/drm/drm_crtc.c | 9 + include/drm/drm_crtc.h | 1 + 2 files chan

Re: [Intel-gfx] [PATCH 03/11] drm/i915: add some registers need for displayport MST support.

Dave Airlie Tuesday, May 20, 2014 7:54 PM From: Dave Airlie These are just from the Haswell spec. Signed-off-by: Dave Airlie --- drivers/gpu/drm/i915/i915_reg.h | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i91

Re: [Intel-gfx] [PATCH 01/11] drm/dp_helper: add defines for DP 1.2 and MST support.

On Wednesday, May 21, 2014 11:55 AM, Dave Airlie wrote: > > From: Dave Airlie > > This just adds the defines from the DP 1.2 spec, which we > will use later. > > Signed-off-by: Dave Airlie I checked this patch by using DP 1.2 spec. These definitions are correct. Thank you. Reviewed-by: Jingo

[Intel-gfx] [PATCH] drm/i915: Prevent negative relocation deltas from wrapping

From: Chris Wilson This is pure evil. Userspace, I'm looking at you SNA, repacks batch buffers on the fly after generation as they are being passed to the kernel for execution. These batches also contain self-referenced relocations as a single buffer encompasses the state commands, kernels, verti

<    1   2