Re: [Intel-gfx] [PATCH v2 1/1] drm/i915: Fix VGA handling using stop_machine() or mmio

2013-10-07 Thread Daniel Vetter
On Mon, Oct 7, 2013 at 2:23 AM, Dave Airlie wrote: > I'm think I'm going to make an executive decision to merge Ville's > latest patch to avoid the regression, the other option being just to > revert everything back to the status quo by reverting all the patches > from the past few months, if peop

Re: [Intel-gfx] [i915] invert_brightness on 8086:0116:103c:1854

2013-10-07 Thread Jani Nikula
On Sat, 05 Oct 2013, Kirill Tkhai wrote: > Hi, > > I've just installed kernel 3.10 on HP 250 G1 and the found option > invert_brightness is required. Hi Kirill, thanks for the report. I suspect invert_brightness is not the right fix, since we've only ever seen that on gen4 Acer based laptops. Ple

Re: [Intel-gfx] [PATCH] drm/dp: Clarify automated test constant and add constant for FAUX test pattern

2013-10-07 Thread Jani Nikula
On Fri, 04 Oct 2013, Todd Previte wrote: > - DP_TEST_LINK_PATTERN is ambiguous, rename to DP_TEST_LINK_VIDEO_PATTERN > to clarify > - Added DP_TEST_LINK_FAUX_PATTERN to support automated testing of Fast AUX > > Signed-off-by: Todd Previte Reviewed-by: Jani Nikula > --- > include/drm/drm

Re: [Intel-gfx] [PATCH 00/12] drm/i915: Some cleanups and fixes to the sprite code v2

2013-10-07 Thread Daniel Vetter
On Fri, Oct 04, 2013 at 11:28:16AM +0100, Chris Wilson wrote: > On Tue, Oct 01, 2013 at 06:02:09PM +0300, ville.syrj...@linux.intel.com wrote: > > Chris asked for some renames and assertions during v1. While adding those I > > noticed that what I did in the original patch 02 didn't match quite so w

Re: [Intel-gfx] [PATCH v3] drm/i915: Fix VGA handling using stop_machine() or mmio

2013-10-07 Thread Chris Wilson
On Wed, Oct 02, 2013 at 04:42:55PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > We have several problems with out VGA handling: > - We try to use the GMCH control VGA disable bit even though it may > be locked > - If we manage to disable VGA throuh GMCH control, we're n

Re: [Intel-gfx] [PATCH v3] drm/i915: Fix VGA handling using stop_machine() or mmio

2013-10-07 Thread Ville Syrjälä
On Mon, Oct 07, 2013 at 10:15:16AM +0100, Chris Wilson wrote: > On Wed, Oct 02, 2013 at 04:42:55PM +0300, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > We have several problems with out VGA handling: > > - We try to use the GMCH control VGA disable bit even though it may >

Re: [Intel-gfx] [PATCH v3] drm/i915: Fix VGA handling using stop_machine() or mmio

2013-10-07 Thread Chris Wilson
On Mon, Oct 07, 2013 at 12:25:03PM +0300, Ville Syrjälä wrote: > On Mon, Oct 07, 2013 at 10:15:16AM +0100, Chris Wilson wrote: > > On Wed, Oct 02, 2013 at 04:42:55PM +0300, ville.syrj...@linux.intel.com > > wrote: > > > From: Ville Syrjälä > > > > > > We have several problems with out VGA handli

Re: [Intel-gfx] [PATCH v3 2/4] ACPI / video: seperate backlight control and event interface

2013-10-07 Thread Rafael J. Wysocki
On Tuesday, September 24, 2013 05:54:53 PM Aaron Lu wrote: > On 09/24/2013 05:47 PM, Aaron Lu wrote: [...] > > diff --git a/include/acpi/video.h b/include/acpi/video.h > > index 61109f2..0c665b5 100644 > > --- a/include/acpi/video.h > > +++ b/include/acpi/video.h > > @@ -19,11 +19,13 @@ struct ac

Re: [Intel-gfx] [i915] invert_brightness on 8086:0116:103c:1854

2013-10-07 Thread Kirill Tkhai
07.10.2013, 11:42, "Jani Nikula" : > On Sat, 05 Oct 2013, Kirill Tkhai wrote: > >>  Hi, >> >>  I've just installed kernel 3.10 on HP 250 G1 and the found option >>  invert_brightness is required. > > Hi Kirill, thanks for the report. I suspect invert_brightness is not the > right fix, since we've

Re: [Intel-gfx] [i915] invert_brightness on 8086:0116:103c:1854

2013-10-07 Thread Kirill Tkhai
07.10.2013, 16:14, "Kirill Tkhai" : > 07.10.2013, 11:42, "Jani Nikula" : > >>  On Sat, 05 Oct 2013, Kirill Tkhai wrote: >>>   Hi, >>> >>>   I've just installed kernel 3.10 on HP 250 G1 and the found option >>>   invert_brightness is required. >>  Hi Kirill, thanks for the report. I suspect inver

Re: [Intel-gfx] [i915] invert_brightness on 8086:0116:103c:1854

2013-10-07 Thread Daniel Vetter
On Mon, Oct 07, 2013 at 05:43:11PM +0400, Kirill Tkhai wrote: > > > 07.10.2013, 16:14, "Kirill Tkhai" : > > 07.10.2013, 11:42, "Jani Nikula" : > > > >>  On Sat, 05 Oct 2013, Kirill Tkhai wrote: > >>>   Hi, > >>> > >>>   I've just installed kernel 3.10 on HP 250 G1 and the found option > >>>   in

Re: [Intel-gfx] [PATCH 1/3] drm/dp: add helper for checking DP_ENHANCED_FRAME_CAP in DPCD

2013-10-07 Thread Alex Deucher
On Fri, Oct 4, 2013 at 8:08 AM, Jani Nikula wrote: > Signed-off-by: Jani Nikula Patches 1 and 2 are: Reviewed-by: Alex Deucher > --- > include/drm/drm_dp_helper.h |7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h > i

Re: [Intel-gfx] [BUG] Crash during startup

2013-10-07 Thread Knut Petersen
On 05.10.2013 00:19, Knut Petersen wrote: Hi everybody! A full Oct-1 build runs fine here, a full Oct-3 builds crashes reliably, see attached log and diff of version list used. hardware: AOpen i915GMm-hfs Oct-7: Current git sources work fine again. cu, Knut

Re: [Intel-gfx] [PATCH] drm/i915: disable LVDS clock gating on CPT v2

2013-10-07 Thread Jesse Barnes
Doesn't completely fix Uli's machine, but apparently it helps a bit, so: Tested-by: Ulrich Drepper On Wed, 2 Oct 2013 10:34:19 -0700 Jesse Barnes wrote: > Needed to prevent display corruption in high res panels. > > v2: use correct unit names (Rodrigo) > > Signed-off-by: Jesse Barnes > --

Re: [Intel-gfx] [PATCH] drm/i915: disable LVDS clock gating on CPT v2

2013-10-07 Thread Rodrigo Vivi
Reviewed-by: Rodrigo Vivi On Mon, Oct 7, 2013 at 1:27 PM, Jesse Barnes wrote: > Doesn't completely fix Uli's machine, but apparently it helps a bit, so: > > Tested-by: Ulrich Drepper > > On Wed, 2 Oct 2013 10:34:19 -0700 > Jesse Barnes wrote: > >> Needed to prevent display corruption in high

Re: [Intel-gfx] [PATCH] drm/i915: disable LVDS clock gating on CPT v2

2013-10-07 Thread Daniel Vetter
On Mon, Oct 07, 2013 at 02:39:22PM -0300, Rodrigo Vivi wrote: > Reviewed-by: Rodrigo Vivi > > On Mon, Oct 7, 2013 at 1:27 PM, Jesse Barnes wrote: > > Doesn't completely fix Uli's machine, but apparently it helps a bit, so: > > > > Tested-by: Ulrich Drepper > > > > On Wed, 2 Oct 2013 10:34:19

[Intel-gfx] [PATCH 0/4] drm-intel-collector - review request

2013-10-07 Thread Rodrigo Vivi
This is another drm-intel-collector push for review: http://cgit.freedesktop.org/~vivijim/drm-intel/log/?h=drm-intel-collector Here goes the list in order for better reviewers assignment: Patch drm/i915: check that the i965g/gm 4G limit is really obeyed - Reviewer: Damien Lespiau Patch

[Intel-gfx] [PATCH 1/4] drm/i915: check that the i965g/gm 4G limit is really obeyed

2013-10-07 Thread Rodrigo Vivi
From: Daniel Vetter In truly crazy circumstances shmem might give us the wrong type of page. So be a bit paranoid and double check this. Reviewer: Damien Lespiau Cc: Rob Clark References: http://lkml.org/lkml/2011/7/11/238 Signed-off-by: Daniel Vetter Signed-off-by: Rodrigo Vivi --- drivers

[Intel-gfx] [PATCH 2/4] drm/i915: Asynchronously perform the set-base for a simple modeset

2013-10-07 Thread Rodrigo Vivi
From: Chris Wilson A simple modeset, where we only wish to switch over to a new framebuffer such as the transition from fbcon to X, takes around 30-60ms. This is due to three factors: 1. We need to make sure the fb->obj is in the display domain, which incurs a cache flush to ensure no dirt is le

[Intel-gfx] [PATCH 3/4] drm/i915: implement another plane WM workaround for HSW

2013-10-07 Thread Rodrigo Vivi
From: Paulo Zanoni In some Haswell machines we're seeing a full system hang while calling haswell_crtc_enable. Ville bisected the problem to the following commit: commit 90a8864320b2a9f91e5b5d561924a4bb70b90dcc Author: Paulo Zanoni Date: Fri May 3 17:23:45 2013 -0300 drm/i9

[Intel-gfx] [PATCH 4/4] drm/i915: Use the real cpu max frequency for ring scaling

2013-10-07 Thread Rodrigo Vivi
From: Ben Widawsky The policy's max frequency is not equal to the CPU's max frequency. The ring frequency is derived from the CPU frequency, and not the policy frequency. One example of how this may differ through sysfs. If the sysfs max frequency is modified, that will be used for the max ring

Re: [Intel-gfx] 3.11-rc7: i915: stuck on render ring

2013-10-07 Thread Julien Cristau
On Thu, Oct 3, 2013 at 22:42:06 +0200, Pavel Machek wrote: > On Wed 2013-09-04 11:08:14, Chris Wilson wrote: > > On Tue, Sep 03, 2013 at 09:06:47PM +0200, Pavel Machek wrote: > > > Hi! > > > > > > I was happily using X... and then screen froze. Mouse still > > > moves. Switching to text console

Re: [Intel-gfx] Broken in 3.10.10 (was: Questions on display pipes on 835GM)

2013-10-07 Thread Thomas Richter
On 06.10.2013 01:37, Daniel Vetter wrote: On Sun, Oct 6, 2013 at 1:09 AM, Thomas Richter wrote: Now if you follow the callchains around the dvo->dpms callbacks the DVO port and DPLL are always enabled at that point in time, so I think we should be able to fix this all by moving the modeset code

Re: [Intel-gfx] i810 only partially usable

2013-10-07 Thread Felix Miata
On 2013-10-04 19:32 (GMT-0400) Felix Miata composed: Valid modes are now being recognized, but PreferredMode is still being ignored, and EDID preferred is inescapable via /etc/X11/xorg.conf*. Linux gx110 3.11.2-1.g420e19b-default #1 SMP Sat Sep 28 16:00:10 UTC 2013 (420e19b) i686 i686 i386 GN

Re: [Intel-gfx] [PATCH 0/4] drm-intel-collector - review request

2013-10-07 Thread Ben Widawsky
On Mon, Oct 07, 2013 at 05:15:44PM -0300, Rodrigo Vivi wrote: > > This is another drm-intel-collector push for review: > http://cgit.freedesktop.org/~vivijim/drm-intel/log/?h=drm-intel-collector > > Here goes the list in order for better reviewers assignment: > > Patch drm/i915: check that t

Re: [Intel-gfx] [PATCH 0/4] drm-intel-collector - review request

2013-10-07 Thread Daniel Vetter
On Mon, Oct 07, 2013 at 09:25:44PM -0700, Ben Widawsky wrote: > On Mon, Oct 07, 2013 at 05:15:44PM -0300, Rodrigo Vivi wrote: > > > > This is another drm-intel-collector push for review: > > http://cgit.freedesktop.org/~vivijim/drm-intel/log/?h=drm-intel-collector > > > > Here goes the list in or

Re: [Intel-gfx] i915 deadlock on laptop undock

2013-10-07 Thread Daniel Vetter
On Mon, Oct 07, 2013 at 03:41:05PM -0700, Roland Dreier wrote: > Hi, > > I have a Lenovo T410s (Ironlake/Arrandale graphics) that I use docked > and connected to an external DP monitor (laptop is closed so the only > active display is the DP monitor). With 3.12-rc4 I reproducably hit a > deadlock

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Use the real cpu max frequency for ring scaling

2013-10-07 Thread Daniel Vetter
On Mon, Oct 07, 2013 at 05:15:48PM -0300, Rodrigo Vivi wrote: > From: Ben Widawsky > > The policy's max frequency is not equal to the CPU's max frequency. The > ring frequency is derived from the CPU frequency, and not the policy > frequency. > > One example of how this may differ through sysfs.

[Intel-gfx] [PATCH v4 1/4] backlight: introduce backlight_device_registered

2013-10-07 Thread Aaron Lu
Introduce a new API for modules to query if a specific type of backlight device has been registered. This is useful for some backlight device provider module(e.g. ACPI video) to know if a native control interface(e.g. the interface created by i915) is available and then do things accordingly(e.g. a

[Intel-gfx] [PATCH v4 0/4] Fix Win8 backlight issue

2013-10-07 Thread Aaron Lu
v4: Remove decleration and stub for acpi_video_unregister_backlight in video.h of patch 2/4 since that function doesn't exist anymore in v3. v3: 1 Add a new patch 4/4 to fix some problems in thinkpad-acpi module; 2 Remove unnecessary function acpi_video_unregister_backlight introduced in patch 2

[Intel-gfx] [PATCH v4 3/4] ACPI / video: Do not register backlight if win8 and native interface exists

2013-10-07 Thread Aaron Lu
According to Matthew Garrett, "Windows 8 leaves backlight control up to individual graphics drivers rather than making ACPI calls itself. There's plenty of evidence to suggest that the Intel driver for Windows [8] doesn't use the ACPI interface, including the fact that it's broken on a bunch of mac

[Intel-gfx] [PATCH v4 2/4] ACPI / video: seperate backlight control and event interface

2013-10-07 Thread Aaron Lu
The backlight control and event delivery functionality provided by ACPI video module is mixed together and registered all during video device enumeration time. As a result, the two functionality are also removed together on module unload time or by the acpi_video_unregister function. The two functi

[Intel-gfx] [PATCH v4 4/4] thinkpad-acpi: fix handle locate for video and query of _BCL

2013-10-07 Thread Aaron Lu
The tpacpi_acpi_handle_locate function makes use of acpi_get_devices to locate handle for ACPI video by HID, the problem is, ACPI video node doesn't really have HID defined(i.e. no _HID control method is defined for video device), so.. that function would fail. This can be solved by enhancing the c