Re: [Intel-gfx] [PATCH 1/3] drm/i915: Extract reading INSTDONE

2012-08-16 Thread Jani Nikula
On Thu, 16 Aug 2012, Ben Widawsky wrote: > INSTDONE is used in many places, and it varies from generation to > generation. This provides a good reason for us to extract the logic to > read the relevant information. > > The patch has no functional change. It's prep for some new stuff. > > Signed-of

[Intel-gfx] [PATCH v8 3/4] drm/i915: Haswell HDMI audio initialization

2012-08-16 Thread Wang Xingchao
Added new haswell_write_eld() to initialize Haswell HDMI audio registers to generate an unsolicited response to the audio controller driver to indicate that the controller sequence should start. Signed-off-by: Wang Xingchao --- drivers/gpu/drm/i915/i915_reg.h |1 + drivers/gpu/drm/i915/

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Use new INSTDONE registers

2012-08-16 Thread Jani Nikula
On Thu, 16 Aug 2012, Ben Widawsky wrote: > Using the extracted INSTDONE reading, and our new register definitions, > update our hangcheck and error collection to use it. Hi Ben, please find some nitpicks below... BR, Jani. > > Signed-off-by: Ben Widawsky > --- > drivers/gpu/drm/i915/i915_debu

Re: [Intel-gfx] [PATCH v8 3/4] drm/i915: Haswell HDMI audio initialization

2012-08-16 Thread Wang, Xingchao
Hi Daniel/Imre, Changelog for v8: - enabled proper output port based on current pipe This version patch works well on my sharkbay machine. This revised version changelog (v7): - add " Wait for 1 vertical blank" after enable audio output port - configure pipe related transcoder instead of oper

Re: [Intel-gfx] black screen if sna & TearFree

2012-08-16 Thread Grant
>> > I'm using a Dell XPS 13 laptop on Gentoo and if I use: >> > >> > Option "AccelMethod" "sna" >> > Option "TearFree" "true" >> > >> > my video tearing problem disappears, but if I close my laptop lid for >> > a few minutes, it comes back up with a black screen, although I can >> > get my session

Re: [Intel-gfx] black screen if sna & TearFree

2012-08-16 Thread Grant
>> > I'm using a Dell XPS 13 laptop on Gentoo and if I use: >> > >> > Option "AccelMethod" "sna" >> > Option "TearFree" "true" >> > >> > my video tearing problem disappears, but if I close my laptop lid for >> > a few minutes, it comes back up with a black screen, although I can >> > get my session

Re: [Intel-gfx] [PATCH] drm/i915: fix hsw uncached pte

2012-08-16 Thread Daniel Vetter
On Tue, Aug 14, 2012 at 11:42:14AM -0300, Paulo Zanoni wrote: > From: Daniel Vetter > > They've changed it ... for no apparent reason. Meh. > > V2: remove unused 'is_hsw' field. > > Signed-off-by: Daniel Vetter > Signed-off-by: Paulo Zanoni Picked up for -fixes, thanks for the patch. -Daniel

[Intel-gfx] [QA 08/16] Testing report for `drm-intel-testing` (was: Updated -next)

2012-08-16 Thread Sun, Yi
Summary We finished a new round of kernel testing. During this round no new bug, and close 6 bugs. Till now, 15 related bugs are still open. Test Environment Kernel: (drm-intel-testing)fa8a0170d1d251a241318e790ab01424f075fd42 Some additional commit info: Merge: 20d5a54 4344b81 Author: Daniel Vet

Re: [Intel-gfx] [PATCH v7 3/4] drm/i915: Haswell HDMI audio initialization

2012-08-16 Thread Imre Deak
On Thu, Aug 16, 2012 at 6:45 AM, Wang Xingchao wrote: > On Wed, Aug 15, 2012 at 08:05:14PM +0300, Imre Deak wrote: >> On Wed, Aug 15, 2012 at 6:27 AM, Wang, Xingchao >> wrote: >> [...] >> >> + I915_WRITE(aud_cntrl_st2, tmp); >> >> + >> >> + /* Wait for 1 vertical blank */ >> >> + int

Re: [Intel-gfx] black screen if sna & TearFree

2012-08-16 Thread Grant
>>> > I'm using a Dell XPS 13 laptop on Gentoo and if I use: >>> > >>> > Option "AccelMethod" "sna" >>> > Option "TearFree" "true" >>> > >>> > my video tearing problem disappears, but if I close my laptop lid for >>> > a few minutes, it comes back up with a black screen, although I can >>> > get my

Re: [Intel-gfx] [PATCH v7 3/4] drm/i915: Haswell HDMI audio initialization

2012-08-16 Thread Wang, Xingchao
> -Original Message- > From: Imre Deak [mailto:imre.d...@gmail.com] > Sent: Thursday, August 16, 2012 6:54 PM > To: Wang, Xingchao > Cc: dan...@ffwll.ch; intel-gfx@lists.freedesktop.org; przan...@gmail.com > Subject: Re: [PATCH v7 3/4] drm/i915: Haswell HDMI audio initialization > > On T

Re: [Intel-gfx] [PATCH v7 3/4] drm/i915: Haswell HDMI audio initialization

2012-08-16 Thread Imre Deak
On Thu, Aug 16, 2012 at 4:23 PM, Wang, Xingchao wrote: > > >> -Original Message- >> From: Imre Deak [mailto:imre.d...@gmail.com] >> Sent: Thursday, August 16, 2012 6:54 PM >> To: Wang, Xingchao >> Cc: dan...@ffwll.ch; intel-gfx@lists.freedesktop.org; przan...@gmail.com >> Subject: Re: [PAT

Re: [Intel-gfx] [PATCH 2/2] drm/i915: fall back to bit-banging if GMBUS fails in CRT EDID reads

2012-08-16 Thread Daniel Vetter
On Mon, Aug 13, 2012 at 01:22:35PM +0300, Jani Nikula wrote: > GMBUS was enabled over bit-banging as the default in commits: > > commit c3dfefa0a6d235bd465309e12f4c56ea16e7 > Author: Daniel Vetter > Date: Tue Feb 14 22:37:25 2012 +0100 > > drm/i915: reenable gmbus on gen3+ again > > a

[Intel-gfx] [PATCH v9 3/4] drm/i915: Haswell HDMI audio initialization

2012-08-16 Thread Wang Xingchao
Added new haswell_write_eld() to initialize Haswell HDMI audio registers to generate an unsolicited response to the audio controller driver to indicate that the controller sequence should start. Reviewed-by: Imre Deak Signed-off-by: Wang Xingchao --- drivers/gpu/drm/i915/i915_reg.h |1

Re: [Intel-gfx] [PATCH v9 3/4] drm/i915: Haswell HDMI audio initialization

2012-08-16 Thread Wang, Xingchao
Hi Daniel, This is the last version of patch 3/4, reviewd by Imre, tested on my sharkbay machine, HDMI audio works well. You can apply it now. :) Thanks --xingchao > -Original Message- > From: Wang, Xingchao > Sent: Thursday, August 16, 2012 10:44 PM > To: imre.d...@gmail.com; dan...@ff

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Extract reading INSTDONE

2012-08-16 Thread Ben Widawsky
On 2012-08-15 23:25, Jani Nikula wrote: On Thu, 16 Aug 2012, Ben Widawsky wrote: INSTDONE is used in many places, and it varies from generation to generation. This provides a good reason for us to extract the logic to read the relevant information. The patch has no functional change. It's pr

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Use new INSTDONE registers

2012-08-16 Thread Ben Widawsky
On Thu, 16 Aug 2012 09:31:51 +0300 Jani Nikula wrote: > On Thu, 16 Aug 2012, Ben Widawsky wrote: > > Using the extracted INSTDONE reading, and our new register definitions, > > update our hangcheck and error collection to use it. > > Hi Ben, please find some nitpicks below... > > BR, > Jani. >

Re: [Intel-gfx] [PATCH v9 3/4] drm/i915: Haswell HDMI audio initialization

2012-08-16 Thread Daniel Vetter
On Thu, Aug 16, 2012 at 02:58:26PM +, Wang, Xingchao wrote: > Hi Daniel, > > This is the last version of patch 3/4, reviewd by Imre, tested on my sharkbay > machine, HDMI audio works well. > You can apply it now. :) Applied, thanks for the patch. -Daniel -- Daniel Vetter Mail: dan...@ffwll.

[Intel-gfx] X.Org Book Sprint 2012 (guide to writing graphics drivers)

2012-08-16 Thread Matt Dew
(Cross post. Yes, I know this is short notice and a short window to reply. My apologies on that.) X.Org Book Sprint 2012 Monday Sept 17 & Tuesday Sept 18. Nürnberg (Nuremberg), Germany. The X.Org Consortium will hold a book sprint on the Monday and Tuesday before the Developers Conference

[Intel-gfx] [PATCH 1/3 v2] drm/i915: Extract reading INSTDONE

2012-08-16 Thread Ben Widawsky
INSTDONE is used in many places, and it varies from generation to generation. This provides a good reason for us to extract the logic to read the relevant information. The patch has no functional change. It's prep for some new stuff. v2: move the memset inside of i915_get_extra_instdone (Jani) C

[Intel-gfx] [PATCH 3/3 v2] drm/i915: Use new INSTDONE registers

2012-08-16 Thread Ben Widawsky
Using the extracted INSTDONE reading, and our new register definitions, update our hangcheck and error collection to use it. v2: Now assuming i915_get_extra_instdone does the memset we can clean up the code a bit (Jani) I ignored some of Jani's bikesheds as I didn't see any value to the modificat