[Intel-gfx] assertion on intel_disable_transcoder

2012-08-07 Thread Wang, Xingchao
Hi Daniel/Paulo, It's easy to see such WARNING in dmesg, the DDI port is not disabled prior to disable transcoder. I am not sure it will impact the Pipe/transcoder/DDI-port configurations, anyway after some times WARNING, I could not make HDMI audio work anymore. With intel_audio_dump I could se

[Intel-gfx] [PATCH] drm/i915: correctly order the ring init sequence

2012-08-07 Thread Daniel Vetter
We may only start to set up the new register values after having confirmed that the ring is truely off. Otherwise the hw might lose the newly written register values. This is caught later on in the init sequence, when we check whether the register writes have stuck. Cc: sta...@vger.kernel.org Bugz

Re: [Intel-gfx] Fwd: Re: Macbook Pro Retina display problems

2012-08-07 Thread Francois Rigaut
Daniel, nope, the hack didn't succeed. No apparent change. Francois On Tue 07 Aug 2012 05:31:25 EST, Daniel Vetter wrote: On Mon, Aug 06, 2012 at 11:40:36PM +1000, Francois Rigaut wrote: Daniel, On Mon, Aug 6, 2012 at 7:17 PM, Daniel Vetter mailto:dan...@ffwll.ch>> wrote: On Mon, Aug 6,

[Intel-gfx] [PATCH 0/2] Haswell intel_audio_dump support

2012-08-07 Thread Wang Xingchao
This patch enabled intel_audio_dump to support Haswell platform. Haswell has some registers differences comprared with previous platforms. Changes since V1: - fix compile warnings - remove HBR bits show, it doesnot exist under Haswell Wang Xingchao (2): intel_audio_dump: fix wrong port definit

[Intel-gfx] [PATCH V2 1/2] intel_audio_dump: fix wrong port definition

2012-08-07 Thread Wang Xingchao
There're three Ports B/C/D used for selection by each transcoder A/B/C. Signed-off-by: Wang Xingchao --- tools/intel_audio_dump.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/intel_audio_dump.c b/tools/intel_audio_dump.c index 077e096..8a0f6ee 100644 --- a/t

[Intel-gfx] [PATCH V2 2/2] intel_audio_dump: add Haswell audio dump support

2012-08-07 Thread Wang Xingchao
Add Haswell audio registers definition and dump support. Signed-off-by: Wang Xingchao --- tools/intel_audio_dump.c | 582 ++ 1 file changed, 582 insertions(+) diff --git a/tools/intel_audio_dump.c b/tools/intel_audio_dump.c index 8a0f6ee..5ee9372 100

Re: [Intel-gfx] [PATCH ddx] Add Haswell PCI IDs

2012-08-07 Thread Chris Wilson
On Mon, 6 Aug 2012 19:20:29 -0300, Rodrigo Vivi wrote: > Reviewed-by: Rodrigo Vivi Thanks for the patch and the careful review, pushed. -Chris -- Chris Wilson, Intel Open Source Technology Centre ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop

Re: [Intel-gfx] [PATCH kernel] drm/i915: add more Haswell PCI IDs

2012-08-07 Thread Daniel Vetter
On Mon, Aug 06, 2012 at 07:17:24PM -0300, Rodrigo Vivi wrote: > Reviewed-by: Rodrigo Vivi Thanks for review and patch, applied to -fixes. -Daniel -- Daniel Vetter Mail: dan...@ffwll.ch Mobile: +41 (0)79 365 57 48 ___ Intel-gfx mailing list Intel-gfx@lis

[Intel-gfx] [pull] drm-intel-fixes

2012-08-07 Thread Daniel Vetter
Hi Dave, - Regression fixer for an OOPS at boot when i915.ko is built-in and CONFIG_PM=n, introduce in 3.5 (patch from Hunt Xu) - Regression fixer for occlusion query failures, the required w/a wasn't applied in all cases (thanks to Eric for tracking this on down). - dmar vs. dma_buf imprt fix

Re: [Intel-gfx] [PATCH] drm/i915: correctly order the ring init sequence

2012-08-07 Thread Jani Nikula
On Tue, 07 Aug 2012, Daniel Vetter wrote: > We may only start to set up the new register values after having > confirmed that the ring is truely off. Otherwise the hw might lose the > newly written register values. This is caught later on in the init > sequence, when we check whether the register

Re: [Intel-gfx] [PATCH] drm/i915: correctly order the ring init sequence

2012-08-07 Thread Daniel Vetter
On Tue, Aug 07, 2012 at 03:32:42PM +0300, Jani Nikula wrote: > On Tue, 07 Aug 2012, Daniel Vetter wrote: > > We may only start to set up the new register values after having > > confirmed that the ring is truely off. Otherwise the hw might lose the > > newly written register values. This is caught

Re: [Intel-gfx] [PATCH] drm/i915: correctly order the ring init sequence

2012-08-07 Thread Jani Nikula
On Tue, 07 Aug 2012, Jani Nikula wrote: > On Tue, 07 Aug 2012, Daniel Vetter wrote: >> We may only start to set up the new register values after having >> confirmed that the ring is truely off. Otherwise the hw might lose the >> newly written register values. This is caught later on in the init >

Re: [Intel-gfx] intel_ddi.c

2012-08-07 Thread Paulo Zanoni
2012/8/6 ron minnich : > As I read this new (to me) file I get the impression that it really > applies to haswell and not the earlier parts, is that correct? Yes :) If you're running code from this file on older gens, please report the problem. > > thanks > > ron > _

Re: [Intel-gfx] Fwd: Re: Macbook Pro Retina display problems

2012-08-07 Thread Daniel Vetter
On Tue, Aug 07, 2012 at 06:08:51PM +1000, Francois Rigaut wrote: > Daniel, > > nope, the hack didn't succeed. No apparent change. Ok, I've updated the reg_dumper to also dump the registers for pipe C. Can you please update your intel-gpu-tools checkout and then grab a new register dump for both i

Re: [Intel-gfx] [PATCH v4 1/3] drm/i915: HSW audio registers definition

2012-08-07 Thread Paulo Zanoni
Hi Comments inline: 2012/8/6 Wang Xingchao : > Add hsw audio registers definition > > Signed-off-by: Wang Xingchao > --- > drivers/gpu/drm/i915/i915_reg.h | 48 > +++ > 1 file changed, 48 insertions(+) > > diff --git a/drivers/gpu/drm/i915/i915_reg.h b/dri

Re: [Intel-gfx] [PATCH v4 3/3] drm/i915: Haswell HDMI audio enable

2012-08-07 Thread Paulo Zanoni
Hi 2012/8/6 Wang Xingchao : > Configure the related HDMI audio register to generate an unsolicited > response to the audio controller driver to indicate that the controller > sequence should start. > > Use "pipe" way to get correct register definitions for IBX/CPT/HSW. Please split this patch in

Re: [Intel-gfx] Fwd: Re: Macbook Pro Retina display problems

2012-08-07 Thread Francois Rigaut
Daniel, ok, updated intel-gpu-tools and dumped the various config. Unfortunately, X froze when I tried the to switch to pipe C (--crtc 2). I have three dumps with the various config: http://maumae.net/retina/intel_corrupted_drm_debug/ird_inteldie << that's with i915.die=1 http://maumae.net/

Re: [Intel-gfx] [PATCH ddx] Add Haswell PCI IDs

2012-08-07 Thread Guo, Chaohong
Why using "xxx_SDV_xxx" in the macros ? Is there an official Name for those chips ?Besides, what does "CRW" stands For ? Thanks, -minskey -Original Message- From: intel-gfx-bounces+chaohong.guo=intel@lists.freedesktop.org [mailto:intel-gfx-bounces+chaohong.guo=intel@lists.f

Re: [Intel-gfx] Fwd: Re: Macbook Pro Retina display problems

2012-08-07 Thread Daniel Vetter
On Wed, Aug 08, 2012 at 12:17:50AM +1000, Francois Rigaut wrote: > Daniel, > > ok, updated intel-gpu-tools and dumped the various config. > Unfortunately, X froze when I tried the to switch to pipe C (--crtc > 2). I have three dumps with the various config: > > http://maumae.net/retina/intel_corr

Re: [Intel-gfx] [Mesa-dev] [PATCH mesa] i965: add more Haswell PCI IDs

2012-08-07 Thread Paulo Zanoni
2012/8/6 Kenneth Graunke : > On 08/06/2012 02:50 PM, Paulo Zanoni wrote: >> From: Paulo Zanoni >> >> Signed-off-by: Paulo Zanoni > > Reviewed-by: Kenneth Graunke > > Do you have push access? If not, I can commit this for you. I just discovered I have. Patch committed, thanks. -- Paulo Zanon

Re: [Intel-gfx] Fwd: Re: Macbook Pro Retina display problems

2012-08-07 Thread Daniel Vetter
On Wed, Aug 08, 2012 at 12:17:50AM +1000, Francois Rigaut wrote: > Daniel, > > ok, updated intel-gpu-tools and dumped the various config. > Unfortunately, X froze when I tried the to switch to pipe C (--crtc > 2). I have three dumps with the various config: > > http://maumae.net/retina/intel_corr

Re: [Intel-gfx] [PATCH] drm/i915: make forcewake work again

2012-08-07 Thread Ben Widawsky
On Mon, 6 Aug 2012 12:31:31 -0700 Ben Widawsky wrote: > While trying to track down the power regression, I noticed that on my > SNB I had more severe problems, ie. forcewake seemed to never happen > once i915 was loaded. After a bit of bisection, I tracked the bad commit > to: > > commit 7b0cfe

[Intel-gfx] HD audio not working

2012-08-07 Thread Øyvind Kvålsvoll
Ref. to filed bug https://bugs.freedesktop.org/show_bug.cgi?id=49055: DTS-HD and Dolby TrueHD audio is not working in Intel Sandy Bridge. This must have been well known for quite some time now, and I consider this to be a serious error in the Intel driver. Due to this error it is not possible to

Re: [Intel-gfx] [pull] drm-intel-fixes

2012-08-07 Thread Ben Widawsky
On 2012-08-07 05:08, Daniel Vetter wrote: Hi Dave, - Regression fixer for an OOPS at boot when i915.ko is built-in and CONFIG_PM=n, introduce in 3.5 (patch from Hunt Xu) - Regression fixer for occlusion query failures, the required w/a wasn't applied in all cases (thanks to Eric for tracki

[Intel-gfx] [PATCH v5 0/4] Haswell HDMI/DP audio enable

2012-08-07 Thread Wang Xingchao
This patch series enable HDMI audio on Haswell platform, not DP audio. The DP enablement will come after the DP patches are upstream. I tested this patch on Sharkbay machine and i could hear clear sound from HDMI port. V2 patches fixed one warning and some type errors. V3 patches changes: - chan

[Intel-gfx] [PATCH v5 0/4] Haswell HDMI/DP audio enable

2012-08-07 Thread Wang Xingchao
This patch series enable HDMI audio on Haswell platform, not DP audio. The DP enablement will come after the DP patches are upstream. I tested this patch on Sharkbay machine and i could hear clear sound from HDMI port. V2 patches fixed one warning and some type errors. V3 patches changes: - chan

[Intel-gfx] [PATCH v5 1/4] drm/i915: HSW audio registers definition

2012-08-07 Thread Wang Xingchao
Add hsw audio registers definition Signed-off-by: Wang Xingchao --- drivers/gpu/drm/i915/i915_reg.h | 47 +++ 1 file changed, 47 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index 1310caa..0cf09ad 100644 --- a

[Intel-gfx] [PATCH v5 2/4] drm/i915: write eld info for HDMI audio

2012-08-07 Thread Wang Xingchao
HDMI audio related registers will be configured in write_eld callback. Signed-off-by: Wang Xingchao --- drivers/gpu/drm/i915/intel_ddi.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c index 32604ac..

[Intel-gfx] [PATCH v5 3/4] drm/i915: Haswell HDMI audio enable

2012-08-07 Thread Wang Xingchao
Initialize Haswell HDMI audio registers to generate an unsolicited response to the audio controller driver to indicate that the controller sequence should start. Signed-off-by: Wang Xingchao --- drivers/gpu/drm/i915/intel_display.c | 37 ++ 1 file changed, 37 in

[Intel-gfx] [PATCH v5 4/4] drm/i915: use _PIPE macro for IBX/CPT register definition

2012-08-07 Thread Wang Xingchao
Use _PIPE macro to get correct register definition for IBX/CPT, discard old variable "i" way. Signed-off-by: Wang Xingchao --- drivers/gpu/drm/i915/i915_reg.h | 24 drivers/gpu/drm/i915/intel_display.c | 17 ++--- 2 files changed, 30 insertions(+), 1