Re: [Intel-gfx] [PATCH 2/3] drm/i915: Remove HAS_BLT/HAS_BSD checks from ivybridge_irq_postinstall.

2011-06-08 Thread Chris Wilson
On Tue, 7 Jun 2011 15:54:40 -0700, Kenneth Graunke wrote: > Ivybridge has BLT and BSD rings, so there's no need to check. Right, I've been trying to move this code into the ring init... -Chris -- Chris Wilson, Intel Open Source Technology Centre ___

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Fix MI_DISPLAY_FLIP plane select offset on Ivybridge.

2011-06-08 Thread Chris Wilson
On Tue, 07 Jun 2011 17:55:05 -0700, Kenneth Graunke wrote: > On 06/07/2011 04:14 PM, Keith Packard wrote: > > What's this last DWORD supposed to be for? The IVB spec says length > > should be '1' and there should be only 3 DWORDS in this command. > > Good question. My reading of the docs say th

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Fix MI_DISPLAY_FLIP plane select offset on Ivybridge.

2011-06-08 Thread Kenneth Graunke
On 06/08/2011 02:36 AM, Chris Wilson wrote: On Tue, 07 Jun 2011 17:55:05 -0700, Kenneth Graunke wrote: On 06/07/2011 04:14 PM, Keith Packard wrote: What's this last DWORD supposed to be for? The IVB spec says length should be '1' and there should be only 3 DWORDS in this command. Good quest

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Fix MI_DISPLAY_FLIP plane select offset on Ivybridge.

2011-06-08 Thread Chris Wilson
On Wed, 08 Jun 2011 02:54:36 -0700, Kenneth Graunke wrote: > IVB does only use three DWords, so the last OUT_RING should be nixed. > Removing that does change the behavior, but doesn't yet make it work. Note you can't just drop it since we need to keep the quadword alignment, so shrink the comm

Re: [Intel-gfx] [PATCH 00/16] Move chipset specific stuff to struct intel_chipset

2011-06-08 Thread Kenneth Graunke
On 06/07/2011 12:34 PM, Kristian Høgsberg wrote: Hi, Here's a handful of patches that try to replace most of our chipset feature checking with data in a new struct intel_chipset. It uses the new PCI ID list infrastructure and eliminates all IS_FOO macros in favor of a per-family chipset info st

Re: [Intel-gfx] [PATCH 00/16] Move chipset specific stuff to struct intel_chipset

2011-06-08 Thread Kristian Høgsberg
2011/6/8 Kenneth Graunke : > On 06/07/2011 12:34 PM, Kristian Høgsberg wrote: >> >> Hi, >> >> Here's a handful of patches that try to replace most of our chipset >> feature checking with data in a new struct intel_chipset.  It uses the >> new PCI ID list infrastructure and eliminates all IS_FOO mac

Re: [Intel-gfx] [PATCH 1/4] drm: add plane support

2011-06-08 Thread Jesse Barnes
On Wed, 8 Jun 2011 11:41:17 +0200 Marcus Lorentzon wrote: > On 06/07/2011 11:01 PM, Jesse Barnes wrote: > > On Tue, 7 Jun 2011 13:07:39 -0700 > > Jesse Barnes wrote: > > > > > >> +/* Planes blend with or override other bits on the CRTC */ > >> +struct drm_mode_set_plane { > >> + __u32 plan