Re: Re: Re: Re: Re: [PATCH v2] treewide: const qualify ctl_tables where applicable

2025-01-29 Thread Joel Granados
On Tue, Jan 28, 2025 at 10:43:10AM -0500, Paul Moore wrote: > On Tue, Jan 28, 2025 at 6:22 AM Joel Granados > wrote: > > On Mon, Jan 27, 2025 at 03:42:39PM +, Matthew Wilcox wrote: > > > On Mon, Jan 27, 2025 at 04:55:58PM +0200, Jani Nikula wrote: > > > > You could have static const within fu

Re: Re: Re: Re: [PATCH v2] treewide: const qualify ctl_tables where applicable

2025-01-28 Thread Paul Moore
On Tue, Jan 28, 2025 at 6:22 AM Joel Granados wrote: > On Mon, Jan 27, 2025 at 03:42:39PM +, Matthew Wilcox wrote: > > On Mon, Jan 27, 2025 at 04:55:58PM +0200, Jani Nikula wrote: > > > You could have static const within functions too. You get the rodata > > > protection and function local sco

Re: Re: Re: Re: [PATCH v2] treewide: const qualify ctl_tables where applicable

2025-01-28 Thread Joel Granados
On Mon, Jan 27, 2025 at 03:42:39PM +, Matthew Wilcox wrote: > On Mon, Jan 27, 2025 at 04:55:58PM +0200, Jani Nikula wrote: > > You could have static const within functions too. You get the rodata > > protection and function local scope, best of both worlds? > > timer_active is on the stack, so