Re: [Intel-gfx] [PATCH 7/8] drm/i915: create pipe_config->dpll for clock state

2013-04-03 Thread Daniel Vetter
On Tue, Apr 02, 2013 at 02:14:23PM -0700, Jesse Barnes wrote: > This one's hard to review since you mixed in a drm_crtc->intel_crtc > function arg change. > > I'd rather have that split out, but it looks ok. Yeah, I've fumbled this one a bit, but decided to punt on the split-up. Generally I'm al

Re: [Intel-gfx] [PATCH 7/8] drm/i915: create pipe_config->dpll for clock state

2013-04-02 Thread Jesse Barnes
On Thu, 28 Mar 2013 10:42:02 +0100 Daniel Vetter wrote: > Clock computations and handling are highly encoder specific, both in > the optimal clock selection and also in which clocks to use and when > sharing of clocks is possible. > > So the best place to do this is somewhere in the encoders, wi