Re: [Intel-gfx] [PATCH 3/3] drm/i915: Preallocate mm node for GTT mmap offset

2012-12-19 Thread Chris Wilson
On Wed, 19 Dec 2012 08:10:24 +1000, Dave Airlie wrote: > > As the shrinker may be invoked for the allocation, and it may reap > > neighbouring objects in the offset range mm, we need to be careful in > > the order in which we allocate the node, search for free space and then > > insert the node in

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Preallocate mm node for GTT mmap offset

2012-12-18 Thread Daniel Vetter
On Tue, Dec 18, 2012 at 10:11:14PM +0100, Daniel Vetter wrote: > On Wed, Dec 12, 2012 at 10:55:17AM +, Chris Wilson wrote: > > On Wed, 12 Dec 2012 12:48:43 +0200, Jani Nikula > > wrote: > > > On Fri, 07 Dec 2012, Chris Wilson wrote: > > > > As the shrinker may be invoked for the allocation,

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Preallocate mm node for GTT mmap offset

2012-12-18 Thread Dave Airlie
> As the shrinker may be invoked for the allocation, and it may reap > neighbouring objects in the offset range mm, we need to be careful in > the order in which we allocate the node, search for free space and then > insert the node into the mmap offset range manager. Maybe I'm being a bit stupid

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Preallocate mm node for GTT mmap offset

2012-12-18 Thread Daniel Vetter
On Wed, Dec 12, 2012 at 10:55:17AM +, Chris Wilson wrote: > On Wed, 12 Dec 2012 12:48:43 +0200, Jani Nikula > wrote: > > On Fri, 07 Dec 2012, Chris Wilson wrote: > > > As the shrinker may be invoked for the allocation, and it may reap > > > neighbouring objects in the offset range mm, we nee

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Preallocate mm node for GTT mmap offset

2012-12-12 Thread Chris Wilson
On Wed, 12 Dec 2012 12:48:43 +0200, Jani Nikula wrote: > On Fri, 07 Dec 2012, Chris Wilson wrote: > > As the shrinker may be invoked for the allocation, and it may reap > > neighbouring objects in the offset range mm, we need to be careful in > > the order in which we allocate the node, search f

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Preallocate mm node for GTT mmap offset

2012-12-12 Thread Jani Nikula
On Fri, 07 Dec 2012, Chris Wilson wrote: > As the shrinker may be invoked for the allocation, and it may reap > neighbouring objects in the offset range mm, we need to be careful in > the order in which we allocate the node, search for free space and then > insert the node into the mmap offset ran