Re: [Intel-gfx] [PATCH 1/2] hda - fix ELD memory leak

2011-11-15 Thread Wu Fengguang
On Tue, Nov 15, 2011 at 10:45:15PM +0800, Takashi Iwai wrote: > At Tue, 15 Nov 2011 22:41:16 +0800, > Wu Fengguang wrote: > > > > On Tue, Nov 15, 2011 at 10:35:41PM +0800, Takashi Iwai wrote: > > > At Tue, 15 Nov 2011 22:31:55 +0800, > > > Wu Fengguang wrote: > > > > > > > > memset(eld) clears el

Re: [Intel-gfx] [PATCH 1/2] hda - fix ELD memory leak

2011-11-15 Thread Takashi Iwai
At Tue, 15 Nov 2011 22:41:16 +0800, Wu Fengguang wrote: > > On Tue, Nov 15, 2011 at 10:35:41PM +0800, Takashi Iwai wrote: > > At Tue, 15 Nov 2011 22:31:55 +0800, > > Wu Fengguang wrote: > > > > > > memset(eld) clears eld->proc_entry which will leak the struct > > > snd_info_entry when unloading t

Re: [Intel-gfx] [PATCH 1/2] hda - fix ELD memory leak

2011-11-15 Thread Wu Fengguang
On Tue, Nov 15, 2011 at 10:35:41PM +0800, Takashi Iwai wrote: > At Tue, 15 Nov 2011 22:31:55 +0800, > Wu Fengguang wrote: > > > > memset(eld) clears eld->proc_entry which will leak the struct > > snd_info_entry when unloading the module. > > > > Fix it by > > - remove memset(eld) > > - set eld->e

Re: [Intel-gfx] [PATCH 1/2] hda - fix ELD memory leak

2011-11-15 Thread Takashi Iwai
At Tue, 15 Nov 2011 22:31:55 +0800, Wu Fengguang wrote: > > memset(eld) clears eld->proc_entry which will leak the struct > snd_info_entry when unloading the module. > > Fix it by > - remove memset(eld) > - set eld->eld_valid to true _after_ all eld fields have been filled > - don't access the ot