Re: [Intel-gfx] [PATCH] rpm

2014-09-10 Thread Chris Wilson
On Wed, Sep 10, 2014 at 08:15:47PM +0300, Ville Syrjälä wrote: > On Wed, Sep 10, 2014 at 05:43:15PM +0100, Chris Wilson wrote: > > static void gen6_force_wake_timer(unsigned long arg) > > Looks like you forgot to kill the rpm_put() from the timer. And then we > also need to make sure the timer is

Re: [Intel-gfx] [PATCH] rpm

2014-09-10 Thread Ville Syrjälä
On Wed, Sep 10, 2014 at 05:43:15PM +0100, Chris Wilson wrote: > --- > drivers/gpu/drm/i915/i915_debugfs.c | 2 ++ > drivers/gpu/drm/i915/intel_display.c | 20 ++ > drivers/gpu/drm/i915/intel_lrc.c | 21 ++- > drivers/gpu/drm/i915/intel_uncore.c | 52 > ++

Re: [Intel-gfx] [PATCH] rpm

2014-09-10 Thread Ville Syrjälä
On Wed, Sep 10, 2014 at 01:57:16PM -0300, Paulo Zanoni wrote: > 2014-09-10 13:43 GMT-03:00 Chris Wilson : > > --- > > drivers/gpu/drm/i915/i915_debugfs.c | 2 ++ > > drivers/gpu/drm/i915/intel_display.c | 20 ++ > > drivers/gpu/drm/i915/intel_lrc.c | 21 ++- > > drive

Re: [Intel-gfx] [PATCH] rpm

2014-09-10 Thread Chris Wilson
On Wed, Sep 10, 2014 at 01:57:16PM -0300, Paulo Zanoni wrote: > 2014-09-10 13:43 GMT-03:00 Chris Wilson : > > --- > > drivers/gpu/drm/i915/i915_debugfs.c | 2 ++ > > drivers/gpu/drm/i915/intel_display.c | 20 ++ > > drivers/gpu/drm/i915/intel_lrc.c | 21 ++- > > drive

Re: [Intel-gfx] [PATCH] rpm

2014-09-10 Thread Paulo Zanoni
2014-09-10 13:43 GMT-03:00 Chris Wilson : > --- > drivers/gpu/drm/i915/i915_debugfs.c | 2 ++ > drivers/gpu/drm/i915/intel_display.c | 20 ++ > drivers/gpu/drm/i915/intel_lrc.c | 21 ++- > drivers/gpu/drm/i915/intel_uncore.c | 52 > +++---