Re: [Intel-gfx] [PATCH] drm/i915: Use __is_constexpr()

2019-03-21 Thread Chris Wilson
Quoting Jani Nikula (2019-03-21 09:50:25) > On Wed, 20 Mar 2019, Chris Wilson wrote: > > gcc-4.8 and older dislike the use of __builtin_constant_p() within a > > constant expression context, and so we must use the magical > > __is_constexpr() instead. > > > > For example, with gcc-4.8.5: > > ../dr

Re: [Intel-gfx] [PATCH] drm/i915: Use __is_constexpr()

2019-03-21 Thread Jani Nikula
On Wed, 20 Mar 2019, Chris Wilson wrote: > gcc-4.8 and older dislike the use of __builtin_constant_p() within a > constant expression context, and so we must use the magical > __is_constexpr() instead. > > For example, with gcc-4.8.5: > ../drivers/gpu/drm/i915/i915_reg.h:167:27: error: first argum

Re: [Intel-gfx] [PATCH] drm/i915: Use __is_constexpr()

2019-03-20 Thread Randy Dunlap
On 3/20/19 8:40 AM, Chris Wilson wrote: > gcc-4.8 and older dislike the use of __builtin_constant_p() within a > constant expression context, and so we must use the magical > __is_constexpr() instead. > > For example, with gcc-4.8.5: > ../drivers/gpu/drm/i915/i915_reg.h:167:27: error: first argume