Re: [Intel-gfx] [PATCH] Antigcc bitfield bikeshed

2015-06-25 Thread Jesse Barnes
On 06/25/2015 12:33 AM, Daniel Vetter wrote: >> In the specific case of bitfields it seems like it would be sufficient >> > to mark the local variables as volatile? Or maybe just use open coded >> > compiler barrier() functions instead, with accompanying documentation. >> > >> > Documentation/mem

Re: [Intel-gfx] [PATCH] Antigcc bitfield bikeshed

2015-06-25 Thread Daniel Vetter
On Wed, Jun 24, 2015 at 03:56:15PM -0700, Jesse Barnes wrote: > On 06/22/2015 11:53 PM, Daniel Vetter wrote: > > On Mon, Jun 22, 2015 at 02:19:51PM -0700, Jesse Barnes wrote: > >> On 06/17/2015 08:10 AM, Daniel Vetter wrote: > >>> On Wed, Jun 17, 2015 at 05:28:20PM +0300, Jani Nikula wrote: >

Re: [Intel-gfx] [PATCH] Antigcc bitfield bikeshed

2015-06-24 Thread Jesse Barnes
On 06/22/2015 11:53 PM, Daniel Vetter wrote: > On Mon, Jun 22, 2015 at 02:19:51PM -0700, Jesse Barnes wrote: >> On 06/17/2015 08:10 AM, Daniel Vetter wrote: >>> On Wed, Jun 17, 2015 at 05:28:20PM +0300, Jani Nikula wrote: On Wed, 17 Jun 2015, Chris Wilson wrote: > Here's an idea I want to

Re: [Intel-gfx] [PATCH] Antigcc bitfield bikeshed

2015-06-22 Thread Daniel Vetter
On Mon, Jun 22, 2015 at 02:19:51PM -0700, Jesse Barnes wrote: > On 06/17/2015 08:10 AM, Daniel Vetter wrote: > > On Wed, Jun 17, 2015 at 05:28:20PM +0300, Jani Nikula wrote: > >> On Wed, 17 Jun 2015, Chris Wilson wrote: > >>> Here's an idea I want to float to see if anyone has a better idea. > >>

Re: [Intel-gfx] [PATCH] Antigcc bitfield bikeshed

2015-06-22 Thread Jesse Barnes
On 06/17/2015 08:10 AM, Daniel Vetter wrote: > On Wed, Jun 17, 2015 at 05:28:20PM +0300, Jani Nikula wrote: >> On Wed, 17 Jun 2015, Chris Wilson wrote: >>> Here's an idea I want to float to see if anyone has a better idea. >> >> I'll give it some thought, but it pains me that things like this make

Re: [Intel-gfx] [PATCH] Antigcc bitfield bikeshed

2015-06-17 Thread Daniel Vetter
On Wed, Jun 17, 2015 at 05:28:20PM +0300, Jani Nikula wrote: > On Wed, 17 Jun 2015, Chris Wilson wrote: > > Here's an idea I want to float to see if anyone has a better idea. > > I'll give it some thought, but it pains me that things like this make it > harder for source code cross referencers an

Re: [Intel-gfx] [PATCH] Antigcc bitfield bikeshed

2015-06-17 Thread Jani Nikula
On Wed, 17 Jun 2015, Chris Wilson wrote: > Here's an idea I want to float to see if anyone has a better idea. I'll give it some thought, but it pains me that things like this make it harder for source code cross referencers and even grep to find what you you're looking for. BR, Jani. > Daniel