RE: [PATCH v3 1/2] drm/i915/xe3lpd: Power request asserting/deasserting

2024-11-01 Thread Kahola, Mika
> -Original Message- > From: Jadav, Raag > Sent: Thursday, 31 October 2024 17.13 > To: Kahola, Mika > Cc: intel-gfx@lists.freedesktop.org; Sousa, Gustavo ; > jani.nik...@linux.intel.com > Subject: Re: [PATCH v3 1/2] drm/i915/xe3lpd: Power request > asserting/deas

RE: [PATCH v3 1/2] drm/i915/xe3lpd: Power request asserting/deasserting

2024-10-31 Thread Kahola, Mika
> -Original Message- > From: Jadav, Raag > Sent: Thursday, 31 October 2024 14.55 > To: Kahola, Mika > Cc: intel-gfx@lists.freedesktop.org; Sousa, Gustavo ; > jani.nik...@linux.intel.com > Subject: Re: [PATCH v3 1/2] drm/i915/xe3lpd: Power request > asserting/deas

Re: [PATCH v3 1/2] drm/i915/xe3lpd: Power request asserting/deasserting

2024-10-31 Thread Raag Jadav
On Thu, Oct 31, 2024 at 04:50:20PM +0200, Raag Jadav wrote: > On Thu, Oct 31, 2024 at 07:59:16PM +0530, Kahola, Mika wrote: > > ... > > > > > +static void wa_14020908590(struct intel_display *display, > > > > + bool enable) > > > > > > Can be one line? > > > > Could be.

Re: [PATCH v3 1/2] drm/i915/xe3lpd: Power request asserting/deasserting

2024-10-31 Thread Raag Jadav
On Thu, Oct 31, 2024 at 07:59:16PM +0530, Kahola, Mika wrote: ... > > > +static void wa_14020908590(struct intel_display *display, > > > +bool enable) > > > > Can be one line? > > Could be. This should fit within expected line length. With that, Reviewed-by: Raag Jadav

Re: [PATCH v3 1/2] drm/i915/xe3lpd: Power request asserting/deasserting

2024-10-31 Thread Raag Jadav
On Thu, Oct 31, 2024 at 01:40:26PM +0200, Mika Kahola wrote: > There is a HW issue that arises when there are race conditions > between TCSS entering/exiting TC7 or TC10 states while the > driver is asserting/deasserting TCSS power request. As a > workaround, Display driver will implement a mailbox