RE: [PATCH v12 2/8] drm: Add Adaptive Sync SDP logging

2024-02-29 Thread Golani, Mitulkumar Ajitkumar
> On Thu, 29 Feb 2024, "Golani, Mitulkumar Ajitkumar" > wrote: > > Thought behind this was to use the function where it was defined. But > > no worries, I have split it with new patch series floated. > > Please do not rush to send so many new versions! Let the review come to a > conclusion first.

RE: [PATCH v12 2/8] drm: Add Adaptive Sync SDP logging

2024-02-29 Thread Jani Nikula
On Thu, 29 Feb 2024, "Golani, Mitulkumar Ajitkumar" wrote: > Thought behind this was to use the function where it was defined. But > no worries, I have split it with new patch series floated. Please do not rush to send so many new versions! Let the review come to a conclusion first. BR, Jani.

RE: [PATCH v12 2/8] drm: Add Adaptive Sync SDP logging

2024-02-29 Thread Golani, Mitulkumar Ajitkumar
> -Original Message- > From: Nikula, Jani > Sent: Thursday, February 29, 2024 4:08 PM > To: Golani, Mitulkumar Ajitkumar ; > intel-gfx@lists.freedesktop.org > Cc: dri-de...@lists.freedesktop.org; Nautiyal, Ankit K > ; Golani, Mitulkumar Ajitkumar > > Subje

Re: [PATCH v12 2/8] drm: Add Adaptive Sync SDP logging

2024-02-29 Thread Nautiyal, Ankit K
On 2/29/2024 4:53 PM, Jani Nikula wrote: On Thu, 29 Feb 2024, "Nautiyal, Ankit K" wrote: On 2/28/2024 8:08 PM, Mitul Golani wrote: +enum operation_mode { + DP_AS_SDP_AVT_DYNAMIC_VTOTAL = 0x00, + DP_AS_SDP_AVT_FIXED_VTOTAL = 0x01, + DP_AS_SDP_FAVT_TRR_NOT_REACHED = 0x02, +

Re: [PATCH v12 2/8] drm: Add Adaptive Sync SDP logging

2024-02-29 Thread Jani Nikula
On Thu, 29 Feb 2024, "Nautiyal, Ankit K" wrote: > On 2/28/2024 8:08 PM, Mitul Golani wrote: >> +enum operation_mode { >> +DP_AS_SDP_AVT_DYNAMIC_VTOTAL = 0x00, >> +DP_AS_SDP_AVT_FIXED_VTOTAL = 0x01, >> +DP_AS_SDP_FAVT_TRR_NOT_REACHED = 0x02, >> +DP_AS_SDP_FAVT_TRR_REACHED = 0x03 >>

Re: [PATCH v12 2/8] drm: Add Adaptive Sync SDP logging

2024-02-29 Thread Jani Nikula
On Wed, 28 Feb 2024, Mitul Golani wrote: > Add structure representing Adaptive Sync Secondary Data Packet (AS SDP). > Also, add Adaptive Sync SDP logging in drm_dp_helper.c to facilitate > debugging. To be honest, the division of patches is a bit weird. There's no reason to change i915 here, is t

Re: [PATCH v12 2/8] drm: Add Adaptive Sync SDP logging

2024-02-29 Thread Nautiyal, Ankit K
On 2/28/2024 8:08 PM, Mitul Golani wrote: Add structure representing Adaptive Sync Secondary Data Packet (AS SDP). Also, add Adaptive Sync SDP logging in drm_dp_helper.c to facilitate debugging. --v2: - Update logging. [Jani, Ankit] - Use 'as_sdp' instead of 'async' [Ankit] - Correct define pl