Re: [PATCH 2/3] drm/i915: remove i915_report_error()

2024-08-07 Thread Andi Shyti
Hi Jani, On Tue, Aug 06, 2024 at 04:38:31PM +0300, Jani Nikula wrote: > i915_report_error() has only two users, both in driver probe. I doubt > these cases are worth having a dedicated wrapper to also print bug > reporting info. Just switch them to regular drm_err() and remove the > wrapper. > >

Re: [PATCH 2/3] drm/i915: remove i915_report_error()

2024-08-07 Thread Tvrtko Ursulin
On 06/08/2024 14:38, Jani Nikula wrote: i915_report_error() has only two users, both in driver probe. I doubt these cases are worth having a dedicated wrapper to also print bug reporting info. Just switch them to regular drm_err() and remove the wrapper. Signed-off-by: Jani Nikula --- drive

RE: [PATCH 2/3] drm/i915: remove i915_report_error()

2024-08-06 Thread Cavitt, Jonathan
-Original Message- From: Intel-gfx On Behalf Of Jani Nikula Sent: Tuesday, August 6, 2024 6:39 AM To: intel-gfx@lists.freedesktop.org Cc: Nikula, Jani Subject: [PATCH 2/3] drm/i915: remove i915_report_error() > > i915_report_error() has only two users, both in driver probe. I doubt > th