Re: [PATCH 1/2] drm/i915/watermark: Refactor dpkgc code

2024-11-14 Thread Govindapillai, Vinod
sts.freedesktop.org > > Cc: Syrjala, Ville > > Subject: Re: [PATCH 1/2] drm/i915/watermark: Refactor dpkgc code > > > > Hi, > > > > I guess this is mostly ok. But some minor comments... > > > > On Thu, 2024-11-14 at 10:00 +0530, Suraj Kandpal wrote: &g

RE: [PATCH 1/2] drm/i915/watermark: Refactor dpkgc code

2024-11-14 Thread Kandpal, Suraj
> -Original Message- > From: Govindapillai, Vinod > Sent: Thursday, November 14, 2024 6:12 PM > To: Kandpal, Suraj ; intel...@lists.freedesktop.org; > intel-gfx@lists.freedesktop.org > Cc: Syrjala, Ville > Subject: Re: [PATCH 1/2] drm/i915/watermark: Refactor dpkgc

Re: [PATCH 1/2] drm/i915/watermark: Refactor dpkgc code

2024-11-14 Thread Govindapillai, Vinod
Hi, I guess this is mostly ok. But some minor comments... On Thu, 2024-11-14 at 10:00 +0530, Suraj Kandpal wrote: > We move our dpkgc function for the below reasons: > - We want to make sure we have all the required values specially > linetime which is computed after intel_wm_compute, this will a