Re: [RFC PATCH] Revert "drm/i915: Disable compression tricks on JSL"

2025-03-06 Thread Ville Syrjälä
On Wed, Mar 05, 2025 at 05:00:26PM +, Sebastian Brzezinka wrote: > Hi Ville > > On Wed Mar 5, 2025 at 3:26 PM UTC, Ville Syrjälä wrote: > > On Wed, Mar 05, 2025 at 02:49:46PM +, Sebastian Brzezinka wrote: > >> This reverts commit 0ddae025ab6cefa9aba757da3cd1d27908d70b0e. > >> > >> Accordi

Re: [RFC PATCH] Revert "drm/i915: Disable compression tricks on JSL"

2025-03-05 Thread Sebastian Brzezinka
Hi Ville On Wed Mar 5, 2025 at 3:26 PM UTC, Ville Syrjälä wrote: > On Wed, Mar 05, 2025 at 02:49:46PM +, Sebastian Brzezinka wrote: >> This reverts commit 0ddae025ab6cefa9aba757da3cd1d27908d70b0e. >> >> According to bspec 14181, CACHE_MODE_0 is a register that's under userspace >> control, an

Re: [RFC PATCH] Revert "drm/i915: Disable compression tricks on JSL"

2025-03-05 Thread Ville Syrjälä
On Wed, Mar 05, 2025 at 02:49:46PM +, Sebastian Brzezinka wrote: > This reverts commit 0ddae025ab6cefa9aba757da3cd1d27908d70b0e. > > According to bspec 14181, CACHE_MODE_0 is a register that's under userspace > control, and DISABLE_REPACKING_FOR_COMPRESSION workaround should be already > in al

Re: [RFC PATCH] Revert "drm/i915: Disable compression tricks on JSL"

2025-03-05 Thread Sebastian Brzezinka
Hi The bug appeared recently once, and it is possible that it will pop up from time to times, so it might be better to get rid of this workaround from the kernel, especially since it's already in Mesa. I would like to know, what you think about it ? -- Best regards, Sebastian

[RFC PATCH] Revert "drm/i915: Disable compression tricks on JSL"

2025-03-05 Thread Sebastian Brzezinka
This reverts commit 0ddae025ab6cefa9aba757da3cd1d27908d70b0e. According to bspec 14181, CACHE_MODE_0 is a register that's under userspace control, and DISABLE_REPACKING_FOR_COMPRESSION workaround should be already in all recent Mesa releases. So, there is no need to include it in kernel. Also, th