Re: [PATCH v3 06/10] drm/i915/psr: Allow writing PSR2_MAN_TRK_CTL using DSB

2025-01-19 Thread Hogander, Jouni
On Fri, 2025-01-17 at 21:22 +0200, Ville Syrjälä wrote: > On Thu, Jan 09, 2025 at 09:31:33AM +0200, Jouni Högander wrote: > > Allow writing PSR2_MAN_TRK_CTL using DSB by using > > intel_de_write_dsb. Do > > not check intel_dp->psr.lock being held when using DSB. This > > assertion > > doesn't make

Re: [PATCH v3 06/10] drm/i915/psr: Allow writing PSR2_MAN_TRK_CTL using DSB

2025-01-17 Thread Ville Syrjälä
On Thu, Jan 09, 2025 at 09:31:33AM +0200, Jouni Högander wrote: > Allow writing PSR2_MAN_TRK_CTL using DSB by using intel_de_write_dsb. Do > not check intel_dp->psr.lock being held when using DSB. This assertion > doesn't make sense as in case of using DSB the actual write happens later > and we ar

RE: [PATCH v3 06/10] drm/i915/psr: Allow writing PSR2_MAN_TRK_CTL using DSB

2025-01-15 Thread Manna, Animesh
> -Original Message- > From: Intel-xe On Behalf Of Jouni > Högander > Sent: Thursday, January 9, 2025 1:02 PM > To: intel-gfx@lists.freedesktop.org; intel...@lists.freedesktop.org > Cc: Hogander, Jouni > Subject: [PATCH v3 06/10] drm/i915/psr: Allow writing PSR2_MA

[PATCH v3 06/10] drm/i915/psr: Allow writing PSR2_MAN_TRK_CTL using DSB

2025-01-08 Thread Jouni Högander
Allow writing PSR2_MAN_TRK_CTL using DSB by using intel_de_write_dsb. Do not check intel_dp->psr.lock being held when using DSB. This assertion doesn't make sense as in case of using DSB the actual write happens later and we are not taking intel_dp->psr.lock mutex over dsb commit. Signed-off-by: J