Re: [PATCH v3 0/8] drm/i915: PREEMPT_RT related fixups.

2024-10-04 Thread Sebastian Andrzej Siewior
On 2024-10-04 12:07:24 [+0300], Ville Syrjälä wrote: > > what happens if this gets delayed? Just flicker or worse? > > In the best best case it just gets you a corrupted frame > of some sort, in the worst case the hardware falls over. > Depends on what kind of update is happening, and what > platf

Re: [PATCH v3 0/8] drm/i915: PREEMPT_RT related fixups.

2024-10-04 Thread Ville Syrjälä
On Fri, Oct 04, 2024 at 10:45:25AM +0200, Sebastian Andrzej Siewior wrote: > On 2024-10-04 11:31:22 [+0300], Ville Syrjälä wrote: > > > > So once vblank evasion has declared things to be safe we might have > > as short a time as VBLANK_EVASION_TIME_US to write all the registers. > > If the CPU get

Re: [PATCH v3 0/8] drm/i915: PREEMPT_RT related fixups.

2024-10-04 Thread Sebastian Andrzej Siewior
On 2024-10-04 11:31:22 [+0300], Ville Syrjälä wrote: > > So once vblank evasion has declared things to be safe we might have > as short a time as VBLANK_EVASION_TIME_US to write all the registers. > If the CPU gets stolen from us at that point we can no longer guarantee > anything. The magic value

Re: [PATCH v3 0/8] drm/i915: PREEMPT_RT related fixups.

2024-10-04 Thread Ville Syrjälä
On Fri, Oct 04, 2024 at 08:49:51AM +0200, Sebastian Andrzej Siewior wrote: > On 2024-10-02 19:58:08 [+0300], Ville Syrjälä wrote: > > > These patches were not picked. Did I forget something or was this just > > > overseen? > > > > This looks quite poorly justified. Eg. you seem to be now > > leavi

Re: [PATCH v3 0/8] drm/i915: PREEMPT_RT related fixups.

2024-10-03 Thread Sebastian Andrzej Siewior
On 2024-10-02 19:58:08 [+0300], Ville Syrjälä wrote: > > These patches were not picked. Did I forget something or was this just > > overseen? > > This looks quite poorly justified. Eg. you seem to be now > leaving interrupts enabled (and even preemption enabled I > guess) when we're racing against

Re: [PATCH v3 0/8] drm/i915: PREEMPT_RT related fixups.

2024-10-02 Thread Ville Syrjälä
On Wed, Oct 02, 2024 at 06:25:43PM +0200, Sebastian Andrzej Siewior wrote: > On 2024-06-28 14:57:59 [+0200], To intel-gfx@lists.freedesktop.org wrote: > Hi, > > > The following patches are from the PREEMPT_RT queue. It is mostly about > > disabling interrupts/preemption which leads to problems. U

Re: [PATCH v3 0/8] drm/i915: PREEMPT_RT related fixups.

2024-10-02 Thread Sebastian Andrzej Siewior
On 2024-06-28 14:57:59 [+0200], To intel-gfx@lists.freedesktop.org wrote: Hi, > The following patches are from the PREEMPT_RT queue. It is mostly about > disabling interrupts/preemption which leads to problems. Unfortunately > DRM_I915_LOW_LEVEL_TRACEPOINTS had to be disabled because it acquires

[PATCH v3 0/8] drm/i915: PREEMPT_RT related fixups.

2024-06-28 Thread Sebastian Andrzej Siewior
Hi, The following patches are from the PREEMPT_RT queue. It is mostly about disabling interrupts/preemption which leads to problems. Unfortunately DRM_I915_LOW_LEVEL_TRACEPOINTS had to be disabled because it acquires locks from within trace points. Making the lock a raw_spinlock_t led to higher l