Re: [PATCH v3] drm/i915: Fix page cleanup on DMA remap failure

2025-01-28 Thread Ville Syrjälä
On Mon, Jan 27, 2025 at 03:43:32PM -0500, Brian Geffon wrote: > When converting to folios the cleanup path of shmem_get_pages() was > missed. When a DMA remap fails and the max segment size is greater than > PAGE_SIZE it will attempt to retry the remap with a PAGE_SIZEd segment > size. The cleanup

RE: [PATCH v3] drm/i915: Fix page cleanup on DMA remap failure

2025-01-27 Thread Srinivas, Vidya
nux.intel.com; linux-ker...@vger.kernel.org; dri- > de...@lists.freedesktop.org; Joonas Lahtinen > ; sta...@vger.kernel.org; Tomasz Figa > ; Cavitt, Jonathan > Subject: RE: [PATCH v3] drm/i915: Fix page cleanup on DMA remap failure > > -Original Message- > From: Intel-gf

RE: [PATCH v3] drm/i915: Fix page cleanup on DMA remap failure

2025-01-27 Thread Cavitt, Jonathan
...@vger.kernel.org; dri-de...@lists.freedesktop.org; Joonas Lahtinen ; Brian Geffon ; sta...@vger.kernel.org; Tomasz Figa Subject: [PATCH v3] drm/i915: Fix page cleanup on DMA remap failure > > When converting to folios the cleanup path of shmem_get_pages() was > missed. When a DMA remap

[PATCH v3] drm/i915: Fix page cleanup on DMA remap failure

2025-01-27 Thread Brian Geffon
When converting to folios the cleanup path of shmem_get_pages() was missed. When a DMA remap fails and the max segment size is greater than PAGE_SIZE it will attempt to retry the remap with a PAGE_SIZEd segment size. The cleanup code isn't properly using the folio apis and as a result isn't handlin