[PATCH v2 12/21] drm/i915/dp: Use check link state work in the detect handler

2024-05-29 Thread gareth . yu
A bad link in MST is not retrained. Please also consider MST. The issue ticket is https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10902. if (intel_dp->is_mst) { /* * If we are in MST mode then this connector * won't appear connecte

RE: [PATCH v2 12/21] drm/i915/dp: Use check link state work in the detect handler

2024-05-27 Thread Yu, Gareth
ired by Compliance tests Thanks, Gareth > -Original Message- > From: Deak, Imre > Sent: Monday, May 27, 2024 7:30 PM > To: Yu, Gareth > Cc: intel-gfx@lists.freedesktop.org; Ville Syrjälä > > Subject: Re: [PATCH v2 12/21] drm/i915/dp: Use check link state work in

Re: [PATCH v2 12/21] drm/i915/dp: Use check link state work in the detect handler

2024-05-27 Thread Imre Deak
On Mon, May 27, 2024 at 01:14:32PM +0800, gareth...@intel.com wrote: Hi, > A bad link in MST is not retrained. Please also consider MST. > The issue ticket is > https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10902. > > if (intel_dp->is_mst) { > /* >*

[PATCH v2 12/21] drm/i915/dp: Use check link state work in the detect handler

2024-05-26 Thread gareth . yu
A bad link in MST is not retrained. Please also consider MST. The issue ticket is https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10902. if (intel_dp->is_mst) { /* * If we are in MST mode then this connector * won't appear connecte

Re: [PATCH v2 12/21] drm/i915/dp: Use check link state work in the detect handler

2024-05-23 Thread Imre Deak
On Thu, May 23, 2024 at 06:43:40PM +0300, Ville Syrjälä wrote: > On Thu, May 23, 2024 at 06:29:21PM +0300, Imre Deak wrote: > > On Thu, May 23, 2024 at 06:08:40PM +0300, Ville Syrjälä wrote: > > > On Mon, May 20, 2024 at 09:58:10PM +0300, Imre Deak wrote: > > > > Simplify things by retraining a DP

Re: [PATCH v2 12/21] drm/i915/dp: Use check link state work in the detect handler

2024-05-23 Thread Ville Syrjälä
On Thu, May 23, 2024 at 06:29:21PM +0300, Imre Deak wrote: > On Thu, May 23, 2024 at 06:08:40PM +0300, Ville Syrjälä wrote: > > On Mon, May 20, 2024 at 09:58:10PM +0300, Imre Deak wrote: > > > Simplify things by retraining a DP link if a bad link is detected in the > > > connector detect handler fr

Re: [PATCH v2 12/21] drm/i915/dp: Use check link state work in the detect handler

2024-05-23 Thread Imre Deak
On Thu, May 23, 2024 at 06:08:40PM +0300, Ville Syrjälä wrote: > On Mon, May 20, 2024 at 09:58:10PM +0300, Imre Deak wrote: > > Simplify things by retraining a DP link if a bad link is detected in the > > connector detect handler from the encoder's check link state work, > > similarly to how this i

Re: [PATCH v2 12/21] drm/i915/dp: Use check link state work in the detect handler

2024-05-23 Thread Ville Syrjälä
On Mon, May 20, 2024 at 09:58:10PM +0300, Imre Deak wrote: > Simplify things by retraining a DP link if a bad link is detected in the > connector detect handler from the encoder's check link state work, > similarly to how this is done after a modeset link training failure. > > Signed-off-by: Imre

[PATCH v2 12/21] drm/i915/dp: Use check link state work in the detect handler

2024-05-20 Thread Imre Deak
Simplify things by retraining a DP link if a bad link is detected in the connector detect handler from the encoder's check link state work, similarly to how this is done after a modeset link training failure. Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/display/intel_dp.c | 7 ++- 1 fil