Re: [PATCH v2 1/4] drm/dp: Add a way to init/add a connector in separate steps

2024-12-06 Thread Simona Vetter
On Mon, Dec 02, 2024 at 10:07:23PM +0200, Imre Deak wrote: > On Mon, Dec 02, 2024 at 05:35:34PM +0100, Simona Vetter wrote: > > On Tue, Nov 26, 2024 at 06:18:56PM +0200, Imre Deak wrote: > > > Atm when the connector is added to the drm_mode_config::connector_list, > > > the connector may not be ful

Re: [PATCH v2 1/4] drm/dp: Add a way to init/add a connector in separate steps

2024-12-03 Thread Jani Nikula
On Tue, 03 Dec 2024, Maxime Ripard wrote: > On Mon, Dec 02, 2024 at 05:44:27PM +0200, Jani Nikula wrote: >> >> It's super tempting for people to just get their jobs done. If doing >> >> the right thing adds yet another hurdle, we may see more stuff being >> >> added in drivers instead of drm core.

Re: [PATCH v2 1/4] drm/dp: Add a way to init/add a connector in separate steps

2024-12-03 Thread Maxime Ripard
On Mon, Dec 02, 2024 at 05:44:27PM +0200, Jani Nikula wrote: > >> It's super tempting for people to just get their jobs done. If doing > >> the right thing adds yet another hurdle, we may see more stuff being > >> added in drivers instead of drm core. > > > > I really enjoy hidden threats. > > Non

Re: [PATCH v2 1/4] drm/dp: Add a way to init/add a connector in separate steps

2024-12-02 Thread Jani Nikula
On Mon, 02 Dec 2024, Maxime Ripard wrote: > On Mon, Dec 02, 2024 at 02:07:36PM +0200, Jani Nikula wrote: >> On Mon, 02 Dec 2024, Maxime Ripard wrote: >> > It's not about whether we have a problem or not: you introduce new >> > framework functions, you need to have kunit tests to check their >> >

Re: [PATCH v2 1/4] drm/dp: Add a way to init/add a connector in separate steps

2024-12-02 Thread Imre Deak
On Mon, Dec 02, 2024 at 02:07:36PM +0200, Jani Nikula wrote: > On Mon, 02 Dec 2024, Maxime Ripard wrote: > > It's not about whether we have a problem or not: you introduce new > > framework functions, you need to have kunit tests to check their > > behaviour. > > I don't fundamentally disagree wi

Re: [PATCH v2 1/4] drm/dp: Add a way to init/add a connector in separate steps

2024-12-02 Thread Maxime Ripard
On Mon, Dec 02, 2024 at 03:24:43PM +0200, Imre Deak wrote: > On Mon, Dec 02, 2024 at 02:07:36PM +0200, Jani Nikula wrote: > > On Mon, 02 Dec 2024, Maxime Ripard wrote: > > > It's not about whether we have a problem or not: you introduce new > > > framework functions, you need to have kunit tests t

Re: [PATCH v2 1/4] drm/dp: Add a way to init/add a connector in separate steps

2024-12-02 Thread Maxime Ripard
On Mon, Dec 02, 2024 at 02:07:36PM +0200, Jani Nikula wrote: > On Mon, 02 Dec 2024, Maxime Ripard wrote: > > It's not about whether we have a problem or not: you introduce new > > framework functions, you need to have kunit tests to check their > > behaviour. > > I don't fundamentally disagree wi

Re: [PATCH v2 1/4] drm/dp: Add a way to init/add a connector in separate steps

2024-12-02 Thread Imre Deak
On Mon, Dec 02, 2024 at 05:35:34PM +0100, Simona Vetter wrote: > On Tue, Nov 26, 2024 at 06:18:56PM +0200, Imre Deak wrote: > > Atm when the connector is added to the drm_mode_config::connector_list, > > the connector may not be fully initialized yet. This is not a problem > > for user space, which

Re: [PATCH v2 1/4] drm/dp: Add a way to init/add a connector in separate steps

2024-12-02 Thread Imre Deak
On Mon, Dec 02, 2024 at 04:07:56PM +0100, Maxime Ripard wrote: > On Mon, Dec 02, 2024 at 03:24:43PM +0200, Imre Deak wrote: > > On Mon, Dec 02, 2024 at 02:07:36PM +0200, Jani Nikula wrote: > > > On Mon, 02 Dec 2024, Maxime Ripard wrote: > > > > It's not about whether we have a problem or not: you

Re: [PATCH v2 1/4] drm/dp: Add a way to init/add a connector in separate steps

2024-12-02 Thread Simona Vetter
On Tue, Nov 26, 2024 at 06:18:56PM +0200, Imre Deak wrote: > Atm when the connector is added to the drm_mode_config::connector_list, > the connector may not be fully initialized yet. This is not a problem > for user space, which will see the connector only after it's registered > later, it could be

Re: [PATCH v2 1/4] drm/dp: Add a way to init/add a connector in separate steps

2024-12-02 Thread Jani Nikula
On Mon, 02 Dec 2024, Maxime Ripard wrote: > It's not about whether we have a problem or not: you introduce new > framework functions, you need to have kunit tests to check their > behaviour. I don't fundamentally disagree with that goal, but it does seem like a pretty drastic policy change. I don

Re: [PATCH v2 1/4] drm/dp: Add a way to init/add a connector in separate steps

2024-12-02 Thread Maxime Ripard
On Fri, Nov 29, 2024 at 06:12:01PM +0200, Imre Deak wrote: > On Fri, Nov 29, 2024 at 03:46:28PM +0100, Maxime Ripard wrote: > > On Fri, Nov 29, 2024 at 04:26:01PM +0200, Imre Deak wrote: > > > Adding more people from DRM core domain. Any comment, objection to this > > > change? > > > > > > On Tue,

Re: [PATCH v2 1/4] drm/dp: Add a way to init/add a connector in separate steps

2024-12-02 Thread Maxime Ripard
On Fri, Nov 29, 2024 at 05:58:56PM +0200, Jani Nikula wrote: > On Fri, 29 Nov 2024, Maxime Ripard wrote: > > On Fri, Nov 29, 2024 at 04:26:01PM +0200, Imre Deak wrote: > >> Adding more people from DRM core domain. Any comment, objection to this > >> change? > >> > >> On Tue, Nov 26, 2024 at 06:18

Re: [PATCH v2 1/4] drm/dp: Add a way to init/add a connector in separate steps

2024-11-29 Thread Imre Deak
On Fri, Nov 29, 2024 at 03:46:28PM +0100, Maxime Ripard wrote: > On Fri, Nov 29, 2024 at 04:26:01PM +0200, Imre Deak wrote: > > Adding more people from DRM core domain. Any comment, objection to this > > change? > > > > On Tue, Nov 26, 2024 at 06:18:56PM +0200, Imre Deak wrote: > > > Atm when the

Re: [PATCH v2 1/4] drm/dp: Add a way to init/add a connector in separate steps

2024-11-29 Thread Jani Nikula
On Fri, 29 Nov 2024, Maxime Ripard wrote: > On Fri, Nov 29, 2024 at 04:26:01PM +0200, Imre Deak wrote: >> Adding more people from DRM core domain. Any comment, objection to this >> change? >> >> On Tue, Nov 26, 2024 at 06:18:56PM +0200, Imre Deak wrote: >> > Atm when the connector is added to the

Re: [PATCH v2 1/4] drm/dp: Add a way to init/add a connector in separate steps

2024-11-29 Thread Maxime Ripard
On Fri, Nov 29, 2024 at 04:26:01PM +0200, Imre Deak wrote: > Adding more people from DRM core domain. Any comment, objection to this > change? > > On Tue, Nov 26, 2024 at 06:18:56PM +0200, Imre Deak wrote: > > Atm when the connector is added to the drm_mode_config::connector_list, > > the connecto

Re: [PATCH v2 1/4] drm/dp: Add a way to init/add a connector in separate steps

2024-11-29 Thread Imre Deak
Adding more people from DRM core domain. Any comment, objection to this change? On Tue, Nov 26, 2024 at 06:18:56PM +0200, Imre Deak wrote: > Atm when the connector is added to the drm_mode_config::connector_list, > the connector may not be fully initialized yet. This is not a problem > for user sp

[PATCH v2 1/4] drm/dp: Add a way to init/add a connector in separate steps

2024-11-26 Thread Imre Deak
Atm when the connector is added to the drm_mode_config::connector_list, the connector may not be fully initialized yet. This is not a problem for user space, which will see the connector only after it's registered later, it could be a problem for in-kernel users looking up connectors via the above