Re: [PATCH v2] drm/i915/display: UHBR rates for Thunderbolt

2024-12-30 Thread Imre Deak
On Tue, Dec 24, 2024 at 06:01:48PM -0300, Gustavo Sousa wrote: > Quoting Imre Deak (2024-12-18 11:56:46-03:00) > >On Tue, Dec 17, 2024 at 04:34:40PM +0200, Mika Kahola wrote: > >> tbt-alt mode is missing uhbr rates 10G and 20G. This requires > >> requires pll clock rates 312.5 MHz and 625 MHz to be

Re: [PATCH v2] drm/i915/display: UHBR rates for Thunderbolt

2024-12-24 Thread Gustavo Sousa
Quoting Imre Deak (2024-12-18 11:56:46-03:00) >On Tue, Dec 17, 2024 at 04:34:40PM +0200, Mika Kahola wrote: >> tbt-alt mode is missing uhbr rates 10G and 20G. This requires >> requires pll clock rates 312.5 MHz and 625 MHz to be added, >> respectively. The uhbr rates are supported only form PTL+ >>

Re: [PATCH v2] drm/i915/display: UHBR rates for Thunderbolt

2024-12-19 Thread Imre Deak
On Thu, Dec 19, 2024 at 01:35:11PM +0200, Jani Nikula wrote: > On Thu, 19 Dec 2024, "Kahola, Mika" wrote: > > Thanks for the review! Patch is now merged with the change of naming > > to XE3_*. This is used elsewhere in the driver so maybe it's ok to use > > here as well. > > Nag, I don't really l

RE: [PATCH v2] drm/i915/display: UHBR rates for Thunderbolt

2024-12-19 Thread Jani Nikula
On Thu, 19 Dec 2024, "Kahola, Mika" wrote: > Thanks for the review! Patch is now merged with the change of naming > to XE3_*. This is used elsewhere in the driver so maybe it's ok to use > here as well. Nag, I don't really like modifying patches while applying. Personally, I try to avoid it altog

RE: [PATCH v2] drm/i915/display: UHBR rates for Thunderbolt

2024-12-19 Thread Kahola, Mika
> -Original Message- > From: Deak, Imre > Sent: Wednesday, 18 December 2024 16.57 > To: Kahola, Mika > Cc: intel-gfx@lists.freedesktop.org; intel...@lists.freedesktop.org > Subject: Re: [PATCH v2] drm/i915/display: UHBR rates for Thunderbolt > > On Tue, Dec 17,

Re: [PATCH v2] drm/i915/display: UHBR rates for Thunderbolt

2024-12-18 Thread Imre Deak
On Tue, Dec 17, 2024 at 04:34:40PM +0200, Mika Kahola wrote: > tbt-alt mode is missing uhbr rates 10G and 20G. This requires > requires pll clock rates 312.5 MHz and 625 MHz to be added, > respectively. The uhbr rates are supported only form PTL+ > platforms. > > v2: Add drm_WARN_ON() to check if

[PATCH v2] drm/i915/display: UHBR rates for Thunderbolt

2024-12-17 Thread Mika Kahola
tbt-alt mode is missing uhbr rates 10G and 20G. This requires requires pll clock rates 312.5 MHz and 625 MHz to be added, respectively. The uhbr rates are supported only form PTL+ platforms. v2: Add drm_WARN_ON() to check if port clock is not supported by the platform (Imre) Combine forwar