Re: [PATCH v1 0/2] drm/i915/fence: A couple of build fixes

2024-09-02 Thread Andy Shevchenko
On Mon, Sep 02, 2024 at 11:27:57AM +0300, Jani Nikula wrote: > On Thu, 29 Aug 2024, Jani Nikula wrote: > > The TL;DR is, > > > > Reviewed-by: Jani Nikula > > > > on the series. > > Both pushed to drm-intel-next, thanks for the patches and discussion. > > I amended the commit message about clang

Re: [PATCH v1 0/2] drm/i915/fence: A couple of build fixes

2024-09-02 Thread Jani Nikula
On Thu, 29 Aug 2024, Jani Nikula wrote: > The TL;DR is, > > Reviewed-by: Jani Nikula > > on the series. Both pushed to drm-intel-next, thanks for the patches and discussion. I amended the commit message about clang, config options and commit 6863f5643dd7 ("kbuild: allow Clang to find unused sta

Re: [PATCH v1 0/2] drm/i915/fence: A couple of build fixes

2024-08-29 Thread Nathan Chancellor
On Thu, Aug 29, 2024 at 09:37:34PM +0300, Jani Nikula wrote: > On Thu, 29 Aug 2024, Nathan Chancellor wrote: > > Since commit 6863f5643dd7 ("kbuild: allow Clang to find unused static > > inline functions for W=1 build"). clang warns about unused static inline > > functions in .c files, unlike GCC

Re: [PATCH v1 0/2] drm/i915/fence: A couple of build fixes

2024-08-29 Thread Jani Nikula
On Thu, 29 Aug 2024, Nathan Chancellor wrote: > On Thu, Aug 29, 2024 at 09:10:41PM +0300, Andy Shevchenko wrote: >> On Thu, Aug 29, 2024 at 07:53:25PM +0300, Andy Shevchenko wrote: >> > On Thu, Aug 29, 2024 at 07:38:08PM +0300, Jani Nikula wrote: >> > > On Thu, 29 Aug 2024, Andy Shevchenko >> >

Re: [PATCH v1 0/2] drm/i915/fence: A couple of build fixes

2024-08-29 Thread Nathan Chancellor
On Thu, Aug 29, 2024 at 09:10:41PM +0300, Andy Shevchenko wrote: > On Thu, Aug 29, 2024 at 07:53:25PM +0300, Andy Shevchenko wrote: > > On Thu, Aug 29, 2024 at 07:38:08PM +0300, Jani Nikula wrote: > > > On Thu, 29 Aug 2024, Andy Shevchenko > > > wrote: > > > > With CONFIG_WERROR=y and `make W=1`

Re: [PATCH v1 0/2] drm/i915/fence: A couple of build fixes

2024-08-29 Thread Andy Shevchenko
On Thu, Aug 29, 2024 at 07:53:25PM +0300, Andy Shevchenko wrote: > On Thu, Aug 29, 2024 at 07:38:08PM +0300, Jani Nikula wrote: > > On Thu, 29 Aug 2024, Andy Shevchenko > > wrote: > > > With CONFIG_WERROR=y and `make W=1` build fails on my x86_64 machine. > > > This is due to some unused function

Re: [PATCH v1 0/2] drm/i915/fence: A couple of build fixes

2024-08-29 Thread Andy Shevchenko
On Thu, Aug 29, 2024 at 07:38:08PM +0300, Jani Nikula wrote: > On Thu, 29 Aug 2024, Andy Shevchenko > wrote: > > With CONFIG_WERROR=y and `make W=1` build fails on my x86_64 machine. > > This is due to some unused functions. Hence these quick fixes. > > Since when have we been getting the warnin

Re: [PATCH v1 0/2] drm/i915/fence: A couple of build fixes

2024-08-29 Thread Jani Nikula
On Thu, 29 Aug 2024, Andy Shevchenko wrote: > With CONFIG_WERROR=y and `make W=1` build fails on my x86_64 machine. > This is due to some unused functions. Hence these quick fixes. Since when have we been getting the warnings for static inlines? BR, Jani. > > Andy Shevchenko (2): > drm/i915/

[PATCH v1 0/2] drm/i915/fence: A couple of build fixes

2024-08-29 Thread Andy Shevchenko
With CONFIG_WERROR=y and `make W=1` build fails on my x86_64 machine. This is due to some unused functions. Hence these quick fixes. Andy Shevchenko (2): drm/i915/fence: Mark debug_fence_init_onstack() with __maybe_unused drm/i915/fence: Mark debug_fence_free() with __maybe_unused drivers/gp