Re: [PATCH next] drm/i915: Fix NULL vs IS_ERR() check in __shmem_writeback()

2025-02-07 Thread Andi Shyti
> > - if (!folio) > > + if (IS_ERR(folio)) > > I don't see this patch yet in -next yet (and of course not in > drm-tip), which branch is it based on? To be precise, not this patch, but the patch(*) that this is fixing :-) Andi (*) "drm/i915/gem: Convert __shmem_writeback() t

Re: [PATCH next] drm/i915: Fix NULL vs IS_ERR() check in __shmem_writeback()

2025-02-07 Thread Dan Carpenter
On Fri, Feb 07, 2025 at 12:02:43PM +0100, Andi Shyti wrote: > Hi Dan, > > On Thu, Feb 06, 2025 at 11:17:02AM +0300, Dan Carpenter wrote: > > The filemap_lock_folio() function doesn't return NULL, it returns error > > pointers. > > > > Fixes: 25dd342f0cc8 ("drm/i915/gem: convert __shmem_writeback(

Re: [PATCH next] drm/i915: Fix NULL vs IS_ERR() check in __shmem_writeback()

2025-02-07 Thread Andi Shyti
Hi Dan, On Thu, Feb 06, 2025 at 11:17:02AM +0300, Dan Carpenter wrote: > The filemap_lock_folio() function doesn't return NULL, it returns error > pointers. > > Fixes: 25dd342f0cc8 ("drm/i915/gem: convert __shmem_writeback() to folios") > Signed-off-by: Dan Carpenter > --- > drivers/gpu/drm/i91

Re: [PATCH next] drm/i915: Fix NULL vs IS_ERR() check in __shmem_writeback()

2025-02-06 Thread Andi Shyti
> The filemap_lock_folio() function doesn't return NULL, it returns error > pointers. > > Fixes: 25dd342f0cc8 ("drm/i915/gem: convert __shmem_writeback() to folios") > Signed-off-by: Dan Carpenter ... > struct folio *folio; > > folio = filemap_lock_folio(mapping, i

[PATCH next] drm/i915: Fix NULL vs IS_ERR() check in __shmem_writeback()

2025-02-06 Thread Dan Carpenter
The filemap_lock_folio() function doesn't return NULL, it returns error pointers. Fixes: 25dd342f0cc8 ("drm/i915/gem: convert __shmem_writeback() to folios") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g