Re: [PATCH 3/6] drm/i915: Extract pipe_mbus_dbox_ctl_update()

2024-11-01 Thread Ville Syrjälä
On Fri, Nov 01, 2024 at 12:29:03PM +0200, Jani Nikula wrote: > On Thu, 31 Oct 2024, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > We'll be wanting reprogram the PIPE_MBUS_DBOX_CTL registers > > wanting *to* reprogram > > I would've wanted to see conversion to struct intel_display here to

Re: [PATCH 3/6] drm/i915: Extract pipe_mbus_dbox_ctl_update()

2024-11-01 Thread Jani Nikula
On Thu, 31 Oct 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > We'll be wanting reprogram the PIPE_MBUS_DBOX_CTL registers wanting *to* reprogram I would've wanted to see conversion to struct intel_display here too, or at least a mention we're keeping it this way for backports, or somethin

[PATCH 3/6] drm/i915: Extract pipe_mbus_dbox_ctl_update()

2024-10-31 Thread Ville Syrjala
From: Ville Syrjälä We'll be wanting reprogram the PIPE_MBUS_DBOX_CTL registers during an upcoming MBUS sanitation stage. Extract the reprogramming loop into a helper that doesn't depend on the full atomic state so that it can be reused. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/di