Re: [PATCH 3/5] drm/sched: stop passing non struct drm_device to drm_err() and friends

2025-01-29 Thread Philipp Stanner
nit: In drm/sched, we start with an upper case -> "drm/sched: Stop […]" On Fri, 2025-01-24 at 13:46 +0200, Jani Nikula wrote: > On Thu, 23 Jan 2025, Simona Vetter wrote: > > On Thu, Jan 23, 2025 at 05:09:10PM +0200, Jani Nikula wrote: > > > The expectation is that the struct drm_device based logg

Re: [PATCH 3/5] drm/sched: stop passing non struct drm_device to drm_err() and friends

2025-01-24 Thread Jani Nikula
On Thu, 23 Jan 2025, Simona Vetter wrote: > On Thu, Jan 23, 2025 at 05:09:10PM +0200, Jani Nikula wrote: >> The expectation is that the struct drm_device based logging helpers get >> passed an actual struct drm_device pointer rather than some random >> struct pointer where you can dereference the

Re: [PATCH 3/5] drm/sched: stop passing non struct drm_device to drm_err() and friends

2025-01-23 Thread Simona Vetter
On Thu, Jan 23, 2025 at 05:09:10PM +0200, Jani Nikula wrote: > The expectation is that the struct drm_device based logging helpers get > passed an actual struct drm_device pointer rather than some random > struct pointer where you can dereference the ->dev member. > > Convert drm_err(sched, ...) t

[PATCH 3/5] drm/sched: stop passing non struct drm_device to drm_err() and friends

2025-01-23 Thread Jani Nikula
The expectation is that the struct drm_device based logging helpers get passed an actual struct drm_device pointer rather than some random struct pointer where you can dereference the ->dev member. Convert drm_err(sched, ...) to dev_err(sched->dev, ...) and similar. This matches current usage, as