RE: [PATCH 3/3] drm/i915: Fix bigjoiner case for DP2.0

2024-02-27 Thread Srinivas, Vidya
> -Original Message- > From: Lisovskiy, Stanislav > Sent: Tuesday, February 27, 2024 2:44 PM > To: Srinivas, Vidya > Cc: Jani Nikula ; > intel-gfx@lists.freedesktop.org; > Saarinen, Jani ; ville.syrj...@linux.intel.com > Subject: Re: [PATCH 3/3] drm/i915: Fix

RE: [PATCH 3/3] drm/i915: Fix bigjoiner case for DP2.0

2024-02-27 Thread Srinivas, Vidya
> -Original Message- > From: Manasi Navare > Sent: Tuesday, February 27, 2024 11:37 PM > To: Jani Nikula > Cc: Lisovskiy, Stanislav ; intel- > g...@lists.freedesktop.org; Saarinen, Jani ; > ville.syrj...@linux.intel.com; Srinivas, Vidya > Subject: Re: [

Re: [PATCH 3/3] drm/i915: Fix bigjoiner case for DP2.0

2024-02-27 Thread Manasi Navare
Thanks Jani for your review. Thanks @Lisovskiy, Stanislav and @vidya.srini...@intel.com for taking this patch forward. @Jani Nikula , @Ville Syrjälä : MST bigjoiner as a feature needs to be enabled upstream and this patch enables that feature. If you agree that bigjoiner refactoring patches 1 and

Re: [PATCH 3/3] drm/i915: Fix bigjoiner case for DP2.0

2024-02-27 Thread Jani Nikula
On Tue, 27 Feb 2024, "Lisovskiy, Stanislav" wrote: > On Mon, Feb 26, 2024 at 09:56:10PM +0200, Jani Nikula wrote: >> On Wed, 21 Feb 2024, Stanislav Lisovskiy >> wrote: >> > Patch calculates bigjoiner pipes in mst compute. >> > Patch also passes bigjoiner bool to validate plane >> > max size. >>

Re: [PATCH 3/3] drm/i915: Fix bigjoiner case for DP2.0

2024-02-27 Thread Lisovskiy, Stanislav
; > ; > > ville.syrj...@linux.intel.com; Srinivas, Vidya > > Subject: Re: [PATCH 3/3] drm/i915: Fix bigjoiner case for DP2.0 > > > > On Mon, Feb 26, 2024 at 09:56:10PM +0200, Jani Nikula wrote: > > > On Wed, 21 Feb 2024, Stanislav Lisovskiy > > wrote: &

RE: [PATCH 3/3] drm/i915: Fix bigjoiner case for DP2.0

2024-02-27 Thread Srinivas, Vidya
> -Original Message- > From: Lisovskiy, Stanislav > Sent: Tuesday, February 27, 2024 2:34 PM > To: Jani Nikula > Cc: intel-gfx@lists.freedesktop.org; Saarinen, Jani ; > ville.syrj...@linux.intel.com; Srinivas, Vidya > Subject: Re: [PATCH 3/3] drm/i915: Fix big

Re: [PATCH 3/3] drm/i915: Fix bigjoiner case for DP2.0

2024-02-27 Thread Lisovskiy, Stanislav
On Mon, Feb 26, 2024 at 09:56:10PM +0200, Jani Nikula wrote: > On Wed, 21 Feb 2024, Stanislav Lisovskiy > wrote: > > Patch calculates bigjoiner pipes in mst compute. > > Patch also passes bigjoiner bool to validate plane > > max size. > > Please use the imperative mood in commit messages, e.g. "

Re: [PATCH 3/3] drm/i915: Fix bigjoiner case for DP2.0

2024-02-26 Thread Jani Nikula
On Wed, 21 Feb 2024, Stanislav Lisovskiy wrote: > Patch calculates bigjoiner pipes in mst compute. > Patch also passes bigjoiner bool to validate plane > max size. Please use the imperative mood in commit messages, e.g. "calculate" intead of "calculates". Please do not refer to "patch". We know

Re: [PATCH 3/3] drm/i915: Fix bigjoiner case for DP2.0

2024-02-21 Thread Manasi Navare
Thanks Stan and Vidya for this patch. ACK for the bigjoiner pipes calc and plane max size validation changes. @Ville Syrjälä : Do you see any gaps now with MST bigjoiner enabling in crtc_enable hooks () ? Or just these changes would suffice? Regards Manasi On Wed, Feb 21, 2024 at 11:20 AM Stanis

[PATCH 3/3] drm/i915: Fix bigjoiner case for DP2.0

2024-02-21 Thread Stanislav Lisovskiy
Patch calculates bigjoiner pipes in mst compute. Patch also passes bigjoiner bool to validate plane max size. Signed-off-by: vsrini4 Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/display/intel_dp_mst.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) dif

Re: [PATCH 3/3] drm/i915: Fix bigjoiner case for DP2.0

2024-02-20 Thread Almahallawy, Khaled
Thank You for the patch. Do you think we need to revert: 9c058492b16f ("drm/i915/mst: Reject modes that require the bigjoiner") On Wed, 2024-02-21 at 00:09 +0200, Stanislav Lisovskiy wrote: > Patch calculates bigjoiner pipes in mst compute. > Patch also passes bigjoiner bool to validate plane >

[PATCH 3/3] drm/i915: Fix bigjoiner case for DP2.0

2024-02-20 Thread Stanislav Lisovskiy
Patch calculates bigjoiner pipes in mst compute. Patch also passes bigjoiner bool to validate plane max size. Signed-off-by: vsrini4 Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/display/intel_dp_mst.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) dif