Re: [PATCH 2/4] drm/i915/dmc_wl: Add debugfs for untracked offsets

2025-01-30 Thread Luca Coelho
On Thu, 2025-01-23 at 11:41 -0300, Gustavo Sousa wrote: > Quoting Luca Coelho (2025-01-22 06:06:00-03:00) > > On Fri, 2025-01-17 at 19:06 -0300, Gustavo Sousa wrote: > > > The DMC wakelock code needs to keep track of register offsets that need > > > the wakelock for proper access. If one of the nec

Re: [PATCH 2/4] drm/i915/dmc_wl: Add debugfs for untracked offsets

2025-01-30 Thread Vivekanandan, Balasubramani
On 23.01.2025 13:41, Gustavo Sousa wrote: > Quoting Vivekanandan, Balasubramani (2025-01-23 13:11:03-03:00) > >On 17.01.2025 19:06, Gustavo Sousa wrote: > >> The DMC wakelock code needs to keep track of register offsets that need > >> the wakelock for proper access. If one of the necessary offsets

Re: [PATCH 2/4] drm/i915/dmc_wl: Add debugfs for untracked offsets

2025-01-27 Thread Gustavo Sousa
Quoting Jani Nikula (2025-01-27 08:59:11-03:00) >On Mon, 27 Jan 2025, Gustavo Sousa wrote: >> Quoting Jani Nikula (2025-01-27 06:47:58-03:00) >>>On Fri, 17 Jan 2025, Gustavo Sousa wrote: diff --git a/drivers/gpu/drm/i915/display/intel_dmc_wl.h b/drivers/gpu/drm/i915/display/intel_dmc_w

Re: [PATCH 2/4] drm/i915/dmc_wl: Add debugfs for untracked offsets

2025-01-27 Thread Jani Nikula
On Mon, 27 Jan 2025, Gustavo Sousa wrote: > Quoting Jani Nikula (2025-01-27 06:47:58-03:00) >>On Fri, 17 Jan 2025, Gustavo Sousa wrote: >>> diff --git a/drivers/gpu/drm/i915/display/intel_dmc_wl.h >>> b/drivers/gpu/drm/i915/display/intel_dmc_wl.h >>> index 5488fbdf29b8..d11b0ab50b3c 100644 >>> -

Re: [PATCH 2/4] drm/i915/dmc_wl: Add debugfs for untracked offsets

2025-01-27 Thread Gustavo Sousa
Quoting Jani Nikula (2025-01-27 06:47:58-03:00) >On Fri, 17 Jan 2025, Gustavo Sousa wrote: >> diff --git a/drivers/gpu/drm/i915/display/intel_dmc_wl.h >> b/drivers/gpu/drm/i915/display/intel_dmc_wl.h >> index 5488fbdf29b8..d11b0ab50b3c 100644 >> --- a/drivers/gpu/drm/i915/display/intel_dmc_wl.h >

Re: [PATCH 2/4] drm/i915/dmc_wl: Add debugfs for untracked offsets

2025-01-27 Thread Jani Nikula
On Fri, 17 Jan 2025, Gustavo Sousa wrote: > diff --git a/drivers/gpu/drm/i915/display/intel_dmc_wl.h > b/drivers/gpu/drm/i915/display/intel_dmc_wl.h > index 5488fbdf29b8..d11b0ab50b3c 100644 > --- a/drivers/gpu/drm/i915/display/intel_dmc_wl.h > +++ b/drivers/gpu/drm/i915/display/intel_dmc_wl.h >

Re: [PATCH 2/4] drm/i915/dmc_wl: Add debugfs for untracked offsets

2025-01-23 Thread Gustavo Sousa
Quoting Vivekanandan, Balasubramani (2025-01-23 13:11:03-03:00) >On 17.01.2025 19:06, Gustavo Sousa wrote: >> The DMC wakelock code needs to keep track of register offsets that need >> the wakelock for proper access. If one of the necessary offsets are >> missed, then the failure in asserting the w

Re: [PATCH 2/4] drm/i915/dmc_wl: Add debugfs for untracked offsets

2025-01-23 Thread Vivekanandan, Balasubramani
On 17.01.2025 19:06, Gustavo Sousa wrote: > The DMC wakelock code needs to keep track of register offsets that need > the wakelock for proper access. If one of the necessary offsets are > missed, then the failure in asserting the wakelock is very likely to > cause problems down the road. > > A mis

Re: [PATCH 2/4] drm/i915/dmc_wl: Add debugfs for untracked offsets

2025-01-23 Thread Gustavo Sousa
Quoting Luca Coelho (2025-01-22 06:06:00-03:00) >On Fri, 2025-01-17 at 19:06 -0300, Gustavo Sousa wrote: >> The DMC wakelock code needs to keep track of register offsets that need >> the wakelock for proper access. If one of the necessary offsets are >> missed, then the failure in asserting the wak

Re: [PATCH 2/4] drm/i915/dmc_wl: Add debugfs for untracked offsets

2025-01-22 Thread Luca Coelho
On Fri, 2025-01-17 at 19:06 -0300, Gustavo Sousa wrote: > The DMC wakelock code needs to keep track of register offsets that need > the wakelock for proper access. If one of the necessary offsets are > missed, then the failure in asserting the wakelock is very likely to > cause problems down the ro

[PATCH 2/4] drm/i915/dmc_wl: Add debugfs for untracked offsets

2025-01-17 Thread Gustavo Sousa
The DMC wakelock code needs to keep track of register offsets that need the wakelock for proper access. If one of the necessary offsets are missed, then the failure in asserting the wakelock is very likely to cause problems down the road. A miss could happen for at least two different reasons: -