Re: [PATCH 2/2] drm/i915: Skip object locking around a no-op set-domain ioctl

2019-06-02 Thread Serge Belyshev
Hi! > This patch causes lockups in firefox. They appear like non-fatal hangs > of the webpage contents, "fixable" with alt-tab or a background system > load. I have verified that reverting the commit 754a254427 on top of > current Linus tree fixes the problem. This is still broken in v5.2-rc3.

Re: [PATCH 2/2] drm/i915: Skip object locking around a no-op set-domain ioctl

2019-05-18 Thread Serge Belyshev
Hi! This patch causes lockups in firefox. They appear like non-fatal hangs of the webpage contents, "fixable" with alt-tab or a background system load. I have verified that reverting the commit 754a254427 on top of current Linus tree fixes the problem.

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Skip object locking around a no-op set-domain ioctl

2019-03-22 Thread Chris Wilson
Quoting Ville Syrjälä (2019-03-22 14:28:37) > On Thu, Mar 21, 2019 at 04:19:08PM +, Chris Wilson wrote: > > If we are already in the desired write domain of a set-domain ioctl, > > then there is nothing for us to do and we can quickly return back to > > userspace, avoiding any lock contention.

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Skip object locking around a no-op set-domain ioctl

2019-03-22 Thread Ville Syrjälä
On Thu, Mar 21, 2019 at 04:19:08PM +, Chris Wilson wrote: > If we are already in the desired write domain of a set-domain ioctl, > then there is nothing for us to do and we can quickly return back to > userspace, avoiding any lock contention. By recognising that the > write_domain is always a s

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Skip object locking around a no-op set-domain ioctl

2019-03-21 Thread Matthew Auld
On Thu, 21 Mar 2019 at 13:43, Chris Wilson wrote: > > If we are already in the desired write domain of a set-domain ioctl, > then there is nothing for us to do and we can quickly return back to > userspace, avoiding any lock contention. By recognising that the > write_domain is always a subset of

[Intel-gfx] [PATCH 2/2] drm/i915: Skip object locking around a no-op set-domain ioctl

2019-03-21 Thread Chris Wilson
If we are already in the desired write domain of a set-domain ioctl, then there is nothing for us to do and we can quickly return back to userspace, avoiding any lock contention. By recognising that the write_domain is always a subset of the read_domains, and excluding the no-op case of requiring 0

[Intel-gfx] [PATCH 2/2] drm/i915: Skip object locking around a no-op set-domain ioctl

2019-03-21 Thread Chris Wilson
If we are already in the desired write domain of a set-domain ioctl, then there is nothing for us to do and we can quickly return back to userspace, avoiding any lock contention. By recognising that the write_domain is always a subset of the read_domains, and excluding the no-op case of requiring 0