Re: [PATCH 1/2] drm/i915/display: Drop crtc_state from C10/C20 pll programming

2025-01-30 Thread Imre Deak
On Wed, Jan 29, 2025 at 04:40:01PM +0200, Jani Nikula wrote: > On Wed, 29 Jan 2025, Mika Kahola wrote: > > For PLL programming for C10 and C20 we don't need to > > carry crtc_state but instead use only necessary parts > > of the crtc_state i.e. pll_state. > > This is not a good enough justificati

RE: [PATCH 1/2] drm/i915/display: Drop crtc_state from C10/C20 pll programming

2025-01-30 Thread Kahola, Mika
> -Original Message- > From: Jani Nikula > Sent: Wednesday, 29 January 2025 16.40 > To: Kahola, Mika ; intel-gfx@lists.freedesktop.org; > intel- > x...@lists.freedesktop.org > Cc: Deak, Imre ; Kahola, Mika > Subject: Re: [PATCH 1/2] drm/i915/display: Drop crt

Re: [PATCH 1/2] drm/i915/display: Drop crtc_state from C10/C20 pll programming

2025-01-29 Thread Jani Nikula
On Wed, 29 Jan 2025, Mika Kahola wrote: > For PLL programming for C10 and C20 we don't need to > carry crtc_state but instead use only necessary parts > of the crtc_state i.e. pll_state. This is not a good enough justification alone. Usually we pass crtc_state around because we're going to need m

[PATCH 1/2] drm/i915/display: Drop crtc_state from C10/C20 pll programming

2025-01-29 Thread Mika Kahola
For PLL programming for C10 and C20 we don't need to carry crtc_state but instead use only necessary parts of the crtc_state i.e. pll_state. Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/display/intel_cx0_phy.c | 109 +++ 1 file changed, 64 insertions(+), 45 deletions(-) d