Re: [PATCH 01/12] drm/i915: Indicate which pipe failed the fastset check overall

2024-02-28 Thread Petr Mladek
On Wed 2024-02-28 09:32:37, Rasmus Villemoes wrote: > On 27/02/2024 19.32, Ville Syrjälä wrote: > > On Tue, Feb 27, 2024 at 10:38:10AM +0100, Rasmus Villemoes wrote: > >> On 26/02/2024 15.57, Jani Nikula wrote: > So if we really want to go down this road, I think it should be > something like %pX{d

Re: [PATCH 01/12] drm/i915: Indicate which pipe failed the fastset check overall

2024-02-28 Thread Rasmus Villemoes
On 27/02/2024 19.32, Ville Syrjälä wrote: > On Tue, Feb 27, 2024 at 10:38:10AM +0100, Rasmus Villemoes wrote: >> On 26/02/2024 15.57, Jani Nikula wrote: >> >>> Personally I suck at remembering even the standard printf conversion >>> specifiers, let alone all the kernel extensions. I basically have

Re: [PATCH 01/12] drm/i915: Indicate which pipe failed the fastset check overall

2024-02-27 Thread Ville Syrjälä
On Tue, Feb 27, 2024 at 10:38:10AM +0100, Rasmus Villemoes wrote: > On 26/02/2024 15.57, Jani Nikula wrote: > > > Personally I suck at remembering even the standard printf conversion > > specifiers, let alone all the kernel extensions. I basically have to > > look them up every time. I'd really lo

Re: [PATCH 01/12] drm/i915: Indicate which pipe failed the fastset check overall

2024-02-27 Thread Rasmus Villemoes
On 26/02/2024 15.57, Jani Nikula wrote: > Personally I suck at remembering even the standard printf conversion > specifiers, let alone all the kernel extensions. I basically have to > look them up every time. I'd really love some %{name} format for named > pointer things. And indeed preferrably wi

Re: [PATCH 01/12] drm/i915: Indicate which pipe failed the fastset check overall

2024-02-26 Thread Ville Syrjälä
On Mon, Feb 26, 2024 at 05:35:51PM +0200, Jani Nikula wrote: > On Mon, 26 Feb 2024, Andy Shevchenko > wrote: > > On Mon, Feb 26, 2024 at 04:57:58PM +0200, Jani Nikula wrote: > >> On Fri, 23 Feb 2024, Ville Syrjälä wrote: > >> > On Thu, Feb 22, 2024 at 04:46:12PM -0500, Rodrigo Vivi wrote: > > >

Re: [PATCH 01/12] drm/i915: Indicate which pipe failed the fastset check overall

2024-02-26 Thread Andy Shevchenko
On Mon, Feb 26, 2024 at 05:35:51PM +0200, Jani Nikula wrote: > On Mon, 26 Feb 2024, Andy Shevchenko > wrote: > > On Mon, Feb 26, 2024 at 04:57:58PM +0200, Jani Nikula wrote: > >> On Fri, 23 Feb 2024, Ville Syrjälä wrote: > >> > On Thu, Feb 22, 2024 at 04:46:12PM -0500, Rodrigo Vivi wrote: ...

Re: [PATCH 01/12] drm/i915: Indicate which pipe failed the fastset check overall

2024-02-26 Thread Jani Nikula
On Mon, 26 Feb 2024, Andy Shevchenko wrote: > On Mon, Feb 26, 2024 at 04:57:58PM +0200, Jani Nikula wrote: >> On Fri, 23 Feb 2024, Ville Syrjälä wrote: >> > On Thu, Feb 22, 2024 at 04:46:12PM -0500, Rodrigo Vivi wrote: > > ... > >> > I think the proper solution would be to have actually >> > sens

Re: [PATCH 01/12] drm/i915: Indicate which pipe failed the fastset check overall

2024-02-26 Thread Andy Shevchenko
On Mon, Feb 26, 2024 at 04:57:58PM +0200, Jani Nikula wrote: > On Fri, 23 Feb 2024, Ville Syrjälä wrote: > > On Thu, Feb 22, 2024 at 04:46:12PM -0500, Rodrigo Vivi wrote: ... > > I think the proper solution would be to have actually > > sensible conversion specifiers in the format string. > > So

Re: [PATCH 01/12] drm/i915: Indicate which pipe failed the fastset check overall

2024-02-26 Thread Jani Nikula
On Fri, 23 Feb 2024, Ville Syrjälä wrote: > On Thu, Feb 22, 2024 at 04:46:12PM -0500, Rodrigo Vivi wrote: >> On Thu, Feb 15, 2024 at 06:40:44PM +0200, Ville Syrjala wrote: >> > From: Ville Syrjälä >> > >> > intel_crtc_check_fastset() is done per-pipe, so it would be nice >> > to know which pipe

Re: [PATCH 01/12] drm/i915: Indicate which pipe failed the fastset check overall

2024-02-23 Thread Ville Syrjälä
On Thu, Feb 22, 2024 at 04:46:12PM -0500, Rodrigo Vivi wrote: > On Thu, Feb 15, 2024 at 06:40:44PM +0200, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > intel_crtc_check_fastset() is done per-pipe, so it would be nice > > to know which pipe it was that failed its checkup. > > > > Signed-of

Re: [PATCH 01/12] drm/i915: Indicate which pipe failed the fastset check overall

2024-02-22 Thread Rodrigo Vivi
On Thu, Feb 15, 2024 at 06:40:44PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > intel_crtc_check_fastset() is done per-pipe, so it would be nice > to know which pipe it was that failed its checkup. > > Signed-off-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/display/intel_display.c |

[PATCH 01/12] drm/i915: Indicate which pipe failed the fastset check overall

2024-02-15 Thread Ville Syrjala
From: Ville Syrjälä intel_crtc_check_fastset() is done per-pipe, so it would be nice to know which pipe it was that failed its checkup. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/driver