Re: [PATCH] drm/xe: Nuke xe's copy of intel_fbdev_fb.h

2024-05-10 Thread Jani Nikula
On Wed, 08 May 2024, Ville Syrjälä wrote: > On Tue, May 07, 2024 at 11:53:40AM +0300, Jani Nikula wrote: >> On Mon, 06 May 2024, Ville Syrjala wrote: >> > From: Ville Syrjälä >> > >> > For some reason xe and i915 each have an identical (fortunately) >> > copy of intel_fbdev_fb.h. The xe copy act

Re: [PATCH] drm/xe: Nuke xe's copy of intel_fbdev_fb.h

2024-05-08 Thread Lucas De Marchi
On Wed, May 08, 2024 at 10:52:54PM GMT, Ville Syrjälä wrote: On Tue, May 07, 2024 at 11:53:40AM +0300, Jani Nikula wrote: On Mon, 06 May 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > For some reason xe and i915 each have an identical (fortunately) > copy of intel_fbdev_fb.h. The xe copy

Re: [PATCH] drm/xe: Nuke xe's copy of intel_fbdev_fb.h

2024-05-08 Thread Ville Syrjälä
On Tue, May 07, 2024 at 11:53:40AM +0300, Jani Nikula wrote: > On Mon, 06 May 2024, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > For some reason xe and i915 each have an identical (fortunately) > > copy of intel_fbdev_fb.h. The xe copy actually only gets included > > by xe's intel_fbdev_f

Re: [PATCH] drm/xe: Nuke xe's copy of intel_fbdev_fb.h

2024-05-07 Thread Jani Nikula
On Mon, 06 May 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > For some reason xe and i915 each have an identical (fortunately) > copy of intel_fbdev_fb.h. The xe copy actually only gets included > by xe's intel_fbdev_fb.c, and the i915 copy by everyone else, > include intel_fbdev.c which is

[PATCH] drm/xe: Nuke xe's copy of intel_fbdev_fb.h

2024-05-06 Thread Ville Syrjala
From: Ville Syrjälä For some reason xe and i915 each have an identical (fortunately) copy of intel_fbdev_fb.h. The xe copy actually only gets included by xe's intel_fbdev_fb.c, and the i915 copy by everyone else, include intel_fbdev.c which is the actual caller of the functions declared in the he