Re: [PATCH] drm/i915: use check_add_overflow() and drop local variants

2024-04-09 Thread Jani Nikula
On Mon, 08 Apr 2024, Rodrigo Vivi wrote: > On Fri, Apr 05, 2024 at 11:26:25PM +0300, Jani Nikula wrote: >> Prefer common check_add_overflow() from overflow.h over the locally >> rolled versions of it. While check_add_overflow() does require a >> variable to assign to, unlike add_overflows_t(), it'

Re: [PATCH] drm/i915: use check_add_overflow() and drop local variants

2024-04-08 Thread Rodrigo Vivi
On Fri, Apr 05, 2024 at 11:26:25PM +0300, Jani Nikula wrote: > Prefer common check_add_overflow() from overflow.h over the locally > rolled versions of it. While check_add_overflow() does require a > variable to assign to, unlike add_overflows_t(), it's still better than > having multiple versions

[PATCH] drm/i915: use check_add_overflow() and drop local variants

2024-04-05 Thread Jani Nikula
Prefer common check_add_overflow() from overflow.h over the locally rolled versions of it. While check_add_overflow() does require a variable to assign to, unlike add_overflows_t(), it's still better than having multiple versions around. Cc: Kees Cook Signed-off-by: Jani Nikula --- drivers/gpu/