Re: [PATCH] drm/i915/pmu: Drop custom hotplug code

2025-02-13 Thread Liang, Kan
On 2025-02-13 9:28 a.m., Tvrtko Ursulin wrote: > > On 13/02/2025 13:36, Liang, Kan wrote: >> On 2025-02-12 11:13 p.m., Lucas De Marchi wrote: >>> On Tue, Jan 21, 2025 at 12:19:15PM -0500, Liang, Kan wrote: On 2025-01-21 11:59 a.m., Lucas De Marchi wrote: > On Tue, Jan 21, 202

Re: [PATCH] drm/i915/pmu: Drop custom hotplug code

2025-02-13 Thread Tvrtko Ursulin
On 13/02/2025 13:36, Liang, Kan wrote: On 2025-02-12 11:13 p.m., Lucas De Marchi wrote: On Tue, Jan 21, 2025 at 12:19:15PM -0500, Liang, Kan wrote: On 2025-01-21 11:59 a.m., Lucas De Marchi wrote: On Tue, Jan 21, 2025 at 10:53:31AM -0500, Liang, Kan wrote: On 2025-01-21 9:29 a.m., Lucas

Re: [PATCH] drm/i915/pmu: Drop custom hotplug code

2025-02-13 Thread Liang, Kan
On 2025-02-12 11:13 p.m., Lucas De Marchi wrote: > On Tue, Jan 21, 2025 at 12:19:15PM -0500, Liang, Kan wrote: >> >> >> On 2025-01-21 11:59 a.m., Lucas De Marchi wrote: >>> On Tue, Jan 21, 2025 at 10:53:31AM -0500, Liang, Kan wrote: On 2025-01-21 9:29 a.m., Lucas De Marchi wrote:

Re: [PATCH] drm/i915/pmu: Drop custom hotplug code

2025-02-12 Thread Lucas De Marchi
On Tue, Jan 21, 2025 at 12:19:15PM -0500, Liang, Kan wrote: On 2025-01-21 11:59 a.m., Lucas De Marchi wrote: On Tue, Jan 21, 2025 at 10:53:31AM -0500, Liang, Kan wrote: On 2025-01-21 9:29 a.m., Lucas De Marchi wrote: On Mon, Jan 20, 2025 at 08:42:41PM -0500, Liang, Kan wrote: -static int

Re: [PATCH] drm/i915/pmu: Drop custom hotplug code

2025-01-29 Thread Tvrtko Ursulin
On 16/01/2025 22:24, Lucas De Marchi wrote: Since commit 4ba4f1afb6a9 ("perf: Generic hotplug support for a PMU with a scope"), there's generic support for system-wide counters and integration with cpu hotplug. Set our scope to PERF_PMU_SCOPE_SYS_WIDE instead of all the boilerplate code for han

Re: [PATCH] drm/i915/pmu: Drop custom hotplug code

2025-01-27 Thread Umesh Nerlige Ramappa
On Sat, Jan 25, 2025 at 10:32:11AM -0600, Lucas De Marchi wrote: On Fri, Jan 24, 2025 at 04:46:21PM -0800, Umesh Nerlige Ramappa wrote: Hi Lucas, Mostly a bunch of questions since I think I am missing something. On Tue, Jan 21, 2025 at 10:59:08AM -0600, Lucas De Marchi wrote: On Tue, Jan 21,

Re: [PATCH] drm/i915/pmu: Drop custom hotplug code

2025-01-25 Thread Lucas De Marchi
On Fri, Jan 24, 2025 at 04:46:21PM -0800, Umesh Nerlige Ramappa wrote: Hi Lucas, Mostly a bunch of questions since I think I am missing something. On Tue, Jan 21, 2025 at 10:59:08AM -0600, Lucas De Marchi wrote: On Tue, Jan 21, 2025 at 10:53:31AM -0500, Liang, Kan wrote: On 2025-01-21 9:29

Re: [PATCH] drm/i915/pmu: Drop custom hotplug code

2025-01-24 Thread Umesh Nerlige Ramappa
Hi Lucas, Mostly a bunch of questions since I think I am missing something. On Tue, Jan 21, 2025 at 10:59:08AM -0600, Lucas De Marchi wrote: On Tue, Jan 21, 2025 at 10:53:31AM -0500, Liang, Kan wrote: On 2025-01-21 9:29 a.m., Lucas De Marchi wrote: On Mon, Jan 20, 2025 at 08:42:41PM -0500,

Re: [PATCH] drm/i915/pmu: Drop custom hotplug code

2025-01-23 Thread Lucas De Marchi
On Thu, Jan 23, 2025 at 06:06:29PM +, Tvrtko Ursulin wrote: On 23/01/2025 16:27, Lucas De Marchi wrote: On Thu, Jan 23, 2025 at 09:43:35AM +, Tvrtko Ursulin wrote: On 20/01/2025 22:57, Lucas De Marchi wrote: On Mon, Jan 20, 2025 at 10:08:39AM -0500, Liang, Kan wrote: On 2025-01-16

Re: [PATCH] drm/i915/pmu: Drop custom hotplug code

2025-01-23 Thread Tvrtko Ursulin
On 23/01/2025 16:27, Lucas De Marchi wrote: On Thu, Jan 23, 2025 at 09:43:35AM +, Tvrtko Ursulin wrote: On 20/01/2025 22:57, Lucas De Marchi wrote: On Mon, Jan 20, 2025 at 10:08:39AM -0500, Liang, Kan wrote: On 2025-01-16 5:24 p.m., Lucas De Marchi wrote: Since commit 4ba4f1afb6a9 ("p

Re: [PATCH] drm/i915/pmu: Drop custom hotplug code

2025-01-23 Thread Lucas De Marchi
On Thu, Jan 23, 2025 at 09:43:35AM +, Tvrtko Ursulin wrote: On 20/01/2025 22:57, Lucas De Marchi wrote: On Mon, Jan 20, 2025 at 10:08:39AM -0500, Liang, Kan wrote: On 2025-01-16 5:24 p.m., Lucas De Marchi wrote: Since commit 4ba4f1afb6a9 ("perf: Generic hotplug support for a PMU with a

Re: [PATCH] drm/i915/pmu: Drop custom hotplug code

2025-01-23 Thread Tvrtko Ursulin
On 20/01/2025 22:57, Lucas De Marchi wrote: On Mon, Jan 20, 2025 at 10:08:39AM -0500, Liang, Kan wrote: On 2025-01-16 5:24 p.m., Lucas De Marchi wrote: Since commit 4ba4f1afb6a9 ("perf: Generic hotplug support for a PMU with a scope"), there's generic support for system-wide counters and in

Re: [PATCH] drm/i915/pmu: Drop custom hotplug code

2025-01-21 Thread Liang, Kan
On 2025-01-21 11:59 a.m., Lucas De Marchi wrote: > On Tue, Jan 21, 2025 at 10:53:31AM -0500, Liang, Kan wrote: >> >> >> On 2025-01-21 9:29 a.m., Lucas De Marchi wrote: >>> On Mon, Jan 20, 2025 at 08:42:41PM -0500, Liang, Kan wrote: >>> -static int i915_pmu_cpu_offline(unsigned int cpu, struc

Re: [PATCH] drm/i915/pmu: Drop custom hotplug code

2025-01-21 Thread Lucas De Marchi
On Tue, Jan 21, 2025 at 10:53:31AM -0500, Liang, Kan wrote: On 2025-01-21 9:29 a.m., Lucas De Marchi wrote: On Mon, Jan 20, 2025 at 08:42:41PM -0500, Liang, Kan wrote: -static int i915_pmu_cpu_offline(unsigned int cpu, struct hlist_node *node) -{ -    struct i915_pmu *pmu = hlist_entry_safe(n

Re: [PATCH] drm/i915/pmu: Drop custom hotplug code

2025-01-21 Thread Liang, Kan
On 2025-01-21 9:29 a.m., Lucas De Marchi wrote: > On Mon, Jan 20, 2025 at 08:42:41PM -0500, Liang, Kan wrote: > -static int i915_pmu_cpu_offline(unsigned int cpu, struct hlist_node > *node) > -{ > -    struct i915_pmu *pmu = hlist_entry_safe(node, typeof(*pmu), > cpuhp.node);

Re: [PATCH] drm/i915/pmu: Drop custom hotplug code

2025-01-21 Thread Lucas De Marchi
On Mon, Jan 20, 2025 at 08:42:41PM -0500, Liang, Kan wrote: -static int i915_pmu_cpu_offline(unsigned int cpu, struct hlist_node *node) -{ -    struct i915_pmu *pmu = hlist_entry_safe(node, typeof(*pmu), cpuhp.node); -    unsigned int target = i915_pmu_target_cpu; - -    /* - * Unregistering

Re: [PATCH] drm/i915/pmu: Drop custom hotplug code

2025-01-20 Thread Liang, Kan
On 2025-01-20 5:57 p.m., Lucas De Marchi wrote: > On Mon, Jan 20, 2025 at 10:08:39AM -0500, Liang, Kan wrote: >> >> >> On 2025-01-16 5:24 p.m., Lucas De Marchi wrote: >>> Since commit 4ba4f1afb6a9 ("perf: Generic hotplug support for a PMU with >>> a scope"), there's generic support for system-wi

Re: [PATCH] drm/i915/pmu: Drop custom hotplug code

2025-01-20 Thread Lucas De Marchi
On Mon, Jan 20, 2025 at 10:08:39AM -0500, Liang, Kan wrote: On 2025-01-16 5:24 p.m., Lucas De Marchi wrote: Since commit 4ba4f1afb6a9 ("perf: Generic hotplug support for a PMU with a scope"), there's generic support for system-wide counters and integration with cpu hotplug. Set our scope to PE

Re: [PATCH] drm/i915/pmu: Drop custom hotplug code

2025-01-20 Thread Liang, Kan
On 2025-01-16 5:24 p.m., Lucas De Marchi wrote: > Since commit 4ba4f1afb6a9 ("perf: Generic hotplug support for a PMU with > a scope"), there's generic support for system-wide counters and > integration with cpu hotplug. Set our scope to PERF_PMU_SCOPE_SYS_WIDE > instead of all the boilerplate c

[PATCH] drm/i915/pmu: Drop custom hotplug code

2025-01-16 Thread Lucas De Marchi
Since commit 4ba4f1afb6a9 ("perf: Generic hotplug support for a PMU with a scope"), there's generic support for system-wide counters and integration with cpu hotplug. Set our scope to PERF_PMU_SCOPE_SYS_WIDE instead of all the boilerplate code for handling hotplug. Cc: Kan Liang Cc: Peter Zijlstr