Re: [PATCH] drm/i915/gt: Prevent uninitialized pointer reads

2025-01-08 Thread Rodrigo Vivi
On Mon, Dec 30, 2024 at 02:24:45PM +, Krzysztof Karas wrote: > Hi Apoorva and Andi, > > > > Initialize rq to NULL to prevent uninitialized pointer reads. > > > > where is it happening? > > > > Andi > > There are two instances that I see: > 1) err = fn(..., &rq); <- this probably will set th

Re: [PATCH] drm/i915/gt: Prevent uninitialized pointer reads

2024-12-30 Thread Krzysztof Karas
Hi Apoorva, > From: Apoorva Singh > > Initialize rq to NULL to prevent uninitialized pointer reads. > > Signed-off-by: Apoorva Singh > --- > drivers/gpu/drm/i915/gt/selftest_migrate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gt/selftest_mi

Re: [PATCH] drm/i915/gt: Prevent uninitialized pointer reads

2024-12-30 Thread Krzysztof Karas
Hi Apoorva and Andi, > > Initialize rq to NULL to prevent uninitialized pointer reads. > > where is it happening? > > Andi There are two instances that I see: 1) err = fn(..., &rq); <- this probably will set the rq (at least looking at the functions that are used to set "fn", when calling "clea

Re: [PATCH] drm/i915/gt: Prevent uninitialized pointer reads

2024-12-27 Thread Andi Shyti
Hi Apoorva, On Fri, Dec 27, 2024 at 04:59:20PM +0530, apoorva.si...@intel.com wrote: > From: Apoorva Singh > > Initialize rq to NULL to prevent uninitialized pointer reads. where is it happening? Andi

[PATCH] drm/i915/gt: Prevent uninitialized pointer reads

2024-12-27 Thread apoorva . singh
From: Apoorva Singh Initialize rq to NULL to prevent uninitialized pointer reads. Signed-off-by: Apoorva Singh --- drivers/gpu/drm/i915/gt/selftest_migrate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/selftest_migrate.c b/drivers/gpu/drm/i915/g