Re: [PATCH] drm/i915/gt: Continue creating engine sysfs files even after a failure

2024-09-04 Thread Rodrigo Vivi
On Wed, Sep 04, 2024 at 05:34:42PM +0300, Jani Nikula wrote: > On Wed, 04 Sep 2024, Andi Shyti wrote: > > Hi Sima, > > > > On Tue, Aug 27, 2024 at 07:05:05PM +0200, Daniel Vetter wrote: > >> On Mon, Aug 19, 2024 at 01:31:40PM +0200, Andi Shyti wrote: > >> > The i915 driver generates sysfs entries

Re: [PATCH] drm/i915/gt: Continue creating engine sysfs files even after a failure

2024-09-04 Thread Tvrtko Ursulin
On 04/09/2024 15:34, Jani Nikula wrote: On Wed, 04 Sep 2024, Andi Shyti wrote: Hi Sima, On Tue, Aug 27, 2024 at 07:05:05PM +0200, Daniel Vetter wrote: On Mon, Aug 19, 2024 at 01:31:40PM +0200, Andi Shyti wrote: The i915 driver generates sysfs entries for each engine of the GPU in /sys/clas

Re: [PATCH] drm/i915/gt: Continue creating engine sysfs files even after a failure

2024-09-04 Thread Jani Nikula
On Wed, 04 Sep 2024, Andi Shyti wrote: > Hi Sima, > > On Tue, Aug 27, 2024 at 07:05:05PM +0200, Daniel Vetter wrote: >> On Mon, Aug 19, 2024 at 01:31:40PM +0200, Andi Shyti wrote: >> > The i915 driver generates sysfs entries for each engine of the >> > GPU in /sys/class/drm/cardX/engines/. >> > >

Re: [PATCH] drm/i915/gt: Continue creating engine sysfs files even after a failure

2024-09-04 Thread Andi Shyti
Hi Sima, On Tue, Aug 27, 2024 at 07:05:05PM +0200, Daniel Vetter wrote: > On Mon, Aug 19, 2024 at 01:31:40PM +0200, Andi Shyti wrote: > > The i915 driver generates sysfs entries for each engine of the > > GPU in /sys/class/drm/cardX/engines/. > > > > The process is straightforward: we loop over t

Re: [PATCH] drm/i915/gt: Continue creating engine sysfs files even after a failure

2024-08-28 Thread Rodrigo Vivi
On Tue, Aug 27, 2024 at 07:05:05PM +0200, Daniel Vetter wrote: > On Mon, Aug 19, 2024 at 01:31:40PM +0200, Andi Shyti wrote: > > The i915 driver generates sysfs entries for each engine of the > > GPU in /sys/class/drm/cardX/engines/. > > > > The process is straightforward: we loop over the UABI en

Re: [PATCH] drm/i915/gt: Continue creating engine sysfs files even after a failure

2024-08-27 Thread Daniel Vetter
On Mon, Aug 19, 2024 at 01:31:40PM +0200, Andi Shyti wrote: > The i915 driver generates sysfs entries for each engine of the > GPU in /sys/class/drm/cardX/engines/. > > The process is straightforward: we loop over the UABI engines and > for each one, we: > > - Create the object. > - Create basi

Re: [PATCH] drm/i915/gt: Continue creating engine sysfs files even after a failure

2024-08-23 Thread Andi Shyti
Hi Rodrigo, On Fri, Aug 23, 2024 at 09:41:31AM -0400, Rodrigo Vivi wrote: > On Wed, Aug 21, 2024 at 09:32:48AM +0200, Andi Shyti wrote: > > On Tue, Aug 20, 2024 at 05:22:40PM -0400, Rodrigo Vivi wrote: > > > On Mon, Aug 19, 2024 at 01:31:40PM +0200, Andi Shyti wrote: ... > > > > It might make sens

Re: [PATCH] drm/i915/gt: Continue creating engine sysfs files even after a failure

2024-08-23 Thread Rodrigo Vivi
On Wed, Aug 21, 2024 at 09:32:48AM +0200, Andi Shyti wrote: > Hi Rodrigo, > > On Tue, Aug 20, 2024 at 05:22:40PM -0400, Rodrigo Vivi wrote: > > On Mon, Aug 19, 2024 at 01:31:40PM +0200, Andi Shyti wrote: > > > The i915 driver generates sysfs entries for each engine of the > > > GPU in /sys/class/d

Re: [PATCH] drm/i915/gt: Continue creating engine sysfs files even after a failure

2024-08-21 Thread Andi Shyti
Hi Again, Rodrigo, ... > > Also it looks something is off with the goto paths... > > > > That if (0) is also ugly... probably better to use a > > kobject_put with continue on every failing point as well... > > ehehe... I came to like it, to be honest. Besides I like single > exit paths instead

Re: [PATCH] drm/i915/gt: Continue creating engine sysfs files even after a failure

2024-08-21 Thread Andi Shyti
Hi Rodrigo, On Tue, Aug 20, 2024 at 05:22:40PM -0400, Rodrigo Vivi wrote: > On Mon, Aug 19, 2024 at 01:31:40PM +0200, Andi Shyti wrote: > > The i915 driver generates sysfs entries for each engine of the > > GPU in /sys/class/drm/cardX/engines/. > > > > The process is straightforward: we loop over

Re: [PATCH] drm/i915/gt: Continue creating engine sysfs files even after a failure

2024-08-20 Thread Rodrigo Vivi
On Mon, Aug 19, 2024 at 01:31:40PM +0200, Andi Shyti wrote: > The i915 driver generates sysfs entries for each engine of the > GPU in /sys/class/drm/cardX/engines/. > > The process is straightforward: we loop over the UABI engines and > for each one, we: > > - Create the object. > - Create basi

[PATCH] drm/i915/gt: Continue creating engine sysfs files even after a failure

2024-08-19 Thread Andi Shyti
The i915 driver generates sysfs entries for each engine of the GPU in /sys/class/drm/cardX/engines/. The process is straightforward: we loop over the UABI engines and for each one, we: - Create the object. - Create basic files. - If the engine supports timeslicing, create timeslice duration fi