Re: [Intel-gfx] Thinkpad T420 and single/dual channel lvds

2012-03-18 Thread Takashi Iwai
At Sun, 18 Mar 2012 19:01:21 +0100, Andreas Heider wrote: > > Am 18.03.2012 um 18:50 schrieb Daniel Vetter: > > On Fri, Mar 16, 2012 at 09:29:24PM +0100, Takashi Iwai wrote: > >> At Fri, 16 Mar 2012 15:55:52 -0400, > >> Adam Jackson wrote: > >>> > >>> On 3/15/12 10:42 AM, Takashi Iwai wrote: > >>

Re: [Intel-gfx] Thinkpad T420 and single/dual channel lvds

2012-03-18 Thread Takashi Iwai
At Sun, 18 Mar 2012 18:50:31 +0100, Daniel Vetter wrote: > > On Fri, Mar 16, 2012 at 09:29:24PM +0100, Takashi Iwai wrote: > > At Fri, 16 Mar 2012 15:55:52 -0400, > > Adam Jackson wrote: > > > > > > On 3/15/12 10:42 AM, Takashi Iwai wrote: > > > > > > > diff --git a/drivers/gpu/drm/i915/intel_di

Re: [Intel-gfx] Thinkpad T420 and single/dual channel lvds

2012-03-18 Thread Andreas Heider
Am 18.03.2012 um 18:50 schrieb Daniel Vetter: > On Fri, Mar 16, 2012 at 09:29:24PM +0100, Takashi Iwai wrote: >> At Fri, 16 Mar 2012 15:55:52 -0400, >> Adam Jackson wrote: >>> >>> On 3/15/12 10:42 AM, Takashi Iwai wrote: >>> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/g

Re: [Intel-gfx] Thinkpad T420 and single/dual channel lvds

2012-03-18 Thread Daniel Vetter
On Fri, Mar 16, 2012 at 09:29:24PM +0100, Takashi Iwai wrote: > At Fri, 16 Mar 2012 15:55:52 -0400, > Adam Jackson wrote: > > > > On 3/15/12 10:42 AM, Takashi Iwai wrote: > > > > > diff --git a/drivers/gpu/drm/i915/intel_display.c > > > b/drivers/gpu/drm/i915/intel_display.c > > > index f851db7.

Re: [Intel-gfx] Thinkpad T420 and single/dual channel lvds

2012-03-16 Thread Takashi Iwai
At Fri, 16 Mar 2012 15:55:52 -0400, Adam Jackson wrote: > > On 3/15/12 10:42 AM, Takashi Iwai wrote: > > > diff --git a/drivers/gpu/drm/i915/intel_display.c > > b/drivers/gpu/drm/i915/intel_display.c > > index f851db7..314af26 100644 > > --- a/drivers/gpu/drm/i915/intel_display.c > > +++ b/drive

Re: [Intel-gfx] Thinkpad T420 and single/dual channel lvds

2012-03-16 Thread Adam Jackson
On 3/15/12 10:42 AM, Takashi Iwai wrote: diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index f851db7..314af26 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -356,6 +356,23 @@ static const intel_limit_t

Re: [Intel-gfx] Thinkpad T420 and single/dual channel lvds

2012-03-16 Thread Rodrigo Vivi
Reviewed-by: Rodrigo Vivi On Thu, Mar 15, 2012 at 11:42 AM, Takashi Iwai wrote: > At Thu, 15 Mar 2012 14:30:35 +0100, > Takashi Iwai wrote: >> >> At Thu, 15 Mar 2012 13:25:08 +, >> Chris Wilson wrote: >> > >> > On Thu, 15 Mar 2012 14:15:54 +0100, Takashi Iwai wrote: >> > > +static bool is_d

Re: [Intel-gfx] Thinkpad T420 and single/dual channel lvds

2012-03-15 Thread Takashi Iwai
At Thu, 15 Mar 2012 14:30:35 +0100, Takashi Iwai wrote: > > At Thu, 15 Mar 2012 13:25:08 +, > Chris Wilson wrote: > > > > On Thu, 15 Mar 2012 14:15:54 +0100, Takashi Iwai wrote: > > > +static bool is_dual_link_lvds(struct drm_i915_private *dev_priv) > > > +{ > > > + /* BIOS should set the pr

Re: [Intel-gfx] Thinkpad T420 and single/dual channel lvds

2012-03-15 Thread Takashi Iwai
At Thu, 15 Mar 2012 13:25:08 +, Chris Wilson wrote: > > On Thu, 15 Mar 2012 14:15:54 +0100, Takashi Iwai wrote: > > +static bool is_dual_link_lvds(struct drm_i915_private *dev_priv) > > +{ > > + /* BIOS should set the proper LVDS register value at boot, but > > +* in reality, it doesn't

Re: [Intel-gfx] Thinkpad T420 and single/dual channel lvds

2012-03-15 Thread Chris Wilson
On Thu, 15 Mar 2012 14:15:54 +0100, Takashi Iwai wrote: > +static bool is_dual_link_lvds(struct drm_i915_private *dev_priv) > +{ > + /* BIOS should set the proper LVDS register value at boot, but > + * in reality, it doesn't set the value when the lid is closed; > + * thus when a mac

Re: [Intel-gfx] Thinkpad T420 and single/dual channel lvds

2012-03-15 Thread Takashi Iwai
At Wed, 14 Mar 2012 14:09:19 -0400, Adam Jackson wrote: > > On Wed, 2012-03-14 at 17:44 +0100, Takashi Iwai wrote: > > At Wed, 14 Mar 2012 10:45:06 -0400, > > Adam Jackson wrote: > > > There may or may not be a bit for this in the VBT in the BIOS. But the > > > more reliably correct thing I suspe

Re: [Intel-gfx] Thinkpad T420 and single/dual channel lvds

2012-03-14 Thread Adam Jackson
On Wed, 2012-03-14 at 17:44 +0100, Takashi Iwai wrote: > At Wed, 14 Mar 2012 10:45:06 -0400, > Adam Jackson wrote: > > There may or may not be a bit for this in the VBT in the BIOS. But the > > more reliably correct thing I suspect would be to just look at the > > preferred mode for the panel and

Re: [Intel-gfx] Thinkpad T420 and single/dual channel lvds

2012-03-14 Thread Takashi Iwai
At Wed, 14 Mar 2012 10:45:06 -0400, Adam Jackson wrote: > > [1 ] > [1.1 ] > On Wed, 2012-03-14 at 13:37 +0100, Helge Bahmann wrote: > > Hi everyone, > > > > Booting a Thinkpad T420 with the lid closed results and opening it > > subsequently results in an > > unusable picture on the panel (and

Re: [Intel-gfx] Thinkpad T420 and single/dual channel lvds

2012-03-14 Thread Adam Jackson
On Wed, 2012-03-14 at 13:37 +0100, Helge Bahmann wrote: > Hi everyone, > > Booting a Thinkpad T420 with the lid closed results and opening it > subsequently results in an > unusable picture on the panel (and no amount of resetting makes it usable): > The even pixels show > the nominal content

[Intel-gfx] Thinkpad T420 and single/dual channel lvds

2012-03-14 Thread Helge Bahmann
Hi everyone, Booting a Thinkpad T420 with the lid closed results and opening it subsequently results in an unusable picture on the panel (and no amount of resetting makes it usable): The even pixels show the nominal content of the framebuffer (with the right half missing) whlie the odd pixels