Re: [Intel-gfx] Find bugs in i915 driver

2012-08-22 Thread Daniel Vetter
On Tue, Aug 21, 2012 at 09:20:37AM +0200, Daniel Vetter wrote: > On Mon, Aug 13, 2012 at 08:07:43AM +, Xu, Anhua wrote: > > Hi, Paul > > > > Thanks for your advice. I update my patch. Please review, for your > > question, please see my reply below. > > > > From d11080eda81c0503b5035ea40667b

Re: [Intel-gfx] Find bugs in i915 driver

2012-08-21 Thread Daniel Vetter
l = I915_READ(reg); > - if (lvds_pipe_enabled(dev_priv, val, pipe)) { > + if (lvds_pipe_enabled(dev_priv, pipe, val)) { > DRM_DEBUG_KMS("disable lvds on pipe %d val 0x%08x\n", pipe, > val); > I915_WRITE(reg, val & ~LVDS_PORT_EN);

Re: [Intel-gfx] Find bugs in i915 driver

2012-08-13 Thread Xu, Anhua
eg); -- 1.7.1 > -Original Message- > From: Paul Menzel [mailto:paulepan...@users.sourceforge.net] > Sent: Monday, August 13, 2012 3:11 PM > To: Xu, Anhua > Cc: Daniel Vetter; Greg KH; intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] Find bugs in i915 driver &g

Re: [Intel-gfx] Find bugs in i915 driver

2012-08-13 Thread Daniel Vetter
On Mon, Aug 13, 2012 at 03:08:33AM +, Xu, Anhua wrote: > Sorry, Deniel/Greg, late response for your email because of a busy work last > work. > I will response to you guys ASAP :), below is the updated patch: > > > From 33eb95a3a711b2354985361ff208ea150a5ba235 Mon Sep 17 00:00:00 2001 > Fr

Re: [Intel-gfx] Find bugs in i915 driver

2012-08-13 Thread Paul Menzel
Am Montag, den 13.08.2012, 03:08 + schrieb Xu, Anhua: > Sorry, Deniel/Greg, late response for your email because of a busy work last > work. > I will response to you guys ASAP :), below is the updated patch: > > > From 33eb95a3a711b2354985361ff208ea150a5ba235 Mon Sep 17 00:00:00 2001 > Fro

Re: [Intel-gfx] Find bugs in i915 driver

2012-08-12 Thread Xu, Anhua
r > Sent: Friday, August 10, 2012 7:41 PM > To: Greg KH > Cc: Xu, Anhua; intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] Find bugs in i915 driver > > On Tue, Jul 31, 2012 at 07:23:18AM -0700, Greg KH wrote: > > On Tue, Jul 31, 2012 at 09:17:15AM +, Xu, Anhua w

Re: [Intel-gfx] Find bugs in i915 driver

2012-08-10 Thread Daniel Vetter
On Tue, Jul 31, 2012 at 07:23:18AM -0700, Greg KH wrote: > On Tue, Jul 31, 2012 at 09:17:15AM +, Xu, Anhua wrote: > > Thanks Chris. I add this in the the commit description. The updated patch > > is below: > > > > commit 71c3ff04834a01c81a5843996b87397273eb538d > > Author: Xu Anhua > > Date

Re: [Intel-gfx] Find bugs in i915 driver

2012-08-01 Thread Paul Menzel
Dear Anhua, five additional comments to Greg’s ones. Am Dienstag, den 31.07.2012, 07:23 -0700 schrieb Greg KH: > On Tue, Jul 31, 2012 at 09:17:15AM +, Xu, Anhua wrote: > > Thanks Chris. I add this in the the commit description. The updated patch > > is below: > > > > commit 71c3ff04834a0

Re: [Intel-gfx] Find bugs in i915 driver

2012-07-31 Thread Greg KH
On Tue, Jul 31, 2012 at 09:17:15AM +, Xu, Anhua wrote: > Thanks Chris. I add this in the the commit description. The updated patch is > below: > > commit 71c3ff04834a01c81a5843996b87397273eb538d > Author: Xu Anhua > Date: Tue Jul 31 17:16:50 2012 +0800 > > i915: make the parameters p

Re: [Intel-gfx] Find bugs in i915 driver

2012-07-31 Thread Xu, Anhua
val 0x%08x\n", pipe, val); I915_WRITE(reg, val & ~LVDS_PORT_EN); POSTING_READ(reg); > -Original Message- > From: Chris Wilson [mailto:ch...@chris-wilson.co.uk] > Sent: Tuesday, July 31, 2012 3:58 PM > To: Xu, Anhua; intel-gfx@lists.free

Re: [Intel-gfx] Find bugs in i915 driver

2012-07-31 Thread Chris Wilson
On Tue, 31 Jul 2012 02:29:01 +, "Xu, Anhua" wrote: > Hi, I found some bugs in i915 driver when reviewing intel_display.c The > parameter passed-in for function hdmi/adpa/lvds_pipe_enabled() are not > coherent with functions' definition. > This is the patch. Patch looks good, you might wan

[Intel-gfx] Find bugs in i915 driver

2012-07-30 Thread Xu, Anhua
Hi, I found some bugs in i915 driver when reviewing intel_display.c The parameter passed-in for function hdmi/adpa/lvds_pipe_enabled() are not coherent with functions' definition. This is the patch. Thanks Eric commit 9128c5c29649a1eea4e7db9282d0aa57e4885ba8 Author: Xu Anhua Date: Mon Jul