On 06/10/2023 19:50, John Harrison wrote:
Tvrtko, would you have any thoughts on this one?
I wasn't really involved in that work so without digging deep can only
say that smatch seems to be noticing a genuine inconsistency. Whether or
not it is possible at runtime Matt should know better.
Tvrtko, would you have any thoughts on this one?
John.
On 10/4/2023 02:57, Dan Carpenter wrote:
Hello Matthew Brost,
This is a semi-automatic email about new static checker warnings.
The patch 22916bad07a5: "drm/i915: Move submission tasklet to
i915_sched_engine" from Jun 17, 2021, leads to
Hello Ville Syrjälä,
The patch f83b94d23770: "drm/i915/dsb: Use DEwake to combat PkgC
latency" from Jun 6, 2023 (linux-next), leads to the following Smatch
static checker warning:
drivers/gpu/drm/i915/display/intel_dsb.c:363 _intel_dsb_commit()
warn: always true condition '(dewake
Hello Matthew Brost,
This is a semi-automatic email about new static checker warnings.
The patch 22916bad07a5: "drm/i915: Move submission tasklet to
i915_sched_engine" from Jun 17, 2021, leads to the following Smatch
complaint:
drivers/gpu/drm/i915/gt/intel_execlists_submission.c:3659
rcu_v
Hello Ville Syrjälä,
This is a semi-automatic email about new static checker warnings.
The patch e046d1562491: "drm/i915/hdmi: Use connector->ddc everwhere"
from Aug 29, 2023, leads to the following Smatch complaint:
drivers/gpu/drm/i915/display/intel_ddi.c:4336 intel_hdmi_reset_link()
w
Hello Matthew Brost,
The patch 4e6835466771: "drm/i915/selftests: Add a cancel request
selftest that triggers a reset" from Jan 13, 2022, leads to the
following Smatch static checker warning:
drivers/gpu/drm/i915/selftests/i915_request.c:863 __cancel_reset()
warn: NEW missing erro
Hello Matt Roper,
The patch 12e6f6dc78e4: "drm/i915/display: Handle GMD_ID
identification in display code" from May 23, 2023, leads to the
following Smatch static checker warning:
drivers/gpu/drm/i915/i915_driver.c:850 i915_driver_probe()
error: 'i915' dereferencing possible ERR_P
Hello Chris Wilson,
The patch eb5c10cbbc2f: "drm/i915: Remove I915_USER_PRIORITY_SHIFT"
from Jan 20, 2021, leads to the following Smatch static checker
warning:
drivers/gpu/drm/i915/gt/selftest_execlists.c:1544 live_busywait_preempt()
error: 'ctx_hi' dereferencing possible ERR_PTR()
drivers/gpu/
[ I don't know why I'm getting weird new warnings today... Did
something change in the Kconfig? -dan ]
Hello Tvrtko Ursulin,
The patch 6407cf533217: "drm/i915/selftests: Stop using
kthread_stop()" from Oct 20, 2022, leads to the following Smatch
static checker warning:
drivers/gpu/dr
Hello Maarten Lankhorst,
This is a semi-automatic email about new static checker warnings.
The patch cf3e3e86d779: "drm/i915: Use ttm mmap handling for ttm
bo's." from Jun 10, 2021, leads to the following Smatch complaint:
./drivers/gpu/drm/i915/gem/i915_gem_mman.c:1008 i915_gem_mmap()
On 3/24/2023 02:12, Dan Carpenter wrote:
Hello John Harrison,
The patch 9bbba0667f37: "drm/i915/guc: Use GuC submission API version
number" from Nov 29, 2022, leads to the following Smatch static
checker warning:
drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c:821 intel_uc_fw_fetch()
w
Hi Dan,
I feared this might happened while reviewing this patch.. I believe it
is a false positive, see below:
On 29/03/2023 07:24, Dan Carpenter wrote:
Hello Ashutosh Dixit,
The patch 12d4eb20d9d8: "drm/i915/pmu: Use functions common with
sysfs to read actual freq" from Mar 15, 2023, lead
Hello Ashutosh Dixit,
The patch 12d4eb20d9d8: "drm/i915/pmu: Use functions common with
sysfs to read actual freq" from Mar 15, 2023, leads to the following
Smatch static checker warning:
drivers/gpu/drm/i915/gt/intel_rps.c:2110 __read_cagf()
error: uninitialized symbol 'freq'.
dr
Hello John Harrison,
The patch 9bbba0667f37: "drm/i915/guc: Use GuC submission API version
number" from Nov 29, 2022, leads to the following Smatch static
checker warning:
drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c:821 intel_uc_fw_fetch()
warn: passing zero to 'ERR_PTR'
drivers/gpu
On Fri, 10 Mar 2023, Dan Carpenter wrote:
> On Thu, Mar 09, 2023 at 04:51:10PM +0200, Jani Nikula wrote:
>> On Thu, 09 Mar 2023, Dan Carpenter wrote:
>> > Hello Jani Nikula,
>> >
>> > This is a semi-automatic email about new static checker warnings.
>> >
>> > The patch 1b28c1c789d0: "drm/i915/dmc
On Thu, Mar 09, 2023 at 04:51:10PM +0200, Jani Nikula wrote:
> On Thu, 09 Mar 2023, Dan Carpenter wrote:
> > Hello Jani Nikula,
> >
> > This is a semi-automatic email about new static checker warnings.
> >
> > The patch 1b28c1c789d0: "drm/i915/dmc: add i915_to_dmc() and
> > dmc->i915 and use them
On Thu, 09 Mar 2023, Dan Carpenter wrote:
> Hello Jani Nikula,
>
> This is a semi-automatic email about new static checker warnings.
>
> The patch 1b28c1c789d0: "drm/i915/dmc: add i915_to_dmc() and
> dmc->i915 and use them" from Mar 1, 2023, leads to the following
> Smatch complaint:
>
> dri
Hello Jani Nikula,
This is a semi-automatic email about new static checker warnings.
The patch 1b28c1c789d0: "drm/i915/dmc: add i915_to_dmc() and
dmc->i915 and use them" from Mar 1, 2023, leads to the following
Smatch complaint:
drivers/gpu/drm/i915/display/intel_dmc.c:1162
intel_dmc_debu
Hello Matt Roper,
The patch 3100240bf846: "drm/i915/mtl: Add hardware-level lock for
steering" from Nov 28, 2022, leads to the following Smatch static
checker warning:
drivers/gpu/drm/i915/gt/intel_gt_mcr.c:379 intel_gt_mcr_lock() warn: sleeping
in atomic context
CALL TREE:
intel_engine_reset()
Hello Matthew Brost,
The patch cad46a332f3d: "drm/i915/guc: Suspend/resume implementation
for new interface" from Jul 26, 2021, leads to the following Smatch
static checker warning:
drivers/gpu/drm/i915/gt/uc/intel_guc.c:655 intel_guc_suspend()
error: passing non negative 26843545
On 07/02/2023 08:49, Dan Carpenter wrote:
On Mon, Feb 06, 2023 at 04:59:36PM +, Tvrtko Ursulin wrote:
On 06/02/2023 14:19, Dan Carpenter wrote:
[ Ancient code but the warning showed up again because the function was
renamed or something? - dan ]
Hello Chris Wilson,
The patch 871dfb
On Mon, Feb 06, 2023 at 04:59:36PM +, Tvrtko Ursulin wrote:
>
> On 06/02/2023 14:19, Dan Carpenter wrote:
> > [ Ancient code but the warning showed up again because the function was
> >renamed or something? - dan ]
> >
> > Hello Chris Wilson,
> >
> > The patch 871dfbd67d4e: "drm/i915: Al
On 06/02/2023 14:19, Dan Carpenter wrote:
[ Ancient code but the warning showed up again because the function was
renamed or something? - dan ]
Hello Chris Wilson,
The patch 871dfbd67d4e: "drm/i915: Allow compaction upto SWIOTLB max
segment size" from Oct 11, 2016, leads to the following S
[ Ancient code but the warning showed up again because the function was
renamed or something? - dan ]
Hello Chris Wilson,
The patch 871dfbd67d4e: "drm/i915: Allow compaction upto SWIOTLB max
segment size" from Oct 11, 2016, leads to the following Smatch static
checker warning:
drivers/
I see this both on the vfio next branch and on the gvt-next branch of
https://github.com/intel/gvt-linux. I boot my system with
i915.enable_gvt=1 and load the kvmgt module. A vGPU device is
automatically created by mdevctl. If I then bind vfio-pci directly to
the GPU using 'driverctl --nosave
On Thu, Sep 22, 2022 at 01:01:48PM -0700, John Harrison wrote:
> On 9/22/2022 07:26, Dan Carpenter wrote:
> > Hello Matthew Brost,
> >
> > The patch 6b540bf6f143: "drm/i915/guc: Implement multi-lrc
> > submission" from Oct 14, 2021, leads to the following Smatch static
> > checker warning:
> >
>
On 9/22/2022 07:26, Dan Carpenter wrote:
Hello Matthew Brost,
The patch 6b540bf6f143: "drm/i915/guc: Implement multi-lrc
submission" from Oct 14, 2021, leads to the following Smatch static
checker warning:
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:752
__guc_add_request()
Hello Matthew Brost,
The patch 6b540bf6f143: "drm/i915/guc: Implement multi-lrc
submission" from Oct 14, 2021, leads to the following Smatch static
checker warning:
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:752
__guc_add_request()
warn: refcount leak 'ce->ref.refcount.ref
Hello Ramalingam C,
The patch da0595ae91da: "drm/i915/migrate: Evict and restore the
flatccs capable lmem obj" from Apr 5, 2022, leads to the following
Smatch static checker warning:
drivers/gpu/drm/i915/gt/intel_migrate.c:832 intel_context_migrate_copy() error:
uninitialized symbol 'ccs_cache_l
Hi,
Please file bug to gitlab:
https://gitlab.freedesktop.org/drm/intel/-/wikis/How-to-file-i915-bugs
> -Original Message-
> From: Intel-gfx On Behalf Of Jeffrey
> Ellison
> Sent: tiistai 29. maaliskuuta 2022 5.38
> To: intel-gfx@lists.freedesktop.org
> Subject: [Inte
Hello,
I have an Optimus laptop with Intel Tiger Lake H GT1 integrated graphics
(i7-11800H) and NVIDIA RTX 3080 Mobile GPU. The inbuilt display is 165 Hz
and is connected to the IGPU by eDP. As of any Kernel version 5.16 onwards,
Xrandr only detects 60 Hz as a possible refresh rate. The problem al
Hello Thomas Hellström,
The patch 2f6b90da9192: "drm/i915: Use vma resources for async
unbinding" from Jan 10, 2022, leads to the following Smatch static
checker warning:
drivers/gpu/drm/i915/i915_vma.c:515 i915_vma_bind()
error: we previously assumed 'work->vma_res' could be null
Hello Ville Syrjälä,
The patch 6d8ebef53c2c: "drm/i915: Extract
intel_bw_check_data_rate()" from Feb 18, 2022, leads to the following
Smatch static checker warning:
drivers/gpu/drm/i915/display/intel_bw.c:922 intel_bw_atomic_check()
error: we previously assumed 'new_bw_state' coul
Hello Chris Wilson,
The patch 16f2941ad307: "drm/i915/gt: Replace direct submit with
direct call to tasklet" from Dec 24, 2020, leads to the following
Smatch static checker warning:
drivers/gpu/drm/i915/gt/selftest_lrc.c:1616 garbage_reset()
warn: sleeping in atomic context
drive
Hello Maarten Lankhorst,
This is a semi-automatic email about new static checker warnings.
The patch f6c466b84cfa: "drm/i915: Add support for moving fence
waiting" from Nov 22, 2021, leads to the following Smatch complaint:
drivers/gpu/drm/i915/i915_vma.c:1015 i915_vma_pin_ww()
error: w
On Thu, Nov 18, 2021 at 03:15:31PM +, Matthew Auld wrote:
> On 18/11/2021 15:01, Dan Carpenter wrote:
> > Hello Matthew Auld,
> >
> > The patch 7ae034590cea: "drm/i915/ttm: add tt shmem backend" from Oct
> > 18, 2021, leads to the following Smatch static checker warning:
> >
> > drivers/g
On 18/11/2021 15:01, Dan Carpenter wrote:
Hello Matthew Auld,
The patch 7ae034590cea: "drm/i915/ttm: add tt shmem backend" from Oct
18, 2021, leads to the following Smatch static checker warning:
drivers/gpu/drm/i915/gem/i915_gem_ttm.c:335 i915_ttm_eviction_valuable()
warn: sign
Hello Matthew Auld,
The patch 7ae034590cea: "drm/i915/ttm: add tt shmem backend" from Oct
18, 2021, leads to the following Smatch static checker warning:
drivers/gpu/drm/i915/gem/i915_gem_ttm.c:335 i915_ttm_eviction_valuable()
warn: signedness bug returning '(-16)'
drivers/gpu/dr
On Fri, Oct 01, 2021 at 05:20:17PM +0300, Ville Syrjälä wrote:
> On Fri, Oct 01, 2021 at 04:25:35PM +0300, Dan Carpenter wrote:
> > Hello Imre Deak,
> >
> > This is a semi-automatic email about new static checker warnings.
> >
> > The patch 3e0abc7661c8: "drm/i915/tc: Fix TypeC PHY
> > connect/d
On Fri, Oct 01, 2021 at 04:25:35PM +0300, Dan Carpenter wrote:
> Hello Imre Deak,
>
> This is a semi-automatic email about new static checker warnings.
>
> The patch 3e0abc7661c8: "drm/i915/tc: Fix TypeC PHY
> connect/disconnect logic on ADL-P" from Sep 29, 2021, leads to the
> following Smatch
Hello Imre Deak,
This is a semi-automatic email about new static checker warnings.
The patch 3e0abc7661c8: "drm/i915/tc: Fix TypeC PHY
connect/disconnect logic on ADL-P" from Sep 29, 2021, leads to the
following Smatch complaint:
drivers/gpu/drm/i915/display/intel_ddi.c:4028 intel_ddi_enco
On 8/13/2021 4:31 AM, Dan Carpenter wrote:
Nathan has probably already sent fixes for these. Nathan, could you CC
kernel-janitors on static checker fixes? That way we wouldn't send so
many duplicate patches.
Sure. I did not send any fixes prior to this email but I just sent
https://lore.kerne
Nathan has probably already sent fixes for these. Nathan, could you CC
kernel-janitors on static checker fixes? That way we wouldn't send so
many duplicate patches.
Uninitialized variable warnings are really frustrating. We disabled the
GCC warning for them because the new GCC is crap. So now
Hello Chris Wilson,
The patch 16f2941ad307: "drm/i915/gt: Replace direct submit with
direct call to tasklet" from Dec 24, 2020, leads to the following
static checker warning:
kernel/softirq.c:887 tasklet_unlock_wait()
warn: sleeping in atomic context
drivers/gpu/drm/i915/gt/selft
Hello Dan,
On 18.06.2021 09:38, Dan Carpenter wrote:
> Hello Michal Wajdeczko,
>
> The patch b839a869dfc9: "drm/i915/guc: Add support for data reporting
> in GuC responses" from Mar 26, 2018, leads to the following static
> checker warning:
>
> drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c:307
Hello Michal Wajdeczko,
The patch b839a869dfc9: "drm/i915/guc: Add support for data reporting
in GuC responses" from Mar 26, 2018, leads to the following static
checker warning:
drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c:307 intel_guc_ct_enable()
error: passing non negative 4095 to
On Wed, Mar 24, 2021 at 10:22:54AM +0300, Dan Carpenter wrote:
> Hello Ville Syrjälä,
>
> This is a semi-automatic email about new static checker warnings.
>
> The patch 97bc7ffa1b1e: "drm/i915: Fix enabled_planes bitmask" from
> Mar 5, 2021, leads to the following Smatch complaint:
>
> driv
Hello Ville Syrjälä,
This is a semi-automatic email about new static checker warnings.
The patch 97bc7ffa1b1e: "drm/i915: Fix enabled_planes bitmask" from
Mar 5, 2021, leads to the following Smatch complaint:
drivers/gpu/drm/i915/display/intel_atomic_plane.c:332
intel_plane_atomic_check_wit
On Mon, Mar 22, 2021 at 07:00:38PM +0100, Hans de Goede wrote:
> Hi,
>
> On 3/22/21 5:00 PM, Ville Syrjälä wrote:
> > On Mon, Mar 22, 2021 at 04:51:26PM +0100, Hans de Goede wrote:
> >> Hi,
> >>
> >> On 3/22/21 3:53 PM, Ville Syrjälä wrote:
> >>> On Mon, Mar 22, 2021 at 11:45:39AM +0100, Hans de G
Hi,
On 3/22/21 5:00 PM, Ville Syrjälä wrote:
> On Mon, Mar 22, 2021 at 04:51:26PM +0100, Hans de Goede wrote:
>> Hi,
>>
>> On 3/22/21 3:53 PM, Ville Syrjälä wrote:
>>> On Mon, Mar 22, 2021 at 11:45:39AM +0100, Hans de Goede wrote:
Hi,
On 3/14/21 11:30 AM, Mario Hüttel wrote:
> H
On Mon, Mar 22, 2021 at 04:51:26PM +0100, Hans de Goede wrote:
> Hi,
>
> On 3/22/21 3:53 PM, Ville Syrjälä wrote:
> > On Mon, Mar 22, 2021 at 11:45:39AM +0100, Hans de Goede wrote:
> >> Hi,
> >>
> >> On 3/14/21 11:30 AM, Mario Hüttel wrote:
> >>> Hello,
> >>>
> >>> It seems, like the mailing list,
Hi,
On 3/22/21 3:53 PM, Ville Syrjälä wrote:
> On Mon, Mar 22, 2021 at 11:45:39AM +0100, Hans de Goede wrote:
>> Hi,
>>
>> On 3/14/21 11:30 AM, Mario Hüttel wrote:
>>> Hello,
>>>
>>> It seems, like the mailing list, didn't accept my email. So I'll send
>>> it again:
>>>
>>> I want to report a bug.
On Sun, Mar 14, 2021 at 11:30:12AM +0100, Mario Hüttel wrote:
> Hello,
>
> It seems, like the mailing list, didn't accept my email. So I'll send
> it again:
>
> I want to report a bug. I have a PC with Intel i7-6700K processor (with
> integrated graphics) and an AsRock Fatal1ty Z170 Gaming K6 mai
On Mon, Mar 22, 2021 at 11:45:39AM +0100, Hans de Goede wrote:
> Hi,
>
> On 3/14/21 11:30 AM, Mario Hüttel wrote:
> > Hello,
> >
> > It seems, like the mailing list, didn't accept my email. So I'll send
> > it again:
> >
> > I want to report a bug. I have a PC with Intel i7-6700K processor (with
Hi,
On 3/14/21 11:30 AM, Mario Hüttel wrote:
> Hello,
>
> It seems, like the mailing list, didn't accept my email. So I'll send
> it again:
>
> I want to report a bug. I have a PC with Intel i7-6700K processor (with
> integrated graphics) and an AsRock Fatal1ty Z170 Gaming K6 mainboard. I
> use
Hello,
It seems, like the mailing list, didn't accept my email. So I'll send
it again:
I want to report a bug. I have a PC with Intel i7-6700K processor (with
integrated graphics) and an AsRock Fatal1ty Z170 Gaming K6 mainboard. I
use the CPU's integrated graphics.
My system is Archlinux with Ker
Hi,
On Sun, 2021-03-14 at 17:25 +0200, Imre Deak wrote:
> > I used git bisect to find the commit that causes this behavior on
> > my
> > machine. The result is: fe0f1e3bfdfeb53e18f1206aea4f40b9bd1f291c is
> > the
> > first bad commit (drm/i915: Shut down displays gracefully on
> > reboot).
> >
>
Hi,
On Sun, Mar 14, 2021 at 02:48:08PM +0100, Mario Hüttel wrote:
> Hello,
>
> It seems, like the mailing list, didn't accept my previous emails. So
> I'll send it again:
>
> I want to report a bug. I've got a PC with Intel i7-6700K processor
> (with integrated graphics) and an AsRock Fatal1ty Z
Hello,
It seems, like the mailing list, didn't accept my previous emails. So
I'll send it again:
I want to report a bug. I've got a PC with Intel i7-6700K processor
(with integrated graphics) and an AsRock Fatal1ty Z170 Gaming K6
mainboard. I use the CPU's integrated graphics.
My system is Archli
[ Sorry, I don't know why Smatch is complaining about two year old code.
The warning is valid enough, though. - dan ]
Hello Matthew Auld,
The patch 14d1b9a6247c: "drm/i915: buddy allocator" from Aug 9, 2019,
leads to the following static checker warning:
drivers/gpu/drm/i915/selftests
Similar bug:
drivers/gpu/drm/i915/display/intel_color.c:794 bdw_load_luts() error: we
previously assumed 'gamma_lut' could be null (see line 784)
regards,
dan carpenter
On Mon, Nov 02, 2020 at 04:07:36PM +0300, Dan Carpenter wrote:
> Hello Ville Syrjälä,
>
> This is a semi-automatic email abou
Hello Ville Syrjälä,
This is a semi-automatic email about new static checker warnings.
The patch 7852ddd5d60a: "drm/i915: Replace some gamma_mode ifs with
switches" from Sep 25, 2020, leads to the following Smatch complaint:
drivers/gpu/drm/i915/display/intel_color.c:765 ivb_load_luts()
Hello Maarten Lankhorst,
This is a semi-automatic email about new static checker warnings.
The patch 80f0b679d6f0: "drm/i915: Add an implementation for
i915_gem_ww_ctx locking, v2." from Aug 19, 2020, leads to the
following Smatch complaint:
drivers/gpu/drm/i915/gem/i915_gem_object.h:130 __i
Hello Maarten Lankhorst,
The patch 8a929c9eb1c2: "drm/i915: Use ww pinning for
intel_context_create_request()" from Aug 19, 2020, leads to the
following static checker warning:
drivers/gpu/drm/i915/gt/intel_context.c:481
intel_context_create_request()
error: uninitialized symbol
Hey Dave,
I think this is a bad merge:
The patch c43ce12328df: "drm/i915: Use per object locking in execbuf,
v12." from Aug 19, 2020, leads to the following static checker
warning:
drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:1459 __reloc_entry_gpu()
warn: signedness bug return
Hello Daniele Ceraolo Spurio,
This is a semi-automatic email about new static checker warnings.
The patch 792592e72aba: "drm/i915: Move the engine mask to
intel_gt_info" from Jul 7, 2020, leads to the following Smatch
complaint:
drivers/gpu/drm/i915/i915_gpu_error.c:801 __err_print_to_sgl()
Quoting Dan Carpenter (2020-05-07 10:17:14)
> Hello Chris Wilson,
>
> The patch e3793468b466: "drm/i915: Use the async worker to avoid
> reclaim tainting the ggtt->mutex" from Jan 30, 2020, leads to the
> following static checker warning:
>
> drivers/gpu/drm/i915/i915_vma.c:356 i915_vma_w
Hello Chris Wilson,
The patch e3793468b466: "drm/i915: Use the async worker to avoid
reclaim tainting the ggtt->mutex" from Jan 30, 2020, leads to the
following static checker warning:
drivers/gpu/drm/i915/i915_vma.c:356 i915_vma_wait_for_bind()
warn: 's64max' cannot fit into 'boo
Quoting Dan Carpenter (2020-04-29 14:23:45)
> Hello Chris Wilson,
>
> The patch 9c878557b1eb: "drm/i915/gt: Use the RPM config register to
> determine clk frequencies" from Apr 24, 2020, leads to the following
> static checker warning:
>
> drivers/gpu/drm/i915/gt/debugfs_gt_pm.c:407 frequ
Hello Chris Wilson,
The patch 9c878557b1eb: "drm/i915/gt: Use the RPM config register to
determine clk frequencies" from Apr 24, 2020, leads to the following
static checker warning:
drivers/gpu/drm/i915/gt/debugfs_gt_pm.c:407 frequency_show()
error: uninitialized symbol 'rpcurupei
Quoting Dan Carpenter (2019-12-13 12:20:58)
> Hello Chris Wilson,
>
> The patch 65c29dbb19b2: "drm/i915: Use the i915_device name for
> identifying our request fences" from Dec 11, 2019, leads to the
> following static checker warning:
>
> drivers/gpu/drm/i915/i915_request.c:77 i915_fence
Hello Chris Wilson,
The patch 65c29dbb19b2: "drm/i915: Use the i915_device name for
identifying our request fences" from Dec 11, 2019, leads to the
following static checker warning:
drivers/gpu/drm/i915/i915_request.c:77 i915_fence_get_timeline_name()
warn: this array is non-NULL.
Quoting Dan Carpenter (2019-11-14 06:54:37)
> Hello Chris Wilson,
>
> The patch f40a7b7558ef: "drm/i915: Initial selftests for exercising
> eviction" from Feb 13, 2017, leads to the following static checker
> warning:
>
> drivers/gpu/drm/i915/selftests/i915_gem_evict.c:202 igt_overcommit(
Hello Chris Wilson,
The patch f40a7b7558ef: "drm/i915: Initial selftests for exercising
eviction" from Feb 13, 2017, leads to the following static checker
warning:
drivers/gpu/drm/i915/selftests/i915_gem_evict.c:202 igt_overcommit()
warn: passing zero to 'PTR_ERR'
drivers/gpu/drm
Quoting Dan Carpenter (2019-11-06 13:48:14)
> Hello Chris Wilson,
>
> The patch a4e7ccdac38e: "drm/i915: Move context management under GEM"
> from Oct 4, 2019, leads to the following static checker warning:
>
> drivers/gpu/drm/i915/gem/i915_gem_context.c:980 set_ppgtt()
> warn: 'c
Hello Chris Wilson,
The patch a4e7ccdac38e: "drm/i915: Move context management under GEM"
from Oct 4, 2019, leads to the following static checker warning:
drivers/gpu/drm/i915/gem/i915_gem_context.c:980 set_ppgtt()
warn: 'ctx->mutex' both locked and unlocked.
drivers/gpu/drm/i915
Quoting Dan Carpenter (2019-10-11 12:42:09)
> Hello Chris Wilson,
>
> This is a semi-automatic email about new static checker warnings.
>
> The patch 50d16d44cce4: "drm/i915/selftests: Exercise context
> switching in parallel" from Sep 30, 2019, leads to the following
> Smatch complaint:
>
>
Hello Chris Wilson,
This is a semi-automatic email about new static checker warnings.
The patch 50d16d44cce4: "drm/i915/selftests: Exercise context
switching in parallel" from Sep 30, 2019, leads to the following
Smatch complaint:
drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c:349
Quoting Dan Carpenter (2019-08-27 10:40:16)
> Hello Chris Wilson,
>
> The patch 75b974a859e5: "drm/i915/selftests: Teach igt_gpu_fill_dw()
> to take intel_context" from Aug 24, 2019, leads to the following
> static checker warning:
>
> drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c
Hello Chris Wilson,
The patch 75b974a859e5: "drm/i915/selftests: Teach igt_gpu_fill_dw()
to take intel_context" from Aug 24, 2019, leads to the following
static checker warning:
drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c:402 igt_ctx_exec()
error: 'ce' dereferencing poss
Hello Matthew Auld,
The patch 14d1b9a6247c: "drm/i915: buddy allocator" from Aug 9, 2019,
leads to the following static checker warning:
drivers/gpu/drm/i915/selftests/i915_buddy.c:670 igt_buddy_alloc_range()
error: we previously assumed 'block' could be null (see line 665)
drive
Quoting Daniele Ceraolo Spurio (2019-07-23 16:08:49)
>
>
> On 7/23/2019 8:00 AM, Dan Carpenter wrote:
> > Hello Daniele Ceraolo Spurio,
> >
> > The patch 84b1ca2f0e68: "drm/i915/uc: prefer intel_gt over i915 in
> > GuC/HuC paths" from Jul 13, 2019, leads to the following static
> > checker warnin
On 7/23/2019 8:00 AM, Dan Carpenter wrote:
Hello Daniele Ceraolo Spurio,
The patch 84b1ca2f0e68: "drm/i915/uc: prefer intel_gt over i915 in
GuC/HuC paths" from Jul 13, 2019, leads to the following static
checker warning:
drivers/gpu/drm/i915/gt/uc/intel_huc.c:173 intel_huc_check_statu
Hello Daniele Ceraolo Spurio,
The patch 84b1ca2f0e68: "drm/i915/uc: prefer intel_gt over i915 in
GuC/HuC paths" from Jul 13, 2019, leads to the following static
checker warning:
drivers/gpu/drm/i915/gt/uc/intel_huc.c:173 intel_huc_check_status()
warn: masking a bool
drivers/gpu/d
Quoting Dan Carpenter (2019-05-30 09:13:01)
> Hello Chris Wilson,
>
> The patch cc731f5a3b1f: "drm/i915: Trim struct_mutex hold duration
> for i915_gem_free_objects" from Oct 13, 2017, leads to the following
> static checker warning:
>
> drivers/gpu/drm/i915/gem/i915_gem_object.c:195
> _
Hello Chris Wilson,
The patch cc731f5a3b1f: "drm/i915: Trim struct_mutex hold duration
for i915_gem_free_objects" from Oct 13, 2017, leads to the following
static checker warning:
drivers/gpu/drm/i915/gem/i915_gem_object.c:195 __i915_gem_free_objects()
error: we previously assumed
On Wed, May 29, 2019 at 01:08:59PM +0100, Chris Wilson wrote:
> Quoting Dan Carpenter (2019-05-29 12:52:43)
> > Hello Tvrtko Ursulin,
> >
> > The patch c5d3e39caa45: "drm/i915: Engine discovery query" from May
> > 22, 2019, leads to the following static checker warning:
> >
> > drivers/gp
Quoting Dan Carpenter (2019-05-29 12:52:43)
> Hello Tvrtko Ursulin,
>
> The patch c5d3e39caa45: "drm/i915: Engine discovery query" from May
> 22, 2019, leads to the following static checker warning:
>
> drivers/gpu/drm/i915/i915_query.c:134 query_engine_info()
> warn: calling '__c
Hello Tvrtko Ursulin,
The patch c5d3e39caa45: "drm/i915: Engine discovery query" from May
22, 2019, leads to the following static checker warning:
drivers/gpu/drm/i915/i915_query.c:134 query_engine_info()
warn: calling '__copy_to_user()' without access_ok()
drivers/gpu/drm/i915/i
On Wed, May 29, 2019 at 01:03:35PM +0300, Dan Carpenter wrote:
> Hi Syrjälä,
>
> I had a question about commit c457d9cf256e: ("drm/i915: Make sure we have
> enough memory bandwidth on ICL").
>
> drivers/gpu/drm/i915/intel_bw.c
> 64 static int icl_pcode_read_qgv_point_info(struct drm_i915_pri
Hi Syrjälä,
I had a question about commit c457d9cf256e: ("drm/i915: Make sure we have
enough memory bandwidth on ICL").
drivers/gpu/drm/i915/intel_bw.c
64 static int icl_pcode_read_qgv_point_info(struct drm_i915_private
*dev_priv,
65 struct inte
Hello Chris Wilson,
The patch 6d06779e8672: "drm/i915: Load balancing across a virtual
engine" from May 21, 2019, leads to the following static checker
warning:
drivers/gpu/drm/i915/gt/intel_lrc.c:3338
intel_execlists_create_virtual()
warn: assigning (-2) to unsigned variable 've
Hello Tvrtko Ursulin,
The patch 805446c8347c: "drm/i915: Introduce concept of a
sub-platform" from Mar 27, 2019, leads to the following static
checker warning:
drivers/gpu/drm/i915/intel_device_info.c:807
intel_device_info_subplatform_init()
error: uninitialized symbol 'mask'.
d
Hello Chris Wilson,
The patch f40a7b7558ef: "drm/i915: Initial selftests for exercising
eviction" from Feb 13, 2017, leads to the following static checker
warning:
drivers/gpu/drm/i915/selftests/i915_gem_evict.c:193 igt_overcommit()
warn: passing a valid pointer to 'PTR_ERR'
driv
[ This code is old, but it's pretty confusing so I decided to send the
email anyway. - dan ]
Hello Chris Wilson,
The patch 03ac84f1830e: "drm/i915: Pass around sg_table to
get_pages/put_pages backend" from Oct 28, 2016, leads to the
following static checker warning:
drivers/gpu/drm/i9
Hello Anusha Srivatsa,
The patch 08cadae8e157: "i915/dp/fec: Cache the FEC_CAPABLE DPCD
register" from Nov 1, 2018, leads to the following static checker
warning:
drivers/gpu/drm/i915/intel_dp.c:3846 intel_dp_get_dsc_sink_cap()
warn: inconsistent indenting
drivers/gpu/drm/i915/in
On Fri, Jun 08, 2018 at 03:50:47PM +0300, Jani Nikula wrote:
> On Fri, 08 Jun 2018, Dan Carpenter wrote:
> > Hello Jani Nikula,
> >
> > The patch 2a33d93486f2: "drm/i915/bios: add support for MIPI sequence
> > block v3" from Jan 11, 2016, leads to the following static checker
> > warning:
> >
> >
On Fri, 08 Jun 2018, Dan Carpenter wrote:
> Hello Jani Nikula,
>
> The patch 2a33d93486f2: "drm/i915/bios: add support for MIPI sequence
> block v3" from Jan 11, 2016, leads to the following static checker
> warning:
>
> drivers/gpu/drm/i915/intel_bios.c:926 goto_next_sequence_v3()
> w
Hello Jani Nikula,
The patch 2a33d93486f2: "drm/i915/bios: add support for MIPI sequence
block v3" from Jan 11, 2016, leads to the following static checker
warning:
drivers/gpu/drm/i915/intel_bios.c:926 goto_next_sequence_v3()
warn: potentially one past the end of array 'data[inde
On Thu, Mar 15, 2018 at 01:17:23PM +, Chris Wilson wrote:
> Quoting Dan Carpenter (2018-03-15 13:10:30)
> > Hello Chris Wilson,
> >
> > The patch 2889caa92321: "drm/i915: Eliminate lots of iterations over
> > the execobjects array" from Jun 16, 2017, leads to the following
> > static checker w
1 - 100 of 131 matches
Mail list logo
